Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | View Code Duplication | class Fees extends LazyResourceList implements \Countable, \Iterator, \ArrayAccess |
|
|
|||
14 | { |
||
15 | use ReadOnlyArrayAccess; |
||
16 | use IterableCollection; |
||
17 | |||
18 | /** |
||
19 | * The User object this Fees list belongs to. |
||
20 | * |
||
21 | * @var User |
||
22 | */ |
||
23 | public $user; |
||
24 | |||
25 | /** |
||
26 | * Fees constructor. |
||
27 | * |
||
28 | * @param Client $client |
||
29 | * @param User $user |
||
30 | */ |
||
31 | public function __construct(Client $client, User $user) |
||
36 | |||
37 | /** |
||
38 | * Get a single Fee by id. |
||
39 | * |
||
40 | * @param string $id |
||
41 | * |
||
42 | * @return Fee |
||
43 | */ |
||
44 | public function get($id) |
||
48 | |||
49 | /** |
||
50 | * Convert a retrieved resource object to a model object. |
||
51 | * |
||
52 | * @param $data |
||
53 | * |
||
54 | * @return Fee |
||
55 | */ |
||
56 | public function convertToResource($data) |
||
60 | |||
61 | /** |
||
62 | * Generate the base URL for this resource. |
||
63 | * |
||
64 | * @return string |
||
65 | */ |
||
66 | protected function urlBase() |
||
70 | } |
||
71 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.