Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
11 | View Code Duplication | class ElectronicCollections extends LazyResourceList implements \Countable, \Iterator, \ArrayAccess |
|
|
|||
12 | { |
||
13 | use ReadOnlyArrayAccess; |
||
14 | use IterableCollection; |
||
15 | |||
16 | /** |
||
17 | * The Bib this ElectronicCollections list belongs to. |
||
18 | * |
||
19 | * @var Bib |
||
20 | */ |
||
21 | public $bib; |
||
22 | |||
23 | /** |
||
24 | * ElectronicCollections constructor. |
||
25 | * |
||
26 | * @param Client $client |
||
27 | * @param Bib $bib |
||
28 | */ |
||
29 | public function __construct(Client $client, Bib $bib) |
||
34 | |||
35 | /** |
||
36 | * Get a single electronic collection record by id. |
||
37 | * |
||
38 | * @param string $id |
||
39 | * |
||
40 | * @return Representation |
||
41 | */ |
||
42 | public function get($id) |
||
46 | |||
47 | /** |
||
48 | * Convert a data element to a resource object. |
||
49 | * |
||
50 | * @param $data |
||
51 | * |
||
52 | * @return Representation |
||
53 | */ |
||
54 | protected function convertToResource($data) |
||
59 | |||
60 | /** |
||
61 | * Generate the base URL for this resource. |
||
62 | * |
||
63 | * @return string |
||
64 | */ |
||
65 | protected function urlBase() |
||
69 | } |
||
70 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.