scriptotek / colligator-backend

app/Scrapers/UnivScraper.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
 
     public function scrape(Crawler $crawler)
     {
-        $texts = $crawler->filter('.book-details > div')->each(function (Crawler $node) {
+        $texts = $crawler->filter('.book-details > div')->each(function(Crawler $node) {
             if (strpos($node->attr('class'), 'row') === false) {
                 return $node->text();
             }

app/Search/SearchableDocument.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
      */
     public function toArray()
     {
-        $body = $this->doc->bibliographic;  // PHP makes a copy for us
+        $body = $this->doc->bibliographic; // PHP makes a copy for us
 
         $body['id'] = $this->doc->id;
         $body['bibsys_id'] = $this->doc->bibsys_id;

app/XisbnResponse.php

Spacing +5 added lines, -5 removed lines

@@ -10,12 +10,12 @@ 
         'AA'    => 'audio',
         'AA BA' => 'audio book',
         'BA'    => 'book',
-        'BA DA' => 'ebook',      // Yes, we DO actually get these
+        'BA DA' => 'ebook', // Yes, we DO actually get these
         'BB'    => 'hardcover',
-        'BB BC' => 'book',       // ... and these
-        'BB DA' => 'ebook',      // ... and these
+        'BB BC' => 'book', // ... and these
+        'BB DA' => 'ebook', // ... and these
         'BC'    => 'paperback',
-        'BC DA' => 'ebook',      // ... and these
+        'BC DA' => 'ebook', // ... and these
         'DA'    => 'digital',
         'FA'    => 'film/transp.',
         'MA'    => 'microform',
@@ -49,7 +49,7 @@ 
         if (isset($this->formats[$formStr])) {
             return $this->formats[$formStr];
         }
-        $formStr = implode(' ', array_map(function ($el) {
+        $formStr = implode(' ', array_map(function($el) {
             return $this->formats[$el];
         }, $forms));
         \Log::warning(sprintf('Unknown form: %s', $formStr));

app/Http/Controllers/CollectionsController.php

Doc Comments +2 added lines, -2 removed lines

@@ -9,7 +9,7 @@ 
     /**
      * Display a listing of the resource.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function index()
     {
@@ -21,7 +21,7 @@ 
      *
      * @param int $id
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function show($id)
     {

app/Console/Commands/OaiPmhHarvest.php

Spacing +10 added lines, -10 removed lines

@@ -69,7 +69,7 @@ 
         $this->comment('Available configurations:');
         $config = \Config::get('oaipmh.harvests', null);
         foreach (array_keys($config) as $key) {
-            $this->comment(' - ' . $key);
+            $this->comment(' - '.$key);
         }
     }
 
@@ -80,7 +80,7 @@ 
 
             return false;
         }
-        $harvestConfig = \Config::get('oaipmh.harvests.' . $this->argument('name'), null);
+        $harvestConfig = \Config::get('oaipmh.harvests.'.$this->argument('name'), null);
         if (is_null($harvestConfig)) {
             $this->error('Unknown configuration specified.');
             $this->listConfigurations();
@@ -129,7 +129,7 @@ 
         }
 
         $harvestName = $this->argument('name');
-        $harvestConfig = \Config::get('oaipmh.harvests.' . $harvestName, null);
+        $harvestConfig = \Config::get('oaipmh.harvests.'.$harvestName, null);
 
         $this->comment('');
         $this->info(sprintf('[%s] Starting harvest "%s"',
@@ -140,9 +140,9 @@ 
         if ($this->option('from-dump')) {
             $this->comment(' - From local dump');
         } else {
-            $this->comment(' - Repo: ' . $harvestConfig['url']);
-            $this->comment(' - Schema: ' . $harvestConfig['schema']);
-            $this->comment(' - Set: ' . $harvestConfig['set']);
+            $this->comment(' - Repo: '.$harvestConfig['url']);
+            $this->comment(' - Schema: '.$harvestConfig['schema']);
+            $this->comment(' - Set: '.$harvestConfig['set']);
 
             foreach (['from', 'until', 'resume', 'daily'] as $key) {
                 if (!is_null($this->option($key))) {
@@ -154,11 +154,11 @@ 
         // For timing
         $this->startTime = $this->batchTime = microtime(true) - 1;
 
-        \Event::listen('Colligator\Events\OaiPmhHarvestStatus', function ($event) {
+        \Event::listen('Colligator\Events\OaiPmhHarvestStatus', function($event) {
             $this->status($event->harvested, $event->position);
         });
 
-        \Event::listen('Colligator\Events\OaiPmhHarvestComplete', function ($event) {
+        \Event::listen('Colligator\Events\OaiPmhHarvestComplete', function($event) {
             $this->info(sprintf('[%s] Harvest complete, got %d records in %d seconds',
                 strftime('%Y-%m-%d %H:%M:%S'),
                 $event->count,
@@ -166,8 +166,8 @@ 
             ));
         });
 
-        \Event::listen('Colligator\Events\JobError', function ($event) {
-            \Log::error('[OaiPmhHarvest] ' . $event->msg);
+        \Event::listen('Colligator\Events\JobError', function($event) {
+            \Log::error('[OaiPmhHarvest] '.$event->msg);
             $this->error($event->msg);
         });
 

app/Console/Commands/OaiPmhHarvestInfo.php

Spacing +8 added lines, -8 removed lines

@@ -57,7 +57,7 @@ 
         $name = $this->argument('name');
         $parser = new MarcParser();
 
-        $files = Storage::disk('local')->files('harvests/' . $name);
+        $files = Storage::disk('local')->files('harvests/'.$name);
 
         $info = [
             'count'                => 0,
@@ -101,29 +101,29 @@ 
                     if ($localHoldingsCount > 10) {
                         $localHoldingsCount = 10;
                     }
-                    $info['holdings_count'][$holdingsCount] = array_get($info, 'holdings_count.' . $holdingsCount, 0) + 1;
-                    $info['local_holdings_count'][$localHoldingsCount] = array_get($info, 'local_holdings_count.' . $localHoldingsCount, 0) + 1;
+                    $info['holdings_count'][$holdingsCount] = array_get($info, 'holdings_count.'.$holdingsCount, 0) + 1;
+                    $info['local_holdings_count'][$localHoldingsCount] = array_get($info, 'local_holdings_count.'.$localHoldingsCount, 0) + 1;
 
                     if (is_null($biblio)) {
                         $this->error('No bibliographic records!');
                     } else {
                         $c = count($biblio->isbns);
-                        $info['isbn_count'][$c] = array_get($info, 'isbn_count.' . $c, 0) + 1;
+                        $info['isbn_count'][$c] = array_get($info, 'isbn_count.'.$c, 0) + 1;
                     }
                 }
             } catch (InvalidXMLException $e) {
-                $this->error('Invalid XML found! Skipping file: ' . $filename);
+                $this->error('Invalid XML found! Skipping file: '.$filename);
             }
         }
         $this->output->progressFinish();
 
-        $this->comment('Antall dokumenter: ' . $info['count']);
+        $this->comment('Antall dokumenter: '.$info['count']);
 
         $keys = array_keys($info['isbn_count']);
         sort($keys);
         $this->comment('Antall ISBN-numre per dokument:');
         foreach ($keys as $key) {
-            $this->comment('  - ' . $key . ': ' . $info['isbn_count'][$key]);
+            $this->comment('  - '.$key.': '.$info['isbn_count'][$key]);
         }
 
         $keys = array_keys($info['local_holdings_count']);
@@ -134,7 +134,7 @@ 
             if ($key == 10) {
                 $key = '>= 10';
             }
-            $this->comment('  - ' . $key . ': ' . $val);
+            $this->comment('  - '.$key.': '.$val);
         }
     }
 }

app/Console/Commands/Reindex.php

Spacing +4 added lines, -4 removed lines

@@ -40,7 +40,7 @@ 
         //$docIndex->dropVersion();
         $oldVersion = $docIndex->getCurrentVersion();
         $newVersion = $oldVersion + 1;
-        $this->comment(' Old version: ' . $oldVersion . ', new version: ' . $newVersion);
+        $this->comment(' Old version: '.$oldVersion.', new version: '.$newVersion);
 
         if ($docIndex->versionExists($newVersion)) {
             $this->comment(' New version already existed, probably from a crashed job. Removing.');
@@ -58,7 +58,7 @@ 
         $docCount = Document::count();
         $this->output->progressStart($docCount);
 
-        Document::with('subjects', 'genres', 'cover')->chunk(1000, function ($docs) use ($docIndex, $newVersion) {
+        Document::with('subjects', 'genres', 'cover')->chunk(1000, function($docs) use ($docIndex, $newVersion) {
             foreach ($docs as $doc) {
                 $docIndex->index($doc, $newVersion);
                 $this->output->progressAdvance();
@@ -73,7 +73,7 @@ 
         $docIndex->dropVersion($oldVersion);
 
         $dt = microtime(true) - $t0;
-        $this->info(' Completed in ' . round($dt) . ' seconds.');
-        \Log::info('[ReindexJob] Completed in ' . round($dt) . ' seconds.');
+        $this->info(' Completed in '.round($dt).' seconds.');
+        \Log::info('[ReindexJob] Completed in '.round($dt).' seconds.');
     }
 }

app/Console/Commands/ImportOntosaur.php

Spacing +4 added lines, -4 removed lines

@@ -85,13 +85,13 @@ 
             $field = 'genres';
             $entity = Genre::where('term', '=', $labels['nb'])->where('vocabulary', '=', 'noubomn')->first();
             if (is_null($entity)) {
-                $this->error('[ImportOntosaur] Entity not found: "' . $labels['nb'] . '"');
+                $this->error('[ImportOntosaur] Entity not found: "'.$labels['nb'].'"');
             }
         }
         if (!is_null($entity)) {
             $node['local_id'] = $entity->id;
             $node['documents'] = action('DocumentsController@index', [
-                'q' => $field . '.noubomn.id:' . $entity->id,
+                'q' => $field.'.noubomn.id:'.$entity->id,
             ]);
             // Can be used e.g. to determine bubble size in a visualization
             $node['document_count'] = $entity->documents()->count();
@@ -145,7 +145,7 @@ 
         }
 
         if (count($topNodes) != 1) {
-            throw new \Exception('Found ' . count($topNodes) . ' topnodes rather than 1: ' . implode(', ', $topNodes));
+            throw new \Exception('Found '.count($topNodes).' topnodes rather than 1: '.implode(', ', $topNodes));
         }
 
         return [$nodes, $links, $topNodes[0]];
@@ -167,6 +167,6 @@ 
         $saur->links = $links;
         $saur->topnode = $topnode;
         $saur->save();
-        $this->info('[ImportOntosaur] Completed. Have ' . count($nodes) . ' nodes, ' . count($links) . ' links.');
+        $this->info('[ImportOntosaur] Completed. Have '.count($nodes).' nodes, '.count($links).' links.');
     }
 }

app/Console/Commands/HarvestXisbn.php

Spacing +2 added lines, -2 removed lines

@@ -49,8 +49,8 @@
      */
     public function handleDocuments(XisbnClient $client, $docs)
     {
-        $this->info('Will check ' . count($docs) . ' documents');
-        Log::info('[HarvestXisbnJob] Starting job. ' . count($docs) . ' documents to be checked.');
+        $this->info('Will check '.count($docs).' documents');
+        Log::info('[HarvestXisbnJob] Starting job. '.count($docs).' documents to be checked.');
 
         $this->output->progressStart(count($docs));
         foreach ($docs as $doc) {