scriptotek / colligator-backend

app/Cover.php

Spacing +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
     public function invalidateCache()
     {
         if (!is_null($this->width) && !is_null($this->height)) {
-            \Log::debug('[Cover] Invalidating cache. Old version was ' . $this->width . ' x ' . $this->height);
+            \Log::debug('[Cover] Invalidating cache. Old version was '.$this->width.' x '.$this->height);
         }
         $this->width = null;
         $this->height = null;
@@ -133,7 +133,7 @@ 
             $orig = \CoverCache::putBlob($blob);
 
         } else {
-            \Log::debug('[Cover] Add to cache from url: ' . $this->url);
+            \Log::debug('[Cover] Add to cache from url: '.$this->url);
             $orig = \CoverCache::putUrl($this->url);
         }
 

app/CachedImage.php

Doc Comments +3 added lines

@@ -14,6 +14,9 @@
     public $cacheKey;
     protected $_metadata;
 
+    /**
+     * @param string|null $url
+     */
     public function __construct($url, $maxHeight = 0, AdapterInterface $filesystem = null, ImageManager $imageManager = null)
     {
         $this->sourceUrl = $url;

Spacing +6 added lines, -6 removed lines

@@ -22,7 +22,7 @@ 
         $this->imageManager = $imageManager ?: app('Intervention\Image\ImageManager');
         $maxAge = 3153600; // 30 days
         $this->fsConfig = new FlysystemConfig([
-            'CacheControl' => 'max-age=' . $maxAge . ', public',
+            'CacheControl' => 'max-age='.$maxAge.', public',
         ]);
     }
 
@@ -92,7 +92,7 @@ 
         if (is_null($data)) {
             $data = $this->download();
             if (!$data) {
-                throw new \ErrorException('[CoverCache] Failed to download ' . $this->sourceUrl);
+                throw new \ErrorException('[CoverCache] Failed to download '.$this->sourceUrl);
             }
         }
 
@@ -100,7 +100,7 @@ 
 
         $img = $this->imageManager->make($data);
         if ($this->maxHeight && $img->height() > $this->maxHeight) {
-            \Log::debug('[CachedImage] Resizing from ' . $img->height() . ' to ' . $this->maxHeight);
+            \Log::debug('[CachedImage] Resizing from '.$img->height().' to '.$this->maxHeight);
             $img->heighten($this->maxHeight);
             $data = strval($img->encode('jpg'));
         }
@@ -111,12 +111,12 @@ 
 
         $this->setMetadata($data, $img);
 
-        \Log::debug('[CachedImage] Storing image as ' . $img->width() . ' x ' . $img->height() . ', ' . strlen($data) . ' bytes');
+        \Log::debug('[CachedImage] Storing image as '.$img->width().' x '.$img->height().', '.strlen($data).' bytes');
         if (!$this->filesystem->write($this->cacheKey, $data, $this->fsConfig)) {
             throw new \ErrorException('[CoverCache] Failed to upload thumb to S3');
         }
 
-        \Log::debug('[CachedImage] Wrote cached version as ' . $this->cacheKey);
+        \Log::debug('[CachedImage] Wrote cached version as '.$this->cacheKey);
 
         return $this;
     }
@@ -134,7 +134,7 @@ 
     {
         $data = $this->filesystem->read($this->cacheKey);
         $blob = strval($data['contents']);
-        \Log::debug('[CachedImage] Read ' .$this->cacheKey . ': ' . strlen($blob) . ' bytes');
+        \Log::debug('[CachedImage] Read '.$this->cacheKey.': '.strlen($blob).' bytes');
 
         return \CoverCache::putBlob($blob, $maxHeight);
     }

app/Jobs/OaiPmhHarvest.php

Unused Use Statements -2 removed lines

@@ -7,8 +7,6 @@
 use Log;
 use Phpoaipmh\Client;
 use Phpoaipmh\Endpoint;
-use Scriptotek\OaiPmh\ListRecordsResponse;
-use Storage;
 
 class OaiPmhHarvest extends Job
 {

Spacing +2 added lines, -2 removed lines

@@ -107,7 +107,7 @@ 
      */
     public function handle()
     {
-        Log::info('[OaiPmhHarvest] Starting job. Requesting records from ' . ($this->start ?: '(no limit)') . ' until ' . ($this->until ?: '(no limit)') . '.');
+        Log::info('[OaiPmhHarvest] Starting job. Requesting records from '.($this->start ?: '(no limit)').' until '.($this->until ?: '(no limit)').'.');
 
         // For timing
         $this->startTime = $this->batchTime = microtime(true) - 1;
@@ -121,7 +121,7 @@ 
 
         $recordsHarvested = $this->fromNetwork();
 
-        Log::info('[OaiPmhHarvest] Harvest complete, got ' . $recordsHarvested . ' records.');
+        Log::info('[OaiPmhHarvest] Harvest complete, got '.$recordsHarvested.' records.');
     }
 
     /**

app/Console/Commands/OaiPmhHarvest.php

Spacing +6 added lines, -6 removed lines

@@ -47,7 +47,7 @@ 
         $this->comment('Available configurations:');
         $config = \Config::get('oaipmh.harvests', null);
         foreach (array_keys($config) as $key) {
-            $this->comment(' - ' . $key);
+            $this->comment(' - '.$key);
         }
     }
 
@@ -58,7 +58,7 @@ 
 
             return false;
         }
-        $harvestConfig = \Config::get('oaipmh.harvests.' . $this->argument('name'), null);
+        $harvestConfig = \Config::get('oaipmh.harvests.'.$this->argument('name'), null);
         if (is_null($harvestConfig)) {
             $this->error('Unknown configuration specified.');
             $this->listConfigurations();
@@ -100,13 +100,13 @@ 
         }
 
         $harvestName = $this->argument('name');
-        $harvestConfig = \Config::get('oaipmh.harvests.' . $harvestName, null);
+        $harvestConfig = \Config::get('oaipmh.harvests.'.$harvestName, null);
 
         $this->comment(sprintf('Dispatching new harvest job'));
 
-        $this->comment(' - Repo: ' . $harvestConfig['url']);
-        $this->comment(' - Schema: ' . $harvestConfig['schema']);
-        $this->comment(' - Set: ' . $harvestConfig['set']);
+        $this->comment(' - Repo: '.$harvestConfig['url']);
+        $this->comment(' - Schema: '.$harvestConfig['schema']);
+        $this->comment(' - Set: '.$harvestConfig['set']);
 
         foreach (['from', 'until', 'resume', 'daily'] as $key) {
             if (!is_null($this->option($key))) {