scriptotek / colligator-backend

app/Http/Controllers/DocumentsController.php

Doc Comments +6 added lines, -6 removed lines

@@ -13,7 +13,7 @@ 
     /**
      * Display a listing of the resource.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function index(SearchDocumentsRequest $request, DocumentsIndex $se)
     {
@@ -65,7 +65,7 @@ 
      * @param DocumentsIndex $se
      * @param int            $id
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function show(Request $request, DocumentsIndex $se, $id)
     {
@@ -138,7 +138,7 @@ 
     /**
      * Show cover.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function cover($document_id)
     {
@@ -152,7 +152,7 @@ 
     /**
      * Store cover.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function storeCover($document_id, Request $request, DocumentsIndex $se)
     {
@@ -204,7 +204,7 @@ 
     /**
      * Store description.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function storeDescription($document_id, Request $request, DocumentsIndex $se)
     {
@@ -235,7 +235,7 @@ 
     /**
      * Store "Cannot find cover"
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function cannotFindCover($document_id, Request $request, DocumentsIndex $se)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Colligator\Http\Controllers;
 
 use Carbon\Carbon;
-use Colligator\Cover;
 use Colligator\Document;
 use Colligator\Http\Requests\SearchDocumentsRequest;
 use Colligator\Search\DocumentsIndex;

Spacing +6 added lines, -6 removed lines

@@ -39,7 +39,7 @@ 
             'event' => 'elasticsearch_request',
             'event_time' => Carbon::now(),
             'msecs' => round(($t1 - $t0) * 1000),
-            'data' => 'results:' . count($response['hits']['hits']),
+            'data' => 'results:'.count($response['hits']['hits']),
         ]);
         $hits = count($response['hits']['hits']);
         if ($response['offset'] + $hits < $out['total']) {
@@ -204,11 +204,11 @@ 
                 $cover = $cover->toArray();
             }
         } catch (\ErrorException $e) {
-            \Log::error('Failed to cache cover, got error: ' . $e->getMessage());
+            \Log::error('Failed to cache cover, got error: '.$e->getMessage());
 
             return response()->json([
                 'result' => 'error',
-                'error'  => 'Failed to store the cover. Please check that the URL points to a valid image file. Details: ' . $e->getMessage(),
+                'error'  => 'Failed to store the cover. Please check that the URL points to a valid image file. Details: '.$e->getMessage(),
             ]);
         }
 
@@ -243,7 +243,7 @@ 
         ];
         $doc->save();
 
-        \Log::info('Stored new description for ' . $doc->id);
+        \Log::info('Stored new description for '.$doc->id);
 
         $se->indexById($doc->id);
 
@@ -268,11 +268,11 @@ 
             $doc->save();
 
         } catch (\ErrorException $e) {
-            \Log::error('Failed to store status, got error: ' . $e->getMessage());
+            \Log::error('Failed to store status, got error: '.$e->getMessage());
 
             return response()->json([
                 'result' => 'error',
-                'error'  => 'Failed to store status. Details: ' . $e->getMessage(),
+                'error'  => 'Failed to store status. Details: '.$e->getMessage(),
             ]);
         }
 

app/Console/Kernel.php

Indentation +3 added lines, -3 removed lines

@@ -24,15 +24,15 @@
     protected function schedule(Schedule $schedule)
     {
         $schedule->command('colligator:harvest-oaipmh samling42 --daily')
-                 ->dailyAt('02:00');
+                    ->dailyAt('02:00');
 
         // Bring subject heading usage counts up-to-date
         $schedule->command('colligator:reindex')
-                 ->weekly()->sundays()->at('04:00');
+                    ->weekly()->sundays()->at('04:00');
 
         // Check new documents for xisbn
         $schedule->command('colligator:harvest-xisbn')
-                 ->weekly()->saturdays()->at('04:00');
+                    ->weekly()->saturdays()->at('04:00');
     }
 
     /**

app/Providers/CoverCacheServiceProvider.php

Indentation +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 
 class CoverCacheServiceProvider extends ServiceProvider
 {
-	/**
+    /**
      * Indicates if loading of the provider is deferred.
      *
      * @var bool

Spacing +2 added lines, -2 removed lines

@@ -23,12 +23,12 @@
      */
     public function register()
     {
-        $this->app->singleton(CoverCache::class, function ($app) {
+        $this->app->singleton(CoverCache::class, function($app) {
             $fs = \Storage::disk('s3')->getAdapter();
             $im = $this->app->make(ImageManager::class);
             $conf = new FlysystemConfig([
                 // Default: 30 days
-                'CacheControl' => 'max-age=' . env('IMAGE_CACHE_TIME', 3153600) . ', public',
+                'CacheControl' => 'max-age='.env('IMAGE_CACHE_TIME', 3153600).', public',
             ]);
             return new CoverCache($fs, $im, $conf);
         });

app/CoverCache.php

Spacing +5 added lines, -5 removed lines

@@ -85,7 +85,7 @@ 
         if (is_null($data)) {
             $data = $this->download($sourceUrl);
             if (!$data) {
-                throw new \ErrorException('[CoverCache] Failed to download ' . $sourceUrl);
+                throw new \ErrorException('[CoverCache] Failed to download '.$sourceUrl);
             }
         }
 
@@ -93,7 +93,7 @@ 
 
         $img = $this->imageManager->make($data);
         if ($maxHeight && $img->height() > $maxHeight) {
-            \Log::debug('[CachedImage] Resizing from ' . $img->height() . ' to ' . $maxHeight);
+            \Log::debug('[CachedImage] Resizing from '.$img->height().' to '.$maxHeight);
             $img->heighten($maxHeight);
             $data = strval($img->encode('jpg'));
         }
@@ -103,12 +103,12 @@ 
         }
 
 
-        \Log::debug('[CachedImage] Storing image as ' . $img->width() . ' x ' . $img->height() . ', ' . strlen($data) . ' bytes');
+        \Log::debug('[CachedImage] Storing image as '.$img->width().' x '.$img->height().', '.strlen($data).' bytes');
         if (!$this->filesystem->write($cacheKey, $data, $this->fsConfig)) {
             throw new \ErrorException('[CoverCache] Failed to upload thumb to S3');
         }
 
-        \Log::debug('[CachedImage] Wrote cached version as ' . $cacheKey);
+        \Log::debug('[CachedImage] Wrote cached version as '.$cacheKey);
 
         return new CachedImage($this, $cacheKey);
     }
@@ -139,7 +139,7 @@ 
     {
         $data = $this->filesystem->read($cacheKey);
         $blob = strval($data['contents']);
-        \Log::debug('[CachedImage] Read ' .$cacheKey . ': ' . strlen($blob) . ' bytes');
+        \Log::debug('[CachedImage] Read '.$cacheKey.': '.strlen($blob).' bytes');
 
         return $this->putBlob($blob, $maxHeight);
     }