scriptotek / colligator-backend

app/Console/Commands/HarvestXisbn.php

Spacing +2 added lines, -2 removed lines

@@ -49,8 +49,8 @@
      */
     public function handleDocuments(XisbnClient $client, $docs)
     {
-        $this->info('Will check ' . count($docs) . ' documents');
-        Log::info('[HarvestXisbnJob] Starting job. ' . count($docs) . ' documents to be checked.');
+        $this->info('Will check '.count($docs).' documents');
+        Log::info('[HarvestXisbnJob] Starting job. '.count($docs).' documents to be checked.');
 
         $this->output->progressStart(count($docs));
         foreach ($docs as $doc) {

app/Http/Requests/SearchDocumentsRequest.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
                 $this->warnings[] = 'Offset cannot be negative.';
             } elseif ($input['offset'] > $maxPaginationDepth) {
                 $input['offset'] = $maxPaginationDepth;
-                $this->warnings[] = 'Pagination depth is limited to ' . $maxPaginationDepth . ' results.';
+                $this->warnings[] = 'Pagination depth is limited to '.$maxPaginationDepth.' results.';
             }
         }
 
@@ -36,7 +36,7 @@ 
                 $this->warnings[] = 'Limit cannot be negative.';
             } elseif ($input['limit'] > $maxResultsPerRequest) {
                 $input['limit'] = $maxResultsPerRequest;
-                $this->warnings[] = 'Limiting to max ' . $maxResultsPerRequest . ' results per request.';
+                $this->warnings[] = 'Limiting to max '.$maxResultsPerRequest.' results per request.';
             }
         }
 

app/GoogleBooksService.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Colligator;
 
 use Scriptotek\GoogleBooks\GoogleBooks;
-use Scriptotek\GoogleBooks\Exceptions\UsageRateExceeded;
 
 class GoogleBooksService implements EnrichmentService
 {

Spacing +4 added lines, -4 removed lines

@@ -19,7 +19,7 @@ 
     {
         foreach ($isbns as $isbn) {
             $volume = $this->books->volumes->byIsbn($isbn);
-            \Log::debug('[GoogleBooksService] - ' . $isbn . ': ' . (is_null($volume) ? 'not found' : 'found'));
+            \Log::debug('[GoogleBooksService] - '.$isbn.': '.(is_null($volume) ? 'not found' : 'found'));
             if (!is_null($volume)) {
                 return $volume;
             }
@@ -29,7 +29,7 @@ 
 
     public function enrich(Document $doc)
     {
-        \Log::debug('[GoogleBooksService] Checking document ' . $doc->id);
+        \Log::debug('[GoogleBooksService] Checking document '.$doc->id);
 
         $volume = $this->get($doc->bibliographic['isbns']);
 
@@ -47,11 +47,11 @@ 
         if ($volume) {
             $cover_url = $volume->getCover();
             if (!is_null($cover_url) && is_null($doc->cover)) {
-                \Log::debug('[GoogleBooksService] Setting new cover to document #' . $doc->id);
+                \Log::debug('[GoogleBooksService] Setting new cover to document #'.$doc->id);
                 try {
                     $doc->storeCover($cover_url);
                 } catch (\ErrorException $e) {
-                    \Log::error('[GoogleBooksService] Failed to store cover: ' . $cover_url . "\n" . $e->getMessage());
+                    \Log::error('[GoogleBooksService] Failed to store cover: '.$cover_url."\n".$e->getMessage());
                 }
             }
         }

app/Console/Commands/EnrichDocuments.php

Spacing +6 added lines, -6 removed lines

@@ -71,7 +71,7 @@ 
 
     public function handleDocuments(EnrichmentService $service, $docs)
     {
-        \Log::info('[EnrichDocuments] Starting job. ' . count($docs) . ' documents to be checked using the "' . $service::$serviceName . '" service.');
+        \Log::info('[EnrichDocuments] Starting job. '.count($docs).' documents to be checked using the "'.$service::$serviceName.'" service.');
 
         // $this->output->progressStart(count($docs));
         foreach ($docs as $doc) {
@@ -107,22 +107,22 @@ 
         $collectionId = intval($this->option('collection'));
 
         if (!isset($this->services[$serviceName])) {
-            $this->error('Service "' . $serviceName . '" is not defined. Available servies: "' . implode('", "', array_keys($this->services)) . '".');
+            $this->error('Service "'.$serviceName.'" is not defined. Available servies: "'.implode('", "', array_keys($this->services)).'".');
             return;
         }
 
         if ($verbose) {
-            \DB::listen(function ($query, $bindings) {
-                $this->comment('Query: ' . $query . '. Bindings: ' . implode(', ', $bindings));
+            \DB::listen(function($query, $bindings) {
+                $this->comment('Query: '.$query.'. Bindings: '.implode(', ', $bindings));
             });
         }
 
-        $collectionHelp = ($collectionId > 0) ? ' in collection ' . $collectionId : '';
+        $collectionHelp = ($collectionId > 0) ? ' in collection '.$collectionId : '';
 
         $docs = $this->getDocumentsToBeChecked($serviceName, $force, $collectionId);
 
         if (!count($docs)) {
-            $this->info('No new documents' . $collectionHelp . '. Exiting.');
+            $this->info('No new documents'.$collectionHelp.'. Exiting.');
             \Log::info('[EnrichDocuments] No new documents to be checked.');
             return;
         }

app/Providers/BroadcastServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
         /*
          * Authenticate the user's personal channel...
          */
-        Broadcast::channel('Colligator.User.{userId}', function ($user, $userId) {
+        Broadcast::channel('Colligator.User.{userId}', function($user, $userId) {
             return (int) $user->id === (int) $userId;
         });
     }

app/Providers/RouteServiceProvider.php

Spacing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
         Route::group([
             'middleware' => 'web',
             'namespace' => $this->namespace,
-        ], function () {
+        ], function() {
             require base_path('routes/web.php');
         });
     }
@@ -58,7 +58,7 @@ 
             'middleware' => 'api',
             'namespace' => $this->namespace,
             // 'prefix' => 'api',
-        ], function () {
+        ], function() {
             require base_path('routes/api.php');
         });
     }

app/Marc21Importer.php

Spacing +5 added lines, -5 removed lines

@@ -57,8 +57,8 @@ 
             $rec = MarcRecord::fromString($q);
 
             $itemMap = [
-                'x' => 'location',  // OBS: 1030310
-                'y' => 'shelvinglocation',  // OBS: k00475
+                'x' => 'location', // OBS: 1030310
+                'y' => 'shelvinglocation', // OBS: k00475
                 'b' => 'barcode',
                 'z' => 'callcode',
                 'a' => 'id',
@@ -190,7 +190,7 @@ 
             try {
                 $doc->storeCover($biblio['cover_image']);
             } catch (\ErrorException $e) {
-                \Log::error('Failed to store cover: ' . $biblio['cover_image']);
+                \Log::error('Failed to store cover: '.$biblio['cover_image']);
             }
         }
 
@@ -207,14 +207,14 @@ 
         try {
             list($biblio, $holdings) = $this->parseRecord($record);
         } catch (ParserException $e) {
-            $this->error('Failed to parse MARC record. Error "' . $e->getMessage() . '" in: ' . $e->getFile() . ':' . $e->getLine() . "\nStack trace:\n" . $e->getTraceAsString());
+            $this->error('Failed to parse MARC record. Error "'.$e->getMessage().'" in: '.$e->getFile().':'.$e->getLine()."\nStack trace:\n".$e->getTraceAsString());
 
             return null;
         }
 
         $doc = $this->importParsedRecord($biblio, $holdings);
 
-        \Log::debug('[Marc21Importer] Imported ' . $doc->bibsys_id . ' as ' . $doc->id);
+        \Log::debug('[Marc21Importer] Imported '.$doc->bibsys_id.' as '.$doc->id);
 
         if (!is_null($doc)) {
             Event::fire(new Marc21RecordImported($doc->id));

app/Cover.php

Spacing +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
     public function invalidateCache()
     {
         if (!is_null($this->width) && !is_null($this->height)) {
-            \Log::debug('[Cover] Invalidating cache. Old version was ' . $this->width . ' x ' . $this->height);
+            \Log::debug('[Cover] Invalidating cache. Old version was '.$this->width.' x '.$this->height);
         }
         $this->width = null;
         $this->height = null;
@@ -133,7 +133,7 @@ 
             $orig = \CoverCache::putBlob($blob);
 
         } else {
-            \Log::debug('[Cover] Add to cache from url: ' . $this->url);
+            \Log::debug('[Cover] Add to cache from url: '.$this->url);
             $orig = \CoverCache::putUrl($this->url);
         }
 

app/Http/Controllers/DocumentsController.php

Doc Comments +6 added lines, -6 removed lines

@@ -13,7 +13,7 @@ 
     /**
      * Display a listing of the resource.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function index(SearchDocumentsRequest $request, DocumentsIndex $se)
     {
@@ -65,7 +65,7 @@ 
      * @param DocumentsIndex $se
      * @param int            $id
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function show(Request $request, DocumentsIndex $se, $id)
     {
@@ -138,7 +138,7 @@ 
     /**
      * Show cover.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function cover($document_id)
     {
@@ -152,7 +152,7 @@ 
     /**
      * Store cover.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function storeCover($document_id, Request $request, DocumentsIndex $se)
     {
@@ -204,7 +204,7 @@ 
     /**
      * Store description.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function storeDescription($document_id, Request $request, DocumentsIndex $se)
     {
@@ -235,7 +235,7 @@ 
     /**
      * Store "Cannot find cover"
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function cannotFindCover($document_id, Request $request, DocumentsIndex $se)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Colligator\Http\Controllers;
 
 use Carbon\Carbon;
-use Colligator\Cover;
 use Colligator\Document;
 use Colligator\Http\Requests\SearchDocumentsRequest;
 use Colligator\Search\DocumentsIndex;

Spacing +6 added lines, -6 removed lines

@@ -39,7 +39,7 @@ 
             'event' => 'elasticsearch_request',
             'event_time' => Carbon::now(),
             'msecs' => round(($t1 - $t0) * 1000),
-            'data' => 'results:' . count($response['hits']['hits']),
+            'data' => 'results:'.count($response['hits']['hits']),
         ]);
         $hits = count($response['hits']['hits']);
         if ($response['offset'] + $hits < $out['total']) {
@@ -204,11 +204,11 @@ 
                 $cover = $cover->toArray();
             }
         } catch (\ErrorException $e) {
-            \Log::error('Failed to cache cover, got error: ' . $e->getMessage());
+            \Log::error('Failed to cache cover, got error: '.$e->getMessage());
 
             return response()->json([
                 'result' => 'error',
-                'error'  => 'Failed to store the cover. Please check that the URL points to a valid image file. Details: ' . $e->getMessage(),
+                'error'  => 'Failed to store the cover. Please check that the URL points to a valid image file. Details: '.$e->getMessage(),
             ]);
         }
 
@@ -243,7 +243,7 @@ 
         ];
         $doc->save();
 
-        \Log::info('Stored new description for ' . $doc->id);
+        \Log::info('Stored new description for '.$doc->id);
 
         $se->indexById($doc->id);
 
@@ -268,11 +268,11 @@ 
             $doc->save();
 
         } catch (\ErrorException $e) {
-            \Log::error('Failed to store status, got error: ' . $e->getMessage());
+            \Log::error('Failed to store status, got error: '.$e->getMessage());
 
             return response()->json([
                 'result' => 'error',
-                'error'  => 'Failed to store status. Details: ' . $e->getMessage(),
+                'error'  => 'Failed to store status. Details: '.$e->getMessage(),
             ]);
         }