scriptotek / colligator-backend

app/Console/Commands/HarvestXisbn.php

Spacing +2 added lines, -2 removed lines

@@ -49,8 +49,8 @@
      */
     public function handleDocuments(XisbnClient $client, $docs)
     {
-        $this->info('Will check ' . count($docs) . ' documents');
-        Log::info('[HarvestXisbnJob] Starting job. ' . count($docs) . ' documents to be checked.');
+        $this->info('Will check '.count($docs).' documents');
+        Log::info('[HarvestXisbnJob] Starting job. '.count($docs).' documents to be checked.');
 
         $this->output->progressStart(count($docs));
         foreach ($docs as $doc) {

app/Marc21Importer.php

Spacing +5 added lines, -5 removed lines

@@ -57,8 +57,8 @@ 
             $rec = MarcRecord::fromString($q);
 
             $itemMap = [
-                'x' => 'location',  // OBS: 1030310
-                'y' => 'shelvinglocation',  // OBS: k00475
+                'x' => 'location', // OBS: 1030310
+                'y' => 'shelvinglocation', // OBS: k00475
                 'c' => 'barcode',
                 'z' => 'callcode',
                 'a' => 'id',
@@ -193,7 +193,7 @@ 
             try {
                 $doc->storeCover($biblio['cover_image']);
             } catch (\ErrorException $e) {
-                \Log::error('Failed to store cover: ' . $biblio['cover_image']);
+                \Log::error('Failed to store cover: '.$biblio['cover_image']);
             }
         }
 
@@ -208,14 +208,14 @@ 
         try {
             list($biblio, $holdings) = $this->parseRecord($record);
         } catch (ParserException $e) {
-            $this->error('Failed to parse MARC record. Error "' . $e->getMessage() . '" in: ' . $e->getFile() . ':' . $e->getLine() . "\nStack trace:\n" . $e->getTraceAsString());
+            $this->error('Failed to parse MARC record. Error "'.$e->getMessage().'" in: '.$e->getFile().':'.$e->getLine()."\nStack trace:\n".$e->getTraceAsString());
 
             return;
         }
 
         $doc = $this->importParsedRecord($biblio, $holdings);
 
-        \Log::debug('[Marc21Importer] Imported ' . $doc->bibsys_id . ' as ' . $doc->id);
+        \Log::debug('[Marc21Importer] Imported '.$doc->bibsys_id.' as '.$doc->id);
 
         if (!is_null($doc)) {
             Event::fire(new Marc21RecordImported($doc->id));

app/Jobs/OaiPmhHarvest.php

Spacing +10 added lines, -10 removed lines

@@ -102,7 +102,7 @@ 
      */
     public function fromDump()
     {
-        $files = Storage::disk('local')->files('harvests/' . $this->name);
+        $files = Storage::disk('local')->files('harvests/'.$this->name);
         $recordsHarvested = 0;
         foreach ($files as $filename) {
             if (!preg_match('/.xml$/', $filename)) {
@@ -124,11 +124,11 @@ 
 
     public function fromNetwork()
     {
-        $dest_path = 'harvests/' . $this->name . '/';
+        $dest_path = 'harvests/'.$this->name.'/';
 
         Storage::disk('local')->deleteDir($dest_path);
 
-        $latest = $dest_path . 'latest.xml';
+        $latest = $dest_path.'latest.xml';
 
         $client = new OaiPmhClient($this->url, [
             'schema'              => $this->schema,
@@ -137,12 +137,12 @@ 
             'sleep-time-on-error' => $this->sleepTimeOnError,
         ]);
 
-        $client->on('request.error', function ($msg) {
+        $client->on('request.error', function($msg) {
             $this->error($msg);
         });
 
         // Store each response to disk just in case
-        $client->on('request.complete', function ($verb, $args, $body) use ($latest) {
+        $client->on('request.complete', function($verb, $args, $body) use ($latest) {
             Storage::disk('local')->put($latest, $body);
         });
 
@@ -166,9 +166,9 @@ 
             if ($this->resume != $records->getResumptionToken()) {
                 $this->resume = $records->getResumptionToken();
                 if (is_null($this->resume)) {
-                    Storage::disk('local')->delete($dest_path . '/resumption_token');
+                    Storage::disk('local')->delete($dest_path.'/resumption_token');
                 } else {
-                    Storage::disk('local')->put($dest_path . '/resumption_token', $this->resume);
+                    Storage::disk('local')->put($dest_path.'/resumption_token', $this->resume);
                 }
             }
 
@@ -201,7 +201,7 @@ 
                 } catch (BadRequestError $e) {
                     $this->error($e->getMessage());
                     $this->error($e->getCode());
-                    $this->error('Bad request. Attempt ' . $attempt . ' of 100. Sleeping 10 secs.');
+                    $this->error('Bad request. Attempt '.$attempt.' of 100. Sleeping 10 secs.');
                     if ($attempt > 100) {
                         throw $e;
                     }
@@ -225,7 +225,7 @@ 
      */
     public function handle(DocumentsIndex $docIndex, Marc21Importer $importer)
     {
-        Log::info('[OaiPmhHarvestJob] Starting job. Requesting records from ' . ($this->start ?: '(no limit)') . ' until ' . ($this->until ?: '(no limit)') . '.');
+        Log::info('[OaiPmhHarvestJob] Starting job. Requesting records from '.($this->start ?: '(no limit)').' until '.($this->until ?: '(no limit)').'.');
         $this->docIndex = $docIndex;
         $this->importer = $importer;
 
@@ -245,7 +245,7 @@ 
         }
 
         // $this->postProcess($this->importedDocuments);
-        Log::info('[OaiPmhHarvestJob] Complete, got ' . $recordsHarvested . ' records.');
+        Log::info('[OaiPmhHarvestJob] Complete, got '.$recordsHarvested.' records.');
 
         Event::fire(new OaiPmhHarvestComplete($recordsHarvested));
     }

app/Http/Requests/SearchDocumentsRequest.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
                 $this->warnings[] = 'Offset cannot be negative.';
             } elseif ($input['offset'] > $maxPaginationDepth) {
                 $input['offset'] = $maxPaginationDepth;
-                $this->warnings[] = 'Pagination depth is limited to ' . $maxPaginationDepth . ' results.';
+                $this->warnings[] = 'Pagination depth is limited to '.$maxPaginationDepth.' results.';
             }
         }
 
@@ -36,7 +36,7 @@ 
                 $this->warnings[] = 'Limit cannot be negative.';
             } elseif ($input['limit'] > $maxResultsPerRequest) {
                 $input['limit'] = $maxResultsPerRequest;
-                $this->warnings[] = 'Limiting to max ' . $maxResultsPerRequest . ' results per request.';
+                $this->warnings[] = 'Limiting to max '.$maxResultsPerRequest.' results per request.';
             }
         }