ImportRecord::imported() - Code Metrics - scriptotek/colligator-backend - Measure and Improve Code Quality continuously with Scrutinizer

ImportRecord::imported() A
last analyzed 2018-08-07 10:50 UTC

↳ Parent: ImportRecord

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace Colligator\Jobs;

use Colligator\Collection;
use Colligator\Document;
use Colligator\Marc21Importer;
use Colligator\Search\DocumentsIndex;
use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;

class ImportRecord extends Job
{
    protected $record;
    protected $collection;

    /**
     * ImportRecord constructor.
     * @param Collection $collection
     * @param string $record
     */
    public function __construct(Collection $collection, string $record)
    {
        $this->collection = $collection;
        $this->record = $record;
    }

    /**
     * @param Marc21Importer $importer
     */
    public function handle(DocumentsIndex $docIndex, Marc21Importer $importer)
    {
        $record = new QuiteSimpleXMLElement($this->record);
        $docId = $importer->import($record);
        $this->imported($docIndex, $docId);
    }

    /**
     * @param DocumentsIndex $docIndex
     * @param int $docId
     */
    public function imported($docIndex, $docId)
    {
        $doc = Document::with('subjects', 'genres', 'cover')->find($docId);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        if (!$this->collection->documents->contains($doc->id)) {
            $this->collection->documents()->attach($doc->id);
        }

        // Add/update ElasticSearch
        $docIndex->index($doc);
    }
}


1			<?php
2
3			namespace Colligator\Jobs;
4
5			use Colligator\Collection;
6			use Colligator\Document;
7			use Colligator\Marc21Importer;
8			use Colligator\Search\DocumentsIndex;
9			use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;
10
11			class ImportRecord extends Job
12			{
13			protected $record;
14			protected $collection;
15
16			/**
17			* ImportRecord constructor.
18			* @param Collection $collection
19			* @param string $record
20			*/
21			public function __construct(Collection $collection, string $record)
22			{
23			$this->collection = $collection;
24			$this->record = $record;
25			}
26
27			/**
28			* @param Marc21Importer $importer
29			*/
30			public function handle(DocumentsIndex $docIndex, Marc21Importer $importer)
31			{
32			$record = new QuiteSimpleXMLElement($this->record);
33			$docId = $importer->import($record);
34			$this->imported($docIndex, $docId);
35			}
36
37			/**
38			* @param DocumentsIndex $docIndex
39			* @param int $docId
40			*/
41			public function imported($docIndex, $docId)
42			{
43			$doc = Document::with('subjects', 'genres', 'cover')->find($docId);
			0 ignored issues – show Bug introduced 2016-09-22 22:13 UTC by Report Bug Copy Issue Report The method `find` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
44
45			if (!$this->collection->documents->contains($doc->id)) {
46			$this->collection->documents()->attach($doc->id);
47			}
48
49			// Add/update ElasticSearch
50			$docIndex->index($doc);
51			}
52			}
53

scriptotek / colligator-backend

ImportRecord::imported() A last analyzed 2018-08-07 10:50 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ImportRecord::imported() A
last analyzed 2018-08-07 10:50 UTC