SyncUsers::transferLoans() - Code Metrics - Inspection of "Add rfid control support" - scriptotek/bibrex - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( af710d...2c0b17 )

by Dan Michael O.
created 2018-08-01 12:04 UTC
SyncUsers::transferLoans() B

↳ Parent: SyncUsers
Complexity

Conditions	10
Paths	11
Size

Total Lines	72
Code Lines	41
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	10
eloc	41
nc	11
nop	1
dl	0
loc	72
rs	7.6666
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

namespace App\Console\Commands;

use App\User;
use Illuminate\Console\Command;
filter:
    dependency_paths: ["lib/*"]

use PDOException;
use Scriptotek\Alma\Client as AlmaClient;
filter:
    dependency_paths: ["lib/*"]
use Scriptotek\Alma\Exception\RequestFailed;
filter:
    dependency_paths: ["lib/*"]

class SyncUsers extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'bibrex:sync-users';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Fetch changes to Alma users and try to link unlinked users.';

    /** @var AlmaClient */
    protected $alma;

    /**
     * Create a new command instance.
     *
     * @param AlmaClient $alma
     */
    public function __construct(AlmaClient $alma)
    {
        parent::__construct();
        $this->alma = $alma;
    }

    /**
     * Update a single user
     *
     * @param User $user
     */
    protected function processUser(User $user)
    {
        echo " - $user->name: ";

        if ($user->in_alma) {
            if ($user->updateFromAlma($this->alma)) {
                if ($user->isDirty()) {
                    \Log::info(sprintf(
                        'Oppdaterte brukeren <a href="%s">%s</a> fra Alma.',
                        action('UsersController@getShow', $user->id),
                        action('UsersController@getShow', $user->id),
                        $user->name
                    ));

                    $this->info('oppdatert');
                } else {
                    $this->line('ingen endringer');
                }
            } else {
                \Log::warning(sprintf(
                    'Brukeren <a href="%s">%s</a> ble ikke lenger funnet i Alma!',
                    action('UsersController@getShow', $user->id),
                    $user->name
                ));

                $this->warn('ikke i Alma lenger');
            }
        } else {
            if ($user->updateFromAlma($this->alma)) {
                \Log::info(sprintf(
                    'Lenket brukeren <a href="%s">%s</a> til en Alma-bruker.',
                    action('UsersController@getShow', $user->id),
                    $user->name
                ));

                $this->info('lenket til Alma-bruker');
                $this->transferLoans($user);
            } else {
                $this->line('ikke i Alma');
            }
        }
        try {
            $user->save();
        } catch (PDOException $e) {
            $this->error('Konflikt!');
            \Log::warning(sprintf(
                'Brukeren <a href="%s">%s</a> kunne ikke lagres på grunn av en konflikt - to brukere har ' .
                'samme strekkode eller feide-id. Sjekk i brukerlista om det er to brukere som kan slås sammen.',
                action('UsersController@getShow', $user->id),
                $user->name
            ));
            return;
        }

        if ($user->in_alma) {
            // Check if user have loans of thing_id 1 and transfer them if so.
            // In case the user was manually synced during the day.
            $tempLoans = $user->loans()->whereHas('item', function ($query) {
                $query->where('thing_id', 1);
            })->count();

            if ($tempLoans) {
                $this->transferLoans($user);
            }
        }
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        foreach (User::get() as $user) {
            $this->processUser($user);
        }
    }

    protected function transferLoans(User $localUser)
    {
        $almaUser = $this->alma->users[$localUser->alma_primary_id];

        if (is_null($almaUser)) {
            \Log::error("Kunne ikke overføre lån fordi Alma-brukeren ikke ble funnet. Meget uventet.");
            return;
        }

        $n = 0;

        foreach ($localUser->loans as $loan) {
            if ($loan->item->thing_id == 1) {
                // Loan should be transferred from the temporary card to the user

                $barcode = $loan->item->barcode;
                $library = $loan->library;

                $errBecause = "Kunne ikke overføre lån av $barcode i Alma fordi";

                if (is_null($library->temporary_barcode)) {
                    \Log::error("$errBecause biblioteket ikke lenger har et midlertidig lånekort.");
                    continue;
                }

                $tempUser = $this->alma->users[$library->temporary_barcode];

                if (is_null($tempUser)) {
                    \Log::error("$errBecause brukeren '{$library->temporary_barcode}' ikke ble funnet i Alma.");
                    continue;
                }

                $almaItem = $this->alma->items->fromBarcode($barcode);
                $almaLoan = $almaItem->loan;

                if (is_null($almaLoan)) {
                    \Log::warning("$errBecause dokumentet i mellomtiden har blitt returnert i Alma.");
                    continue;
                }

                if ($almaLoan->user_id != $library->temporary_barcode) {
                    \Log::warning("$errBecause dokumentet ikke lenger er utlånt til {$library->temporary_barcode}.");
                    continue;
                }

                if (count($almaItem->requests)) {
                    \Log::warning("$errBecause dokumentet har reserveringer.");
                    continue;
                }

                // Cross fingers
                try {
                    $almaLoan->scanIn($library);
                    $almaItem->checkOut($almaUser, $library);
                } catch (RequestFailed $e) {
                    \Log::warning($errBecause . ' ' . $e->getMessage());
                    continue;
                }

                \Log::info(sprintf(
                    'Overførte lån av <a href="%s">%s</a> til Alma-brukeren.',
                    action('ItemsController@show', $loan->item->id),
                    action('ItemsController@show', $loan->item->id),
                    $barcode
                ));

                // Checkin local loan and delete temporary item
                $loan->checkIn();

                $n++;
            }
        }
        $this->info(" > Overførte $n lån");
    }
}

scriptotek / bibrex

Push — master ( af710d...2c0b17 )

SyncUsers::transferLoans() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
