scriptotek /
bibrex
| Total Complexity | 42 |
| Total Lines | 408 |
| Duplicated Lines | 0 % |
| Changes | 5 | ||
| Bugs | 0 | Features | 0 |
Complex classes like UsersController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use UsersController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 16 | class UsersController extends Controller |
||
| 17 | { |
||
| 18 | |||
| 19 | private $messages = [ |
||
| 20 | 'lastname.required' => 'Etternavn må fylles inn.', |
||
| 21 | 'firstname.required' => 'Fornavn må fylles inn.', |
||
| 22 | 'email.required_without' => 'Enten e-post eller telefonnummer må fylles inn.', |
||
| 23 | 'lang.required' => 'Språk må fylles inn.' |
||
| 24 | ]; |
||
| 25 | |||
| 26 | /** |
||
| 27 | * Display a listing of the resource. |
||
| 28 | * |
||
| 29 | * @param Request $request |
||
| 30 | * @return Response |
||
| 31 | */ |
||
| 32 | public function getIndex(Request $request) |
||
| 33 | { |
||
| 34 | $users = User::with('loans', 'identifiers') |
||
| 35 | ->where('lastname', '!=', '(anonymisert)') |
||
| 36 | ->orderBy('lastname') |
||
| 37 | ->get() |
||
| 38 | ->map(function ($user) { |
||
| 39 | return [ |
||
| 40 | 'id' => $user->id, |
||
| 41 | 'primaryId' => $user->alma_primary_id, |
||
| 42 | 'group' => $user->alma_user_group, |
||
| 43 | 'name' => $user->lastname . ', ' . $user->firstname, |
||
| 44 | 'identifiers' => $user->getAllIdentifierValues(), |
||
| 45 | 'in_alma' => $user->in_alma, |
||
| 46 | 'created_at' => $user->created_at->toDateTimestring(), |
||
| 47 | 'note' => $user->note, |
||
| 48 | 'blocks' => $user->blocks, |
||
| 49 | 'fees' => $user->fees, |
||
| 50 | ]; |
||
| 51 | }); |
||
| 52 | |||
| 53 | return response()->view('users.index', [ |
||
| 54 | 'users' => $users, |
||
| 55 | ]); |
||
| 56 | } |
||
| 57 | |||
| 58 | /** |
||
| 59 | * Display a listing of the resource as json. |
||
| 60 | * |
||
| 61 | * @param Request $request |
||
| 62 | * @return Response |
||
| 63 | */ |
||
| 64 | public function json(Request $request) |
||
| 65 | { |
||
| 66 | $users = []; |
||
| 67 | foreach (User::with('identifiers')->get() as $user) { |
||
| 68 | $users[] = [ |
||
| 69 | 'id' => $user->alma_primary_id ?? $user->id, |
||
| 70 | // 'primaryId' => $user->alma_primary_id, |
||
| 71 | 'group' => $user->alma_user_group, |
||
| 72 | 'name' => $user->lastname . ', ' . $user->firstname, |
||
| 73 | 'identifiers' => $user->identifiers, |
||
| 74 | 'type' => 'local', |
||
| 75 | ]; |
||
| 76 | } |
||
| 77 | |||
| 78 | return response()->json($users); |
||
| 79 | } |
||
| 80 | |||
| 81 | /** |
||
| 82 | * Display a listing of the resource. |
||
| 83 | * |
||
| 84 | * @param AlmaClient $alma |
||
| 85 | * @param Request $request |
||
| 86 | * @return Response |
||
| 87 | */ |
||
| 88 | public function searchAlma(AlmaClient $alma, Request $request) |
||
| 89 | { |
||
| 90 | if (is_null($alma->key)) { |
||
| 91 | \Log::warning('Cannot search Alma users since no Alma API key is configured.'); |
||
| 92 | return response()->json([]); |
||
| 93 | } |
||
| 94 | $query = 'ALL~' . $request->input('query'); |
||
| 95 | $users = collect($alma->users->search($query, ['limit' => 5]))->map(function ($result) { |
||
| 96 | return [ |
||
| 97 | 'id' => $result->primary_id, |
||
| 98 | 'name' => "{$result->last_name}, {$result->first_name}", |
||
| 99 | ]; |
||
| 100 | }); |
||
| 101 | |||
| 102 | return response()->json($users); |
||
| 103 | } |
||
| 104 | |||
| 105 | /** |
||
| 106 | * Display the specified resource. |
||
| 107 | * |
||
| 108 | * @param User $user |
||
| 109 | * @return Response |
||
| 110 | */ |
||
| 111 | public function getShow(User $user) |
||
| 112 | { |
||
| 113 | return response()->view('users.show', [ |
||
| 114 | 'user' => $user, |
||
| 115 | ]); |
||
| 116 | } |
||
| 117 | |||
| 118 | /** |
||
| 119 | * Display form for connecting local user to external user. |
||
| 120 | * |
||
| 121 | * @param User $user |
||
| 122 | * @return Response |
||
| 123 | */ |
||
| 124 | public function connectForm(User $user) |
||
| 125 | { |
||
| 126 | $ident = $user->identifiers()->first(); |
||
| 127 | return response()->view('users.connect', [ |
||
| 128 | 'user' => $user, |
||
| 129 | 'user_identifier' => is_null($ident) ? null : $ident->value, |
||
| 130 | ]); |
||
| 131 | } |
||
| 132 | |||
| 133 | /** |
||
| 134 | * Connect local user to external user. |
||
| 135 | * |
||
| 136 | * @param AlmaUsers $almaUsers |
||
| 137 | * @param Request $request |
||
| 138 | * @param User $user |
||
| 139 | * @return Response |
||
| 140 | */ |
||
| 141 | public function connect(AlmaUsers $almaUsers, Request $request, User $user) |
||
| 169 | } |
||
| 170 | |||
| 171 | /** |
||
| 172 | * Import user data from Alma. |
||
| 173 | * |
||
| 174 | * @param AlmaUsers $almaUsers |
||
| 175 | * @param User $user |
||
| 176 | * @return Response |
||
| 177 | */ |
||
| 178 | public function sync(AlmaUsers $almaUsers, User $user) |
||
| 179 | { |
||
| 180 | if (!$user->alma_primary_id && !$user->identifiers->count()) { |
||
| 181 | return back()->with('error', 'Du må registrere minst én identifikator for brukeren før du kan importere.'); |
||
| 182 | } |
||
| 183 | |||
| 184 | if (!$almaUsers->updateLocalUserFromAlmaUser($user)) { |
||
| 185 | $user->save(); |
||
| 186 | |||
| 187 | return back()->with('error', 'Fant ikke brukeren i Alma 😭'); |
||
| 188 | } |
||
| 189 | $user->save(); |
||
| 190 | |||
| 191 | return back()->with('status', 'Brukeropplysninger ble oppdatert fra Alma.'); |
||
| 192 | } |
||
| 193 | |||
| 194 | /** |
||
| 195 | * Show the form for editing the specified resource. |
||
| 196 | * |
||
| 197 | * @param User $user |
||
| 198 | * @param Request $request |
||
| 199 | * @return Response |
||
| 200 | */ |
||
| 201 | public function getEdit(User $user, Request $request) |
||
| 202 | { |
||
| 203 | if (!$user->id) { |
||
| 204 | $identifiers = []; |
||
| 205 | if ($request->barcode) { |
||
| 206 | $identifiers[] = UserIdentifier::make([ |
||
| 207 | 'value' => $request->barcode, |
||
| 208 | 'type' => 'barcode', |
||
| 209 | ]); |
||
| 210 | } |
||
| 211 | if ($request->university_id) { |
||
| 212 | $identifiers[] = UserIdentifier::make([ |
||
| 213 | 'value' => $request->university_id, |
||
| 214 | 'type' => 'university_id', |
||
| 215 | ]); |
||
| 216 | } |
||
| 217 | $user->identifiers = $identifiers; |
||
| 218 | $user->lastname = $request->lastname; |
||
| 219 | $user->firstname = $request->firstname; |
||
| 220 | $user->phone = $request->phone; |
||
| 221 | $user->email = $request->email; |
||
| 222 | } |
||
| 223 | |||
| 224 | return response()->view('users.edit', array( |
||
| 225 | 'user' => $user |
||
| 226 | )); |
||
| 227 | } |
||
| 228 | |||
| 229 | /** |
||
| 230 | * Update the specified resource in storage. |
||
| 231 | * |
||
| 232 | * @param User $user |
||
| 233 | * @param Request $request |
||
| 234 | * @return Response |
||
| 235 | * @throws \Illuminate\Validation\ValidationException |
||
| 236 | */ |
||
| 237 | public function upsert(User $user, Request $request) |
||
| 306 | } |
||
| 307 | |||
| 308 | /** |
||
| 309 | * Display form to merge two users. |
||
| 310 | * |
||
| 311 | * @param User $user1 |
||
| 312 | * @param User $user2 |
||
| 313 | * @return Response |
||
| 314 | */ |
||
| 315 | public function getMerge(User $user1, User $user2) |
||
| 316 | { |
||
| 317 | $merged = $user1->getMergeData($user2); |
||
| 318 | |||
| 319 | return response()->view('users.merge', array( |
||
| 320 | 'user1' => $user1, |
||
| 321 | 'user2' => $user2, |
||
| 322 | 'merged' => $merged |
||
| 323 | )); |
||
| 324 | } |
||
| 325 | |||
| 326 | /** |
||
| 327 | * Merge $user2 into $user1 |
||
| 328 | * |
||
| 329 | * @param Request $request |
||
| 330 | * @param User $user1 |
||
| 331 | * @param User $user2 |
||
| 332 | * @return Response |
||
| 333 | */ |
||
| 334 | public function postMerge(Request $request, User $user1, User $user2) |
||
| 366 | } |
||
| 367 | |||
| 368 | /** |
||
| 369 | * Show the form for creating the specified resource. |
||
| 370 | * |
||
| 371 | * @param Request $request |
||
| 372 | * @return Response |
||
| 373 | */ |
||
| 374 | public function createForm(Request $request) |
||
| 375 | { |
||
| 376 | $user = User::make(); |
||
| 377 | |||
| 378 | return response()->view('users.create', [ |
||
| 379 | 'user' => $user, |
||
| 380 | ]); |
||
| 381 | } |
||
| 382 | |||
| 383 | /** |
||
| 384 | * Show the form for deleting the specified resource. |
||
| 385 | * |
||
| 386 | * @param User $user |
||
| 387 | * @param Request $request |
||
| 388 | * @return Response |
||
| 389 | */ |
||
| 390 | public function deleteForm(User $user, Request $request) |
||
| 399 | ]); |
||
| 400 | } |
||
| 401 | |||
| 402 | /** |
||
| 403 | * Delte the specified resource from storage. |
||
| 404 | * |
||
| 405 | * @param User $user |
||
| 406 | * @param Request $request |
||
| 407 | * @return Response |
||
| 408 | */ |
||
| 409 | public function delete(User $user, Request $request) |
||
| 410 | { |
||
| 411 | if ($user->loans()->count()) { |
||
| 412 | return redirect()->action('UsersController@getShow', $user->id) |
||
| 413 | ->with('error', 'Kan ikke slette en bruker med aktive lån.'); |
||
| 414 | } |
||
| 415 | |||
| 416 | $user_id = $user->id; |
||
| 417 | $name = $user->name; |
||
| 418 | |||
| 419 | $user->delete(); |
||
| 420 | \Log::info(sprintf('Slettet brukeren %s (ID %d)', $name, $user_id)); |
||
| 421 | |||
| 422 | return redirect()->action('UsersController@getIndex') |
||
| 423 | ->with('status', "Brukeren $name ble slettet (men slapp av, du har ikke drept noen)."); |
||
| 424 | } |
||
| 426 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths