RouteServiceProvider::mapApiRoutes() - Code Metrics - scriptotek/bibrex - Measure and Improve Code Quality continuously with Scrutinizer

RouteServiceProvider::mapApiRoutes() A
last analyzed 2020-08-20 14:30 UTC

↳ Parent: RouteServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	4
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	6
rs	10

<?php

namespace App\Providers;

use App\Item;
use App\Loan;
use App\Notifications\ExtendedDatabaseNotification;
use App\Thing;
use App\User;
use Illuminate\Support\Facades\Route;
use Illuminate\Foundation\Support\Providers\RouteServiceProvider as ServiceProvider;

class RouteServiceProvider extends ServiceProvider
{
    /**
     * This namespace is applied to your controller routes.
     *
     * In addition, it is set as the URL generator's root namespace.
     *
     * @var string
     */
    protected $namespace = 'App\Http\Controllers';

    /**
     * Define your route model bindings, pattern filters, etc.
     *
     * @return void
     */
    public function boot()
    {
        Route::pattern('user', '([0-9]+|_new)');
        Route::pattern('item', '([0-9]+|_new)');
        Route::pattern('thing', '([0-9]+|_new)');

        Route::pattern('library', '[0-9]+');
        Route::pattern('user1', '[0-9]+');
        Route::pattern('user2', '[0-9]+');
        Route::pattern('loan', '[0-9]+');
        Route::pattern('reminder', '[0-9]+');
        Route::pattern('ip', '[0-9]+');

        parent::boot();

        Route::bind('thing', function ($value) {
            return $value == '_new'
                ? new Thing(['properties' => []])
                : Thing::withTrashed()
                    ->with('items.loans')
                    ->with('items.allLoans')
                    ->find($value) ?? abort(404);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        });

        Route::bind('item', function ($value) {
            return $value == '_new'
                ? new Item([ 'library_id' => \Auth::user()->id ])
                : Item::withTrashed()->find($value) ?? abort(404);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        });

        Route::bind('user', function ($value) {
            return $value == '_new'
                ? new User()
                : User::find($value) ?? abort(404);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        });

        Route::bind('loan', function ($value) {
            return Loan::withTrashed()->find($value) ?? abort(404);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        });

        Route::bind('notification', function ($value) {
            return ExtendedDatabaseNotification::with('loan')
                    ->find($value) ?? abort(404);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        });
    }

    /**
     * Define the routes for the application.
     *
     * @return void
     */
    public function map()
    {
        $this->mapApiRoutes();

        $this->mapWebRoutes();

        $this->mapWebhooksRoutes();
    }

    /**
     * Define the "web" routes for the application.
     *
     * These routes all receive session state, CSRF protection, etc.
     *
     * @return void
     */
    protected function mapWebRoutes()
    {
        Route::middleware('web')
             ->namespace($this->namespace)
             ->group(base_path('routes/web.php'));
    }

    /**
     * Define the "api" routes for the application.
     *
     * These routes are typically stateless.
     *
     * @return void
     */
    protected function mapApiRoutes()
    {
        Route::prefix('api')
             ->middleware('api')
             ->namespace($this->namespace)
             ->group(base_path('routes/api.php'));
    }

    /**
     * Define the "webhooks" routes for the application.
     *
     * These routes are typically stateless.
     *
     * @return void
     */
    protected function mapWebhooksRoutes()
    {
        Route::prefix('webhooks')
            ->middleware('webhooks')
            ->namespace($this->namespace)
            ->group(base_path('routes/webhooks.php'));
    }
}


1			<?php
2
3			namespace App\Providers;
4
5			use App\Item;
6			use App\Loan;
7			use App\Notifications\ExtendedDatabaseNotification;
8			use App\Thing;
9			use App\User;
10			use Illuminate\Support\Facades\Route;
11			use Illuminate\Foundation\Support\Providers\RouteServiceProvider as ServiceProvider;
12
13			class RouteServiceProvider extends ServiceProvider
14			{
15			/**
16			* This namespace is applied to your controller routes.
17			*
18			* In addition, it is set as the URL generator's root namespace.
19			*
20			* @var string
21			*/
22			protected $namespace = 'App\Http\Controllers';
23
24			/**
25			* Define your route model bindings, pattern filters, etc.
26			*
27			* @return void
28			*/
29			public function boot()
30			{
31			Route::pattern('user', '([0-9]+\|_new)');
32			Route::pattern('item', '([0-9]+\|_new)');
33			Route::pattern('thing', '([0-9]+\|_new)');
34
35			Route::pattern('library', '[0-9]+');
36			Route::pattern('user1', '[0-9]+');
37			Route::pattern('user2', '[0-9]+');
38			Route::pattern('loan', '[0-9]+');
39			Route::pattern('reminder', '[0-9]+');
40			Route::pattern('ip', '[0-9]+');
41
42			parent::boot();
43
44			Route::bind('thing', function ($value) {
45			return $value == '_new'
46			? new Thing(['properties' => []])
47			: Thing::withTrashed()
48			->with('items.loans')
49			->with('items.allLoans')
50			->find($value) ?? abort(404);
			0 ignored issues – show Bug introduced 2019-07-21 14:05 UTC by Report Bug Copy Issue Report Are you sure the usage of `abort(404)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
51			});
52
53			Route::bind('item', function ($value) {
54			return $value == '_new'
55			? new Item([ 'library_id' => \Auth::user()->id ])
56			: Item::withTrashed()->find($value) ?? abort(404);
			0 ignored issues – show Bug introduced 2019-07-21 14:05 UTC by Report Bug Copy Issue Report Are you sure the usage of `abort(404)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
57			});
58
59			Route::bind('user', function ($value) {
60			return $value == '_new'
61			? new User()
62			: User::find($value) ?? abort(404);
			0 ignored issues – show Bug introduced 2019-07-21 14:05 UTC by Report Bug Copy Issue Report Are you sure the usage of `abort(404)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
63			});
64
65			Route::bind('loan', function ($value) {
66			return Loan::withTrashed()->find($value) ?? abort(404);
			0 ignored issues – show Bug introduced 2019-07-21 14:05 UTC by Report Bug Copy Issue Report Are you sure the usage of `abort(404)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
67			});
68
69			Route::bind('notification', function ($value) {
70			return ExtendedDatabaseNotification::with('loan')
71			->find($value) ?? abort(404);
			0 ignored issues – show Bug introduced 2019-07-21 14:05 UTC by Report Bug Copy Issue Report Are you sure the usage of `abort(404)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
72			});
73			}
74
75			/**
76			* Define the routes for the application.
77			*
78			* @return void
79			*/
80			public function map()
81			{
82			$this->mapApiRoutes();
83
84			$this->mapWebRoutes();
85
86			$this->mapWebhooksRoutes();
87			}
88
89			/**
90			* Define the "web" routes for the application.
91			*
92			* These routes all receive session state, CSRF protection, etc.
93			*
94			* @return void
95			*/
96			protected function mapWebRoutes()
97			{
98			Route::middleware('web')
99			->namespace($this->namespace)
100			->group(base_path('routes/web.php'));
101			}
102
103			/**
104			* Define the "api" routes for the application.
105			*
106			* These routes are typically stateless.
107			*
108			* @return void
109			*/
110			protected function mapApiRoutes()
111			{
112			Route::prefix('api')
113			->middleware('api')
114			->namespace($this->namespace)
115			->group(base_path('routes/api.php'));
116			}
117
118			/**
119			* Define the "webhooks" routes for the application.
120			*
121			* These routes are typically stateless.
122			*
123			* @return void
124			*/
125			protected function mapWebhooksRoutes()
126			{
127			Route::prefix('webhooks')
128			->middleware('webhooks')
129			->namespace($this->namespace)
130			->group(base_path('routes/webhooks.php'));
131			}
132			}
133

scriptotek / bibrex

RouteServiceProvider::mapApiRoutes() A last analyzed 2020-08-20 14:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RouteServiceProvider::mapApiRoutes() A
last analyzed 2020-08-20 14:30 UTC