App\Rules\TemporaryBarcodeExists

Complexity

Total Complexity

6

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getNormalizedValue()	0	3	1
A	message()	0	3	1
A	__construct()	0	4	1
A	passes()	0	13	3

<?php

namespace App\Rules;

use Illuminate\Contracts\Validation\Rule;
use Scriptotek\Alma\Client as AlmaClient;

class TemporaryBarcodeExists implements Rule
{
    /**
     * Create a new rule instance.
     *
     * @return void
     */
    public function __construct(AlmaClient $alma)
    {
        $this->alma = $alma;

The property alma does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->normalizedValue = null;

The property normalizedValue does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Determine if the validation rule passes.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @return bool
     */
    public function passes($attribute, $value)
    {
        if (empty($value)) {
            return true;
        }

        $almaUser = $this->alma->users->findOne('ALL~' . $value);
        if (!is_null($almaUser)) {
            $this->normalizedValue = $almaUser->getPrimaryId();

The property normalizedValue does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return true;
        }

        return false;
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()
    {
        return 'Det midlertidige lånekortet må eksistere i Alma.';
    }

    public function getNormalizedValue()
    {
        return $this->normalizedValue;
    }
}