scriptotek /
bibrex
| Total Complexity | 41 |
| Total Lines | 373 |
| Duplicated Lines | 0 % |
| Changes | 6 | ||
| Bugs | 0 | Features | 0 |
Complex classes like UsersController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use UsersController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | class UsersController extends Controller |
||
| 18 | { |
||
| 19 | /** |
||
| 20 | * Display a listing of the resource. |
||
| 21 | * |
||
| 22 | * @param Request $request |
||
| 23 | * @return Response |
||
| 24 | */ |
||
| 25 | public function getIndex(Request $request) |
||
| 48 | ]); |
||
| 49 | } |
||
| 50 | |||
| 51 | /** |
||
| 52 | * Display a listing of the resource as json. |
||
| 53 | * |
||
| 54 | * @param Request $request |
||
| 55 | * @return Response |
||
| 56 | */ |
||
| 57 | public function json(Request $request) |
||
| 58 | { |
||
| 59 | $users = []; |
||
| 60 | foreach (User::with('identifiers')->get() as $user) { |
||
| 61 | $users[] = [ |
||
| 62 | 'id' => $user->alma_primary_id ?? $user->id, |
||
| 63 | 'type' => $user->alma_primary_id ? 'alma' : 'local', |
||
| 64 | 'group' => $user->alma_user_group, |
||
| 65 | 'name' => $user->lastname . ', ' . $user->firstname, |
||
| 66 | 'identifiers' => $user->identifiers->map(function ($x) { |
||
| 67 | return $x->value; |
||
| 68 | }), |
||
| 69 | ]; |
||
| 70 | } |
||
| 71 | |||
| 72 | return response()->json($users); |
||
| 73 | } |
||
| 74 | |||
| 75 | /** |
||
| 76 | * Display a listing of the resource. |
||
| 77 | * |
||
| 78 | * @param AlmaClient $alma |
||
| 79 | * @param Request $request |
||
| 80 | * @return Response |
||
| 81 | */ |
||
| 82 | public function searchAlma(AlmaClient $alma, Request $request) |
||
| 83 | { |
||
| 84 | if (is_null($alma->key)) { |
||
| 85 | \Log::warning('Cannot search Alma users since no Alma API key is configured.'); |
||
| 86 | return response()->json([]); |
||
| 87 | } |
||
| 88 | $query = 'ALL~' . $request->input('query'); |
||
| 89 | $users = collect($alma->users->search($query, ['limit' => 5]))->map(function ($result) { |
||
| 90 | return [ |
||
| 91 | 'type' => 'alma', |
||
| 92 | 'id' => $result->primary_id, |
||
| 93 | 'name' => "{$result->last_name}, {$result->first_name}", |
||
| 94 | ]; |
||
| 95 | }); |
||
| 96 | |||
| 97 | return response()->json($users); |
||
| 98 | } |
||
| 99 | |||
| 100 | /** |
||
| 101 | * Display the specified resource. |
||
| 102 | * |
||
| 103 | * @param User $user |
||
| 104 | * @return Response |
||
| 105 | */ |
||
| 106 | public function getShow(User $user) |
||
| 107 | { |
||
| 108 | return response()->view('users.show', [ |
||
| 109 | 'user' => $user, |
||
| 110 | ]); |
||
| 111 | } |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Display form for connecting local user to external user. |
||
| 115 | * |
||
| 116 | * @param User $user |
||
| 117 | * @return Response |
||
| 118 | */ |
||
| 119 | public function connectForm(AlmaUsers $almaUsers, User $user) |
||
| 120 | { |
||
| 121 | if (!$almaUsers->hasKey()) { |
||
| 122 | return back()->with('error', 'Ingen API-nøkkel konfigurert, Bibrex kan ikke snakke med Alma.'); |
||
| 123 | } |
||
| 124 | |||
| 125 | $ident = $user->identifiers()->first(); |
||
| 126 | return response()->view('users.connect', [ |
||
| 127 | 'user' => $user, |
||
| 128 | 'user_identifier' => is_null($ident) ? null : $ident->value, |
||
| 129 | ]); |
||
| 130 | } |
||
| 131 | |||
| 132 | /** |
||
| 133 | * Connect local user to external user. |
||
| 134 | * |
||
| 135 | * @param AlmaUsers $almaUsers |
||
| 136 | * @param Request $request |
||
| 137 | * @param User $user |
||
| 138 | * @return Response |
||
| 139 | */ |
||
| 140 | public function connect(AlmaUsers $almaUsers, Request $request, User $user) |
||
| 172 | } |
||
| 173 | |||
| 174 | /** |
||
| 175 | * Import user data from Alma. |
||
| 176 | * |
||
| 177 | * @param AlmaUsers $almaUsers |
||
| 178 | * @param User $user |
||
| 179 | * @return Response |
||
| 180 | */ |
||
| 181 | public function sync(AlmaUsers $almaUsers, User $user) |
||
| 182 | { |
||
| 183 | if (!$almaUsers->hasKey()) { |
||
| 184 | return back()->with('error', 'Ingen API-nøkkel konfigurert, Bibrex kan ikke snakke med Alma.'); |
||
| 185 | } |
||
| 186 | |||
| 187 | if (!$user->alma_primary_id && !$user->identifiers->count()) { |
||
| 188 | return back()->with('error', 'Du må registrere minst én identifikator for brukeren før du kan importere.'); |
||
| 189 | } |
||
| 190 | |||
| 191 | if (!$almaUsers->updateLocalUserFromAlmaUser($user)) { |
||
| 192 | $user->save(); |
||
| 193 | |||
| 194 | return back()->with('error', 'Fant ikke brukeren i Alma 😭'); |
||
| 195 | } |
||
| 196 | $user->save(); |
||
| 197 | |||
| 198 | return back()->with('status', 'Brukeropplysninger ble oppdatert fra Alma.'); |
||
| 199 | } |
||
| 200 | |||
| 201 | /** |
||
| 202 | * Show the form for editing the specified resource. |
||
| 203 | * |
||
| 204 | * @param User $user |
||
| 205 | * @param Request $request |
||
| 206 | * @return Response |
||
| 207 | */ |
||
| 208 | public function getEdit(User $user, Request $request) |
||
| 209 | { |
||
| 210 | if (!$user->id) { |
||
| 211 | $identifiers = []; |
||
| 212 | if ($request->barcode) { |
||
| 213 | $identifiers[] = UserIdentifier::make([ |
||
| 214 | 'value' => $request->barcode, |
||
| 215 | 'type' => 'barcode', |
||
| 216 | ]); |
||
| 217 | } |
||
| 218 | if ($request->university_id) { |
||
| 219 | $identifiers[] = UserIdentifier::make([ |
||
| 220 | 'value' => $request->university_id, |
||
| 221 | 'type' => 'university_id', |
||
| 222 | ]); |
||
| 223 | } |
||
| 224 | $user->identifiers = $identifiers; |
||
| 225 | $user->lastname = $request->lastname; |
||
| 226 | $user->firstname = $request->firstname; |
||
| 227 | $user->phone = $request->phone; |
||
| 228 | $user->email = $request->email; |
||
| 229 | } |
||
| 230 | |||
| 231 | return response()->view('users.edit', array( |
||
| 232 | 'user' => $user |
||
| 233 | )); |
||
| 234 | } |
||
| 235 | |||
| 236 | /** |
||
| 237 | * Update the specified resource in storage. |
||
| 238 | * |
||
| 239 | * @param User $user |
||
| 240 | * @param UserUpsertRequest $request |
||
| 241 | * @return Response |
||
| 242 | */ |
||
| 243 | public function upsert(User $user, UserUpsertRequest $request) |
||
| 272 | } |
||
| 273 | |||
| 274 | /** |
||
| 275 | * Display form to merge two users. |
||
| 276 | * |
||
| 277 | * @param User $user1 |
||
| 278 | * @param User $user2 |
||
| 279 | * @return Response |
||
| 280 | */ |
||
| 281 | public function getMerge(User $user1, User $user2) |
||
| 282 | { |
||
| 283 | $merged = $user1->getMergeData($user2); |
||
| 284 | |||
| 285 | return response()->view('users.merge', array( |
||
| 286 | 'user1' => $user1, |
||
| 287 | 'user2' => $user2, |
||
| 288 | 'merged' => $merged |
||
| 289 | )); |
||
| 290 | } |
||
| 291 | |||
| 292 | /** |
||
| 293 | * Merge $user2 into $user1 |
||
| 294 | * |
||
| 295 | * @param Request $request |
||
| 296 | * @param User $user1 |
||
| 297 | * @param User $user2 |
||
| 298 | * @return Response |
||
| 299 | */ |
||
| 300 | public function postMerge(Request $request, User $user1, User $user2) |
||
| 332 | } |
||
| 333 | |||
| 334 | /** |
||
| 335 | * Show the form for creating the specified resource. |
||
| 336 | * |
||
| 337 | * @param Request $request |
||
| 338 | * @return Response |
||
| 339 | */ |
||
| 340 | public function createForm(Request $request) |
||
| 341 | { |
||
| 342 | $user = User::make(); |
||
| 343 | |||
| 344 | return response()->view('users.create', [ |
||
| 345 | 'user' => $user, |
||
| 346 | ]); |
||
| 347 | } |
||
| 348 | |||
| 349 | /** |
||
| 350 | * Show the form for deleting the specified resource. |
||
| 351 | * |
||
| 352 | * @param User $user |
||
| 353 | * @param Request $request |
||
| 354 | * @return Response |
||
| 355 | */ |
||
| 356 | public function deleteForm(User $user, Request $request) |
||
| 365 | ]); |
||
| 366 | } |
||
| 367 | |||
| 368 | /** |
||
| 369 | * Delte the specified resource from storage. |
||
| 370 | * |
||
| 371 | * @param User $user |
||
| 372 | * @param Request $request |
||
| 373 | * @return Response |
||
| 374 | */ |
||
| 375 | public function delete(User $user, Request $request) |
||
| 392 |
Loading history...
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.