App\Http\Controllers\ThingsController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	361
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	json()	0	29	3
A	index()	0	35	1
A	restore()	0	12	1
A	miscErrorResponse()	0	5	1
A	show()	0	42	1
A	upsert()	0	45	3
A	updateSettings()	0	21	1
A	updateImage()	0	52	1
A	delete()	0	20	3

<?php

namespace App\Http\Controllers;

use App\Item;
use App\Thing;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Imagine\Imagick\Imagine;

class ThingsController extends Controller
{

    protected $thing;

    /**
     * Validation error messages.
     *
     * @static array
     */
    protected $messages = [
        'name.required' => 'Internt navn må fylles ut.',
        'name.unique' => 'Typen finnes allerede.',

        'loan_time.required' => 'Lånetid må fylles ut.',

        'properties.name_indefinite.nob.required' => 'Ubestemt form på bokmål må fylles ut.',
        'properties.name_definite.nob.required' => 'Bestemt form på bokmål må fylles ut.',

        'properties.name_indefinite.nno.required' => 'Ubestemt form på nynorsk må fylles ut.',
        'properties.name_definite.nno.required' => 'Bestemt form på nynorsk må fylles ut.',

        'properties.name_indefinite.eng.required' => 'Ubestemt form på engelsk må fylles ut.',
        'properties.name_definite.eng.required' => 'Bestemt form på engelsk må fylles ut.',
    ];

    /**
     * Display a listing of the resource.
     *
     * @param Request $request
     * @return Response
     */
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        $libraryId = \Auth::user()->id;

        $things = Thing::with('items', 'settings', 'items.loans')
            ->orderBy('properties->name->nob')
            ->get();

        $things = $things->map(function ($thing) use ($libraryId) {
            $all = $thing->items->whereNotIn('barcode', [null]);
            $avail = $all->filter(function (Item $item) {
                return is_null($item->activeLoan);

The property activeLoan does not seem to exist on App\Item. Are you sure there is no database migration missing?

            });
            $mine = $all->where('library_id', $libraryId);
            $avail_mine = $avail->where('library_id', $libraryId);

            return [
                'type' => 'thing',
                'id' => $thing->id,
                'name' => $thing->name(),
                'library_settings' => $thing->library_settings,
                'properties' => $thing->properties,
                'image' => $thing->image,
                'loan_time' => $thing->loan_time,

                'items_total' => $all->count(),
                'items_mine' => $mine->count(),

                'avail_total' => $avail->count(),
                'avail_mine' => $avail_mine->count(),
            ];
        });

        return response()->view('things.index', [
            'things' => $things,
        ]);
    }

    /**
     * Display a listing of the resource.
     *
     * @param Request $request
     * @return Response
     */
    public function json(Request $request)
    {
        $libraryId = \Auth::user()->id;

The assignment to $libraryId is dead and can be removed.

        $things = Thing::with('settings');

        if ($request->input('withLoans')) {
            $things->with('items.loans');
        }

        $things = $things->orderBy('properties->name->nob')->get();

        if ($request->input('withoutBarcode')) {
            $things = $things->filter(function ($thing) {
                return $thing->library_settings->loans_without_barcode;
            })->values();
        }

        $things = $things->map(function ($thing) {
            return [
                'id' => $thing->id,
                'type' => 'thing',
                'name' => $thing->name(),
                'properties' => $thing->properties,
                'library_settings' => $thing->library_settings,
            ];
        });

        return response()->json($things);

The expression return response()->json($things) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Display the specified resource.
     *
     * @param Thing $thing
     * @return Response
     */
    public function show(Thing $thing)
    {
        $items = Item::with('thing', 'library')
            ->whereNotNull('barcode')
            ->where('thing_id', '=', $thing->id)
            ->orderBy('library_id')
            ->orderBy('barcode')
            ->get();

        $stats = [
            'loans' => [
                'total' => \DB::select(
                    "select count(*) as val from loans
                      where loans.item_id IN (select id from items where thing_id=:thing_id)",
                    ['thing_id' => $thing->id]
                )[0]->val,
                'this_year' => \DB::select(
                    "select count(*) as val from loans
                      where loans.item_id in (select id from items where thing_id=:thing_id)
                      and date_part('year', loans.created_at) = :year",
                    ['thing_id' => $thing->id, 'year' => date('Y')]
                )[0]->val,
                'last_year' => \DB::select(
                    "select count(*) as val from loans
                      where loans.item_id in (select id from items where thing_id=:thing_id)
                      and date_part('year', loans.created_at) = :year",
                    ['thing_id' => $thing->id, 'year' => date('Y') - 1]
                )[0]->val,
            ],
            'items' => [
                'lost' => \DB::select(
                    "select count(*) as val from items
                      where items.is_lost = :is_lost and thing_id=:thing_id",
                    ['thing_id' => $thing->id, 'is_lost' => true]
                )[0]->val,
            ]
        ];

        return response()->view('things.show', array(
            'thing' => $thing,
            'items' => $items,
            'stats' => $stats,
        ));
    }

    /**
     * Update or create the specified resource in storage.
     *
     * @param Thing $thing
     * @param Request $request
     * @return Response
     */
    public function upsert(Thing $thing, Request $request)
    {
        \Validator::make($request->all(), [
            //'name' => 'required|unique:things,name' . ($thing->id ? ',' . $thing->id : ''),

            'properties.name.nob' => 'required',
            'properties.name.nno' => 'required',
            'properties.name.eng' => 'required',

            'properties.name_indefinite.nob' => 'required',
            'properties.name_indefinite.nno' => 'required',
            'properties.name_indefinite.eng' => 'required',
            'properties.name_definite.nob' => 'required',
            'properties.name_definite.nno' => 'required',
            'properties.name_definite.eng' => 'required',
            'properties.loan_time' => 'required|numeric|min:1',
        ], $this->messages)->validate();

        $isNew = !$thing->exists;

        if ($isNew) {
            // The frontend will redirect to update the url, so flash a status message to the new page.
            \Session::flash('status', 'Tingen ble lagret.');
        }

        $thing->properties = $request->input('properties');
        $thing->save();

        if ($isNew) {
            \Log::info(sprintf(
                'Opprettet tingen <a href="%s">%s</a>.',
                action('ThingsController@show', $thing->id),
                $thing->name()
            ));
        } else {
            \Log::info(sprintf(
                'Oppdaterte tingen <a href="%s">%s</a>.',
                action('ThingsController@show', $thing->id),
                $thing->name()
            ));
        }

        return response()->json([

The expression return response()->json(array('status' => 'Tingen «' . $thing->name() . '» ble lagret.', 'thing' => $thing)) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

            'status' => 'Tingen «' . $thing->name() . '» ble lagret.',
            'thing' => $thing,
        ]);
    }

    /**
     * Update thing settings for my library.
     *
     * @param Thing $thing
     * @return Response
     */
    public function updateSettings(Thing $thing, Request $request)
    {
        \Validator::make($request->all(), [
            'loans_without_barcode' => ['required', 'boolean'],
            'reminders' => ['required', 'boolean'],
        ])->validate();

        $settings = $thing->library_settings;
        $settings->loans_without_barcode = (boolean) $request->input('loans_without_barcode');

The property loans_without_barcode does not seem to exist on App\ThingSettings. Are you sure there is no database migration missing?

        $settings->reminders = (boolean) $request->input('reminders');

The property reminders does not seem to exist on App\ThingSettings. Are you sure there is no database migration missing?

        $settings->save();

        \Log::info(sprintf(
            'Oppdaterte innstillinger for tingen <a href="%s">%s</a>.',
            action('ThingsController@show', $thing->id),
            $thing->name()
        ));

        return response()->json([

The expression return response()->json(array('status' => 'ok', 'library_settings' => $settings)) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

            'status' => 'ok',
            'library_settings' => $settings,
        ]);
    }

    /**
     * Update image
     *
     * @param Thing $thing
     * @param Request $request
     * @param Imagine $imagine
     * @return Response
     * @throws \Illuminate\Validation\ValidationException
     */
    public function updateImage(Thing $thing, Request $request, Imagine $imagine)
    {
        $this->validate($request, [
            'thingimage' => 'required|image|mimes:jpeg,png,jpg,gif,svg|max:10000',
        ]);

        $file = $request->file('thingimage');
        $filename = $file->storePublicly('public');
        $filename = substr($filename, strpos($filename, '/') + 1);

It seems like $filename can also be of type false; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

It seems like $filename can also be of type false; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

        $filename_t = $filename . '.thumb.jpg';

        $fullpath  = storage_path("app/public/$filename");
        $fullpath_t = storage_path("app/public/$filename_t");

        $imagine->open($fullpath)
            ->thumbnail(
                new \Imagine\Image\Box(
                    config('bibrex.thumbnail_dimensions.width'),
                    config('bibrex.thumbnail_dimensions.height')
                ),
                \Imagine\Image\ImageInterface::THUMBNAIL_INSET
            )
            ->save($fullpath_t);

        list($width, $height) = getimagesize($fullpath);
        list($width_t, $height_t) = getimagesize($fullpath_t);

        $thing->image = [
            'full' => [
                'name' => $filename,
                'size' => filesize($fullpath),
                'width' => $width,
                'height' => $height,
            ],
            'thumb' => [
                'name' => $filename_t,
                'size' => filesize($fullpath_t),
                'width' => $width_t,
                'height' => $height_t,
            ],
        ];
        $thing->save();

        \Log::info(sprintf(
            'Oppdaterte bilde for tingen <a href="%s">%s</a>.',
            action('ThingsController@show', $thing->id),
            $thing->name()
        ));

        return response()->json([

The expression return response()->json(array('status' => 'Bildet ble lagret.', 'thing' => $thing)) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

            'status' => 'Bildet ble lagret.',
            'thing' => $thing,
        ]);
    }

    public function miscErrorResponse($msg)
    {
        return response()->json([
            'errors' => ['misc' => [$msg]],
        ], 422);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param Thing $thing
     * @return Response
     */
    public function delete(Thing $thing)
    {
        if ($thing->items()->whereNotNull('barcode')->count() != 0) {
            return $this->miscErrorResponse('Kan ikke slette ting med eksemplarer.');

The expression return $this->miscErrorResponse('Kan ikke slette ting med eksemplarer.') returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        if (count($thing->activeLoans()) != 0) {
            return $this->miscErrorResponse('Kan ikke slette ting med aktive lån.');

The expression return $this->miscErrorResponse('Kan ikke slette ting med aktive lån.') returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        \Log::info(sprintf(
            'Slettet tingen <a href="%s">%s</a>.',
            action('ThingsController@show', $thing->id),
            $thing->name()
        ));
        $thing->delete();

        return response()->json([

The expression return response()->json(array('status' => 'Tingen «' . $thing->name() . '» ble sletta.', 'thing' => $thing)) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

            'status' => 'Tingen «' . $thing->name() . '» ble sletta.',
            'thing' => $thing,
        ]);
    }

    /**
     * Restore the specified resource.
     *
     * @param Thing $thing
     * @return Response
     */
    public function restore(Thing $thing)
    {
        $thing->restore();
        \Log::info(sprintf(
            'Gjenopprettet tingen <a href="%s">%s</a>.',
            action('ThingsController@show', $thing->id),
            $thing->name()
        ));

        return response()->json([

The expression return response()->json(array('status' => 'Tingen «' . $thing->name() . '» ble gjenopprettet.', 'thing' => $thing)) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

            'status' => 'Tingen «' . $thing->name() . '» ble gjenopprettet.',
            'thing' => $thing,
        ]);
    }
}