App\Http\Controllers\NotificationsController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	7	1
A	create()	0	8	1
A	show()	0	7	1

<?php

namespace App\Http\Controllers;

use App\Loan;
use App\Notifications\ExtendedDatabaseNotification;
use App\Notifications\FirstReminder;
use App\Notifications\ManualReminder;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Illuminate\Support\Arr;

class NotificationsController extends Controller
{

    /**
     * Show a reminder.
     *
     * @param ExtendedDatabaseNotification $notification
     * @return Response
     */
    public function show(ExtendedDatabaseNotification $notification)
    {
        return response()->view('notifications.show', [
            'type' => $notification->humanReadableType(),
            'loan' => $notification->loan,
            'email' => Arr::get($notification->data, 'email'),

The property data does not seem to exist on App\Notifications\ExtendedDatabaseNotification. Are you sure there is no database migration missing?

            'sent' => $notification->created_at,
        ]);
    }

    /**
     * Display a form to create the resource.
     *
     * @param Loan $loan
     * @return Response
     */
    public function create(Loan $loan)
    {
        $notification = new FirstReminder($loan);
        $email = $notification->email->toArray();

        return response()->view('notifications.create', array(
            'loan' => $loan,
            'email' => $email,
        ));
    }

    /**
     * Sends a new reminder.
     *
     * @param Loan $loan
     * @param Request $request
     * @return Response
     */
    public function send(Loan $loan, Request $request)
    {
        $loan->user->notify(new ManualReminder($loan, $request->input('subject'), $request->input('body')));

        return redirect()

The expression return redirect()->actio returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->action('LoansController@getShow', $loan->id)
            ->with('status', 'Påminnelsen ble sendt.');
    }
}