Scrawler\Arca\Traits\Model\Setter

Complexity

Total Complexity

5

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setProperties()	0	6	2
A	setLoadedProperties()	0	9	2
A	setLoaded()	0	5	1

<?php

namespace Scrawler\Arca\Traits\Model;
use Scrawler\Arca\Model;
trait Setter{

      /**
     * Set all properties of model via array
     * @param array<mixed> $properties
     * @return Model
     */
    public function setProperties(array $properties): Model
    {
        foreach ($properties as $key => $value) {
            $this->set($key, $value);

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
        return $this;

The expression return $this returns the type Scrawler\Arca\Traits\Model\Setter which includes types incompatible with the type-hinted return Scrawler\Arca\Model.

    }

     /**
     * Set all properties of model loaded via database
     * @param array<mixed> $properties
     * @return Model
     */
    public function setLoadedProperties(array $properties): Model
    {
        $this->__properties['all'] = $properties;

The property __properties does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->__properties['self'] = $properties;
        foreach ($properties as $key => $value) {
            $this->__properties['type'][$key] = $this->connection->getTableManager()->getTable($this->table)->getColumn($key)->getComment();
        }
        $this->__meta['id'] = $properties['id'];

The property __meta does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;

The expression return $this returns the type Scrawler\Arca\Traits\Model\Setter which includes types incompatible with the type-hinted return Scrawler\Arca\Model.

    }

     /**
     * call when model is loaded from database
     * @return Model
     */
    public function setLoaded(): Model
    {
        $this->__meta['is_loaded'] = true;

The property __meta does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->__meta['id_error'] = false;
        return $this;

The expression return $this returns the type Scrawler\Arca\Traits\Model\Setter which includes types incompatible with the type-hinted return Scrawler\Arca\Model.

    }
}