NodeCollection::offsetSet() - Code Metrics - Inspection of "Update for PHP 7.1" - scotteh/php-dom-wrapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ac4bd7...8d332b )

by Andrew

created 2018-02-14 11:40 UTC

NodeCollection::offsetSet() A

↳ Parent: NodeCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	7
ccs	4
cts	5
cp	0.8
rs	9.4285
cc	2
eloc	5
nc	2
nop	2
crap	2.032

<?php declare(strict_types=1);

namespace DOMWrap\Collections;

/**
 * Node List
 *
 * @package DOMWrap\Collections
 * @license http://opensource.org/licenses/BSD-3-Clause BSD 3 Clause
 */
class NodeCollection implements \Countable, \ArrayAccess, \RecursiveIterator
{
    /** @var iterable */
    protected $nodes = [];

    /**
     * @param iterable $nodes
     */
    public function __construct(iterable $nodes = null) {
        if (!is_iterable($nodes)) {
            $nodes = [];
        }

        foreach ($nodes as $node) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $this->nodes[] = $node;
        }
    }

    /**
     * @see \Countable::count()
     *
     * @return int
     */
    public function count(): int {
        return count($this->nodes);
    }

    /**
     * @see \ArrayAccess::offsetExists()
     *
     * @param mixed $offset
     *
     * @return bool
     */
    public function offsetExists($offset): bool {
        return isset($this->nodes[$offset]);
    }

    /**
     * @see \ArrayAccess::offsetGet()
     *
     * @param mixed $offset
     *
     * @return mixed
     */
    public function offsetGet($offset) {
        return isset($this->nodes[$offset]) ? $this->nodes[$offset] : null;
    }

    /**
     * @see \ArrayAccess::offsetSet()
     *
     * @param mixed $offset
     * @param mixed $value
     */
    public function offsetSet($offset, $value): void {
        if (is_null($offset)) {
            $this->nodes[] = $value;
        } else {
            $this->nodes[$offset] = $value;
        }
    }

    /**
     * @see \ArrayAccess::offsetUnset()
     *
     * @param mixed $offset
     */
    public function offsetUnset($offset): void {
        unset($this->nodes[$offset]);
    }

    /**
     * @see \RecursiveIterator::RecursiveIteratorIterator()
     *
     * @return \RecursiveIteratorIterator
     */
    public function getRecursiveIterator(): \RecursiveIteratorIterator {
        return new \RecursiveIteratorIterator($this, \RecursiveIteratorIterator::SELF_FIRST);
    }

    /**
     * @see \RecursiveIterator::getChildren()
     *
     * @return \RecursiveIterator
     */
    public function getChildren(): \RecursiveIterator {
        $nodes = [];

        if ($this->valid()) {
            $nodes = $this->current()->childNodes;
        }

        return new static($nodes);
    }

    /**
     * @see \RecursiveIterator::hasChildren()
     *
     * @return bool
     */
    public function hasChildren(): bool {
        if ($this->valid()) {
            return $this->current()->hasChildNodes();
        }

        return false;
    }

    /**
     * @see \RecursiveIterator::current()
     * @see \Iterator::current()
     *
     * @return mixed
     */
    public function current() {
        return current($this->nodes);
    }

    /**
     * @see \RecursiveIterator::key()
     * @see \Iterator::key()
     *
     * @return mixed
     */
    public function key() {
        return key($this->nodes);
    }

    /**
     * @see \RecursiveIterator::next()
     * @see \Iterator::next()
     *
     * @return mixed
     */
    public function next() {
        return next($this->nodes);
    }

    /**
     * @see \RecursiveIterator::rewind()
     * @see \Iterator::rewind()
     *
     * @return mixed
     */
    public function rewind() {
        return reset($this->nodes);
    }

    /**
     * @see \RecursiveIterator::valid()
     * @see \Iterator::valid()
     *
     * @return bool
     */
    public function valid(): bool {
        return key($this->nodes) !== null;
    }
}

1		<?php declare(strict_types=1);
2
3		namespace DOMWrap\Collections;
4
5		/**
6		* Node List
7		*
8		* @package DOMWrap\Collections
9		* @license http://opensource.org/licenses/BSD-3-Clause BSD 3 Clause
10		*/
11		class NodeCollection implements \Countable, \ArrayAccess, \RecursiveIterator
12		{
13		/** @var iterable */
14		protected $nodes = [];
15
16		/**
17		* @param iterable $nodes
18		*/
19	138	public function __construct(iterable $nodes = null) {
20	138	if (!is_iterable($nodes)) {
21	1	$nodes = [];
22		}
23
24	138	foreach ($nodes as $node) {
		0 ignored issues – show Bug introduced 2018-02-14 11:52 UTC by Report Bug Copy Issue Report The expression `$nodes` of type `object<DOMWrap\Collections\iterable>\|null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
25	134	$this->nodes[] = $node;
26		}
27	138	}
28
29		/**
30		* @see \Countable::count()
31		*
32		* @return int
33		*/
34	76	public function count(): int {
35	76	return count($this->nodes);
36		}
37
38		/**
39		* @see \ArrayAccess::offsetExists()
40		*
41		* @param mixed $offset
42		*
43		* @return bool
44		*/
45		public function offsetExists($offset): bool {
46		return isset($this->nodes[$offset]);
47		}
48
49		/**
50		* @see \ArrayAccess::offsetGet()
51		*
52		* @param mixed $offset
53		*
54		* @return mixed
55		*/
56	20	public function offsetGet($offset) {
57	20	return isset($this->nodes[$offset]) ? $this->nodes[$offset] : null;
58		}
59
60		/**
61		* @see \ArrayAccess::offsetSet()
62		*
63		* @param mixed $offset
64		* @param mixed $value
65		*/
66	81	public function offsetSet($offset, $value): void {
67	81	if (is_null($offset)) {
68	81	$this->nodes[] = $value;
69		} else {
70		$this->nodes[$offset] = $value;
71		}
72	81	}
73
74		/**
75		* @see \ArrayAccess::offsetUnset()
76		*
77		* @param mixed $offset
78		*/
79		public function offsetUnset($offset): void {
80		unset($this->nodes[$offset]);
81		}
82
83		/**
84		* @see \RecursiveIterator::RecursiveIteratorIterator()
85		*
86		* @return \RecursiveIteratorIterator
87		*/
88		public function getRecursiveIterator(): \RecursiveIteratorIterator {
89		return new \RecursiveIteratorIterator($this, \RecursiveIteratorIterator::SELF_FIRST);
90		}
91
92		/**
93		* @see \RecursiveIterator::getChildren()
94		*
95		* @return \RecursiveIterator
96		*/
97		public function getChildren(): \RecursiveIterator {
98		$nodes = [];
99
100		if ($this->valid()) {
101		$nodes = $this->current()->childNodes;
102		}
103
104		return new static($nodes);
105		}
106
107		/**
108		* @see \RecursiveIterator::hasChildren()
109		*
110		* @return bool
111		*/
112		public function hasChildren(): bool {
113		if ($this->valid()) {
114		return $this->current()->hasChildNodes();
115		}
116
117		return false;
118		}
119
120		/**
121		* @see \RecursiveIterator::current()
122		* @see \Iterator::current()
123		*
124		* @return mixed
125		*/
126	130	public function current() {
127	130	return current($this->nodes);
128		}
129
130		/**
131		* @see \RecursiveIterator::key()
132		* @see \Iterator::key()
133		*
134		* @return mixed
135		*/
136	1	public function key() {
137	1	return key($this->nodes);
138		}
139
140		/**
141		* @see \RecursiveIterator::next()
142		* @see \Iterator::next()
143		*
144		* @return mixed
145		*/
146	130	public function next() {
147	130	return next($this->nodes);
148		}
149
150		/**
151		* @see \RecursiveIterator::rewind()
152		* @see \Iterator::rewind()
153		*
154		* @return mixed
155		*/
156	133	public function rewind() {
157	133	return reset($this->nodes);
158		}
159
160		/**
161		* @see \RecursiveIterator::valid()
162		* @see \Iterator::valid()
163		*
164		* @return bool
165		*/
166	131	public function valid(): bool {
167	131	return key($this->nodes) !== null;
168		}
169		}

scotteh / php-dom-wrapper

Push — master ( ac4bd7...8d332b )

NodeCollection::offsetSet() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like