Product::saveRelatedOptions() - Code Metrics - Inspection of "Allow option values to be deleted" - scottbedard/oc-shop-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8a92d6...46e7ad )

by Scott

created 2016-11-10 03:40 UTC

Product::saveRelatedOptions() B

↳ Parent: Project

Complexity

Conditions	4
Paths	5

Size

Total Lines	22
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	22
rs	8.9197
cc	4
eloc	14
nc	5
nop	1

<?php namespace Bedard\Shop\Models;

use DB;
use Flash;
use Lang;
use Model;
use October\Rain\Database\Builder;
use October\Rain\Database\ModelException;
use Queue;

/**
 * Product Model.
 */
class Product extends Model
{
    use \Bedard\Shop\Traits\Subqueryable,
        \October\Rain\Database\Traits\Purgeable,
        \October\Rain\Database\Traits\Validation;

    /**
     * @var string The database table used by the model.
     */
    public $table = 'bedard_shop_products';

    /**
     * @var array Default attributes
     */
    public $attributes = [
        'base_price' => 0,
        'description_html' => '',
        'description_plain' => '',
    ];

    /**
     * @var array Attribute casting
     */
    protected $casts = [
        'price' => 'float',
        'base_price' => 'float',
    ];

    /**
     * @var array Guarded fields
     */
    protected $guarded = ['*'];

    /**
     * @var array Fillable fields
     */
    protected $fillable = [
        'base_price',
        'categoriesList',
        'description_html',
        'description_plain',
        'name',
        'optionsInventories',
        'slug',
    ];

    /**
     * @var array Purgeable fields
     */
    public $purgeable = [
        'categoriesList',
        'optionsInventories',
    ];

    /**
     * @var array Relations
     */
    public $attachMany = [
        'images' => 'System\Models\File',
        'thumbnails' => 'System\Models\File',
    ];

    public $belongsToMany = [
        'categories' => [
            'Bedard\Shop\Models\Category',
            'table' => 'bedard_shop_category_product',
            'conditions' => 'is_inherited = 0',
        ],
        'discounts' => [
            'Bedard\Shop\Models\Discount',
            'table' => 'bedard_shop_discount_product',
        ],
    ];

    public $hasMany = [
        'inventories' => [
            'Bedard\Shop\Models\Inventory',
            'delete' => true,
        ],
        'options' => [
            'Bedard\Shop\Models\Option',
            'delete' => true,
            'order' => 'sort_order',
        ],
        'prices' => [
            'Bedard\Shop\Models\Price',
            'delete' => true,
        ],
    ];

    public $hasOne = [
        'current_price' => [
            'Bedard\Shop\Models\Price',
            'scope' => 'isActive',
            'order' => 'price asc',
        ],
    ];

    /**
     * @var array Validation
     */
    public $rules = [
        'name' => 'required',
        'base_price' => 'required|numeric|min:0',
        'slug' => 'required|unique:bedard_shop_products',
    ];

    /**
     * After save.
     *
     * @return void
     */
    public function afterSave()
    {
        $this->saveBasePrice();
        $this->saveCategoryRelationships();
        $this->saveOptionAndInventoryRelationships();
    }

    /**
     * After validate.
     *
     * @return void
     */
    public function afterValidate()
    {
        $this->validateOptions();
        $this->validateInventories();
    }

    /**
     * Before save.
     *
     * @return void
     */
    public function beforeSave()
    {
        $this->setPlainDescription();
    }

    /**
     * Delete inventories that have the is_deleted flag.
     *
     * @param  array $inventories
     * @return array
     */
    protected function deleteRelatedInventories($inventories)
    {
        return array_filter($inventories, function ($inventory) {
            if ($inventory['id'] !== null && $inventory['is_deleted']) {
                Inventory::find($inventory['id'])->delete();
            }

            return ! $inventory['is_deleted'];
        });
    }

    /**
     * Delete options that have the is_deleted flag.
     *
     * @param  array $options
     * @return array
     */
    protected function deleteRelatedOptions($options)
    {
        return array_filter($options, function ($option) {
            if ($option['id'] !== null && $option['is_deleted']) {
                Option::find($option['id'])->delete();
            }

            return ! $option['is_deleted'];
        });
    }

    /**
     * Delete option values that have the is_deleted flag.
     *
     * @param  array $optionValues
     * @return array
     */
    protected function deleteRelatedOptionValues($optionValues)
    {
        return array_filter($optionValues, function($optionValue) {
            if ($optionValue['id'] !== null && $optionValue['is_deleted']) {
                OptionValue::find($optionValue['id'])->delete();
            }

            return ! $optionValue['is_deleted'];
        });
    }

    /**
     * Get the categories options.
     *
     * @return array
     */
    public function getCategoriesListOptions()
    {
        return Category::orderBy('name')->lists('name', 'id');
    }

    /**
     * Get the categories that are directly related to this product.
     *
     * @return void
     */
    public function getCategoriesListAttribute()
    {
        return $this->categories()->lists('id');
    }

    /**
     * Update of create the related base price model.
     *
     * @return void
     */
    public function saveBasePrice()
    {
        Price::updateOrCreate(
            ['product_id' => $this->id, 'discount_id' => null],
            ['price' => $this->base_price]
        );
    }

    /**
     * Sync the categories checkboxlist with the category relationship.
     *
     * @return void
     */
    public function saveCategoryRelationships()
    {
        $categoryIds = $this->getOriginalPurgeValue('categoriesList');

        if (is_array($categoryIds)) {
            $this->categories()->sync($categoryIds);
        }

        $this->syncInheritedCategories();
    }

    /**
     * Save the options and inventories.
     *
     * @return void
     */
    public function saveOptionAndInventoryRelationships()
    {
        $data = $this->getOriginalPurgeValue('optionsInventories');

        if (is_array($data['options'])) {
            $options = $data['options'];
            $options = $this->deleteRelatedOptions($options);
            $this->saveRelatedOptions($options);
        }

        if (is_array($data['inventories'])) {
            $inventories = $data['inventories'];
            $inventories = $this->deleteRelatedInventories($inventories);
            $this->saveRelatedInventories($inventories);
        }
    }

    /**
     * Save an array of realted inventories.
     *
     * @param  array  $inventories
     * @return array
     */
    protected function saveRelatedInventories(array $inventories)
    {
        foreach ($inventories as $inventory) {
            $model = $inventory['id'] !== null
                ? Inventory::firstOrNew(['id' => $inventory['id']])
                : new Inventory;

            $inventory['product_id'] = $this->id;
            $model->fill($inventory);
            $model->save();
        }
    }

    /**
     * Save an array of related options.
     *
     * @param  array  $options
     * @return array
     */
    protected function saveRelatedOptions(array $options)
    {
        foreach ($options as $index => &$option) {
            $model = $option['id'] !== null
                ? Option::firstOrNew(['id' => $option['id']])
                : new Option;

            $model->fill($option);
            $model->product_id = $this->id;
            $model->sort_order = $index;

            $sessionKey = uniqid('session_key', true);
            if (is_array($option['values'])) {
                $option['values'] = $this->deleteRelatedOptionValues($option['values']);
                $this->saveRelatedOptionValues($model, $option['values'], $sessionKey);
            }

            $model->save(null, $sessionKey);
        }

        return $options;
    }

    /**
     * Save related option values.
     *
     * @param  Option $option
     * @param  array  $values
     * @param  string $sessionKey
     * @return void
     */
    protected function saveRelatedOptionValues(Option &$option, array $values, $sessionKey)
    {
        foreach ($values as $index => $value) {
            $model = array_key_exists('id', $value) && $value['id'] !== null
                ? OptionValue::firstOrNew(['id' => $value['id']])
                : new OptionValue;

            $model->fill($value);
            $model->sort_order = $index;
            $model->save();

            $option->values()->add($model, $sessionKey);
        }
    }

    /**
     * Left joins a subquery containing the product price.
     *
     * @param  \October\Rain\Database\Builder   $query
     * @return \October\Rain\Database\Builder
     */
    public function scopeJoinPrice(Builder $query)
    {
        $alias = 'prices';
        $grammar = $query->getQuery()->getGrammar();

        $subquery = Price::isActive()
            ->addselect('bedard_shop_prices.product_id')
            ->selectRaw('MIN('.$grammar->wrap('bedard_shop_prices.price').') as '.$grammar->wrap('price'))
            ->groupBy('bedard_shop_prices.product_id');

        return $query
            ->addSelect($alias.'.price')
            ->joinSubquery($subquery, $alias, 'bedard_shop_products.id', '=', $alias.'.product_id');
    }

    /**
     * Set the plain text description_html.
     *
     * @return void
     */
    protected function setPlainDescription()
    {
        $this->description_plain = strip_tags($this->description_html);
    }

    /**
     * Sync the inherited categories of all products.
     *
     * @return void
     */
    public static function syncAllInheritedCategories()
    {
        Queue::push(function ($job) {
            $data = [];
            $products = Product::with('categories')->get();
            $categoryTree = Category::getParentCategoryIds();

            foreach ($products as $product) {
                $inheritedCategoryIds = [];
                foreach ($product->categories as $category) {
                    if (array_key_exists($category->id, $categoryTree)) {
                        $inheritedCategoryIds = array_merge($inheritedCategoryIds, $categoryTree[$category->id]);
                    }
                }

                foreach (array_unique($inheritedCategoryIds) as $categoryId) {
                    $data[] = [
                        'category_id' => $categoryId,
                        'product_id' => $product->id,
                        'is_inherited' => 1,
                    ];
                }
            }

            DB::table('bedard_shop_category_product')->whereIsInherited(1)->delete();
            DB::table('bedard_shop_category_product')->insert($data);
            Discount::syncAllPrices();

            $job->delete();
        });
    }

    /**
     * Sync a product with it's inherited categories.
     *
     * @return void
     */
    public function syncInheritedCategories()
    {
        $data = [];
        $categoryIds = $this->categories()->lists('id');
        $parentIds = Category::isParentOf($categoryIds)->lists('id');
        foreach ($parentIds as $parentId) {
            $data[] = [
                'category_id' => $parentId,
                'product_id' => $this->id,
                'is_inherited' => true,
            ];
        }

        DB::table('bedard_shop_category_product')->whereProductId($this->id)->whereIsInherited(1)->delete();
        DB::table('bedard_shop_category_product')->insert($data);

        $categoryScope = array_merge($categoryIds, $parentIds);
        Discount::syncProductPrice($this, $categoryScope);
    }

    /**
     * Validate inventories.
     *
     * @throws \October\Rain\Database\ModelException
     * @return void
     */
    protected function validateInventories()

    {
        if (! is_array($this->optionsInventories) ||
            ! is_array($this->optionsInventories['options'])) {
            return;
        }

        $takenValueCombinations = [];
        foreach ($this->optionsInventories['inventories'] as $inventory) {
            // validate the inventory
            $model = new Inventory($inventory);
            $model->validate();

            // validate that the value combinations are unique
            sort($inventory['valueIds']);
            $valueCombination = json_encode($inventory['valueIds']);

            if (in_array($valueCombination, $takenValueCombinations)) {
                Flash::error(Lang::get('bedard.shop::lang.products.form.duplicate_inventories_error'));
                throw new ModelException($this);
            }

            $takenValueCombinations[] = $valueCombination;
        }
    }

    /**
     * Validate options.
     *
     * @throws \October\Rain\Database\ModelException
     * @return void
     */
    protected function validateOptions()

    {
        if (! is_array($this->optionsInventories) ||
            ! is_array($this->optionsInventories['options'])) {
            return;
        }

        $names = [];
        foreach ($this->optionsInventories['options'] as $option) {
            // validate the option
            $model = new Option($option);
            $model->validate();

            // validate that names are unique
            $name = strtolower(trim($option['name']));

            if (in_array($name, $names)) {
                Flash::error(Lang::get('bedard.shop::lang.products.form.duplicate_options_error'));
                throw new ModelException($this);
            }

            $names[] = $name;
        }
    }
}


1		<?php namespace Bedard\Shop\Models;
2
3		use DB;
4		use Flash;
5		use Lang;
6		use Model;
7		use October\Rain\Database\Builder;
8		use October\Rain\Database\ModelException;
9		use Queue;
10
11		/**
12		* Product Model.
13		*/
14		class Product extends Model
15		{
16		use \Bedard\Shop\Traits\Subqueryable,
17		\October\Rain\Database\Traits\Purgeable,
18		\October\Rain\Database\Traits\Validation;
19
20		/**
21		* @var string The database table used by the model.
22		*/
23		public $table = 'bedard_shop_products';
24
25		/**
26		* @var array Default attributes
27		*/
28		public $attributes = [
29		'base_price' => 0,
30		'description_html' => '',
31		'description_plain' => '',
32		];
33
34		/**
35		* @var array Attribute casting
36		*/
37		protected $casts = [
38		'price' => 'float',
39		'base_price' => 'float',
40		];
41
42		/**
43		* @var array Guarded fields
44		*/
45		protected $guarded = ['*'];
46
47		/**
48		* @var array Fillable fields
49		*/
50		protected $fillable = [
51		'base_price',
52		'categoriesList',
53		'description_html',
54		'description_plain',
55		'name',
56		'optionsInventories',
57		'slug',
58		];
59
60		/**
61		* @var array Purgeable fields
62		*/
63		public $purgeable = [
64		'categoriesList',
65		'optionsInventories',
66		];
67
68		/**
69		* @var array Relations
70		*/
71		public $attachMany = [
72		'images' => 'System\Models\File',
73		'thumbnails' => 'System\Models\File',
74		];
75
76		public $belongsToMany = [
77		'categories' => [
78		'Bedard\Shop\Models\Category',
79		'table' => 'bedard_shop_category_product',
80		'conditions' => 'is_inherited = 0',
81		],
82		'discounts' => [
83		'Bedard\Shop\Models\Discount',
84		'table' => 'bedard_shop_discount_product',
85		],
86		];
87
88		public $hasMany = [
89		'inventories' => [
90		'Bedard\Shop\Models\Inventory',
91		'delete' => true,
92		],
93		'options' => [
94		'Bedard\Shop\Models\Option',
95		'delete' => true,
96		'order' => 'sort_order',
97		],
98		'prices' => [
99		'Bedard\Shop\Models\Price',
100		'delete' => true,
101		],
102		];
103
104		public $hasOne = [
105		'current_price' => [
106		'Bedard\Shop\Models\Price',
107		'scope' => 'isActive',
108		'order' => 'price asc',
109		],
110		];
111
112		/**
113		* @var array Validation
114		*/
115		public $rules = [
116		'name' => 'required',
117		'base_price' => 'required\|numeric\|min:0',
118		'slug' => 'required\|unique:bedard_shop_products',
119		];
120
121		/**
122		* After save.
123		*
124		* @return void
125		*/
126		public function afterSave()
127		{
128		$this->saveBasePrice();
129		$this->saveCategoryRelationships();
130		$this->saveOptionAndInventoryRelationships();
131		}
132
133		/**
134		* After validate.
135		*
136		* @return void
137		*/
138		public function afterValidate()
139		{
140		$this->validateOptions();
141		$this->validateInventories();
142		}
143
144		/**
145		* Before save.
146		*
147		* @return void
148		*/
149		public function beforeSave()
150		{
151		$this->setPlainDescription();
152		}
153
154		/**
155		* Delete inventories that have the is_deleted flag.
156		*
157		* @param array $inventories
158		* @return array
159		*/
160		protected function deleteRelatedInventories($inventories)
161		{
162		return array_filter($inventories, function ($inventory) {
163		if ($inventory['id'] !== null && $inventory['is_deleted']) {
164		Inventory::find($inventory['id'])->delete();
165		}
166
167		return ! $inventory['is_deleted'];
168		});
169		}
170
171		/**
172		* Delete options that have the is_deleted flag.
173		*
174		* @param array $options
175		* @return array
176		*/
177		protected function deleteRelatedOptions($options)
178		{
179		return array_filter($options, function ($option) {
180		if ($option['id'] !== null && $option['is_deleted']) {
181		Option::find($option['id'])->delete();
182		}
183
184		return ! $option['is_deleted'];
185		});
186		}
187
188		/**
189		* Delete option values that have the is_deleted flag.
190		*
191		* @param array $optionValues
192		* @return array
193		*/
194		protected function deleteRelatedOptionValues($optionValues)
195		{
196		return array_filter($optionValues, function($optionValue) {
197		if ($optionValue['id'] !== null && $optionValue['is_deleted']) {
198		OptionValue::find($optionValue['id'])->delete();
199		}
200
201		return ! $optionValue['is_deleted'];
202		});
203		}
204
205		/**
206		* Get the categories options.
207		*
208		* @return array
209		*/
210		public function getCategoriesListOptions()
211		{
212		return Category::orderBy('name')->lists('name', 'id');
213		}
214
215		/**
216		* Get the categories that are directly related to this product.
217		*
218		* @return void
219		*/
220		public function getCategoriesListAttribute()
221		{
222		return $this->categories()->lists('id');
223		}
224
225		/**
226		* Update of create the related base price model.
227		*
228		* @return void
229		*/
230		public function saveBasePrice()
231		{
232		Price::updateOrCreate(
233		['product_id' => $this->id, 'discount_id' => null],
234		['price' => $this->base_price]
235		);
236		}
237
238		/**
239		* Sync the categories checkboxlist with the category relationship.
240		*
241		* @return void
242		*/
243		public function saveCategoryRelationships()
244		{
245		$categoryIds = $this->getOriginalPurgeValue('categoriesList');
246
247		if (is_array($categoryIds)) {
248		$this->categories()->sync($categoryIds);
249		}
250
251		$this->syncInheritedCategories();
252		}
253
254		/**
255		* Save the options and inventories.
256		*
257		* @return void
258		*/
259		public function saveOptionAndInventoryRelationships()
260		{
261		$data = $this->getOriginalPurgeValue('optionsInventories');
262
263		if (is_array($data['options'])) {
264		$options = $data['options'];
265		$options = $this->deleteRelatedOptions($options);
266		$this->saveRelatedOptions($options);
267		}
268
269		if (is_array($data['inventories'])) {
270		$inventories = $data['inventories'];
271		$inventories = $this->deleteRelatedInventories($inventories);
272		$this->saveRelatedInventories($inventories);
273		}
274		}
275
276		/**
277		* Save an array of realted inventories.
278		*
279		* @param array $inventories
280		* @return array
281		*/
282		protected function saveRelatedInventories(array $inventories)
283		{
284		foreach ($inventories as $inventory) {
285		$model = $inventory['id'] !== null
286		? Inventory::firstOrNew(['id' => $inventory['id']])
287		: new Inventory;
288
289		$inventory['product_id'] = $this->id;
290		$model->fill($inventory);
291		$model->save();
292		}
293		}
294
295		/**
296		* Save an array of related options.
297		*
298		* @param array $options
299		* @return array
300		*/
301		protected function saveRelatedOptions(array $options)
302		{
303		foreach ($options as $index => &$option) {
304		$model = $option['id'] !== null
305		? Option::firstOrNew(['id' => $option['id']])
306		: new Option;
307
308		$model->fill($option);
309		$model->product_id = $this->id;
310		$model->sort_order = $index;
311
312		$sessionKey = uniqid('session_key', true);
313		if (is_array($option['values'])) {
314		$option['values'] = $this->deleteRelatedOptionValues($option['values']);
315		$this->saveRelatedOptionValues($model, $option['values'], $sessionKey);
316		}
317
318		$model->save(null, $sessionKey);
319		}
320
321		return $options;
322		}
323
324		/**
325		* Save related option values.
326		*
327		* @param Option $option
328		* @param array $values
329		* @param string $sessionKey
330		* @return void
331		*/
332		protected function saveRelatedOptionValues(Option &$option, array $values, $sessionKey)
333		{
334		foreach ($values as $index => $value) {
335		$model = array_key_exists('id', $value) && $value['id'] !== null
336		? OptionValue::firstOrNew(['id' => $value['id']])
337		: new OptionValue;
338
339		$model->fill($value);
340		$model->sort_order = $index;
341		$model->save();
342
343		$option->values()->add($model, $sessionKey);
344		}
345		}
346
347		/**
348		* Left joins a subquery containing the product price.
349		*
350		* @param \October\Rain\Database\Builder $query
351		* @return \October\Rain\Database\Builder
352		*/
353		public function scopeJoinPrice(Builder $query)
354		{
355		$alias = 'prices';
356		$grammar = $query->getQuery()->getGrammar();
357
358		$subquery = Price::isActive()
359		->addselect('bedard_shop_prices.product_id')
360		->selectRaw('MIN('.$grammar->wrap('bedard_shop_prices.price').') as '.$grammar->wrap('price'))
361		->groupBy('bedard_shop_prices.product_id');
362
363		return $query
364		->addSelect($alias.'.price')
365		->joinSubquery($subquery, $alias, 'bedard_shop_products.id', '=', $alias.'.product_id');
366		}
367
368		/**
369		* Set the plain text description_html.
370		*
371		* @return void
372		*/
373		protected function setPlainDescription()
374		{
375		$this->description_plain = strip_tags($this->description_html);
376		}
377
378		/**
379		* Sync the inherited categories of all products.
380		*
381		* @return void
382		*/
383		public static function syncAllInheritedCategories()
384		{
385		Queue::push(function ($job) {
386		$data = [];
387		$products = Product::with('categories')->get();
388		$categoryTree = Category::getParentCategoryIds();
389
390		foreach ($products as $product) {
391		$inheritedCategoryIds = [];
392		foreach ($product->categories as $category) {
393		if (array_key_exists($category->id, $categoryTree)) {
394		$inheritedCategoryIds = array_merge($inheritedCategoryIds, $categoryTree[$category->id]);
395		}
396		}
397
398		foreach (array_unique($inheritedCategoryIds) as $categoryId) {
399		$data[] = [
400		'category_id' => $categoryId,
401		'product_id' => $product->id,
402		'is_inherited' => 1,
403		];
404		}
405		}
406
407		DB::table('bedard_shop_category_product')->whereIsInherited(1)->delete();
408		DB::table('bedard_shop_category_product')->insert($data);
409		Discount::syncAllPrices();
410
411		$job->delete();
412		});
413		}
414
415		/**
416		* Sync a product with it's inherited categories.
417		*
418		* @return void
419		*/
420		public function syncInheritedCategories()
421		{
422		$data = [];
423		$categoryIds = $this->categories()->lists('id');
424		$parentIds = Category::isParentOf($categoryIds)->lists('id');
425		foreach ($parentIds as $parentId) {
426		$data[] = [
427		'category_id' => $parentId,
428		'product_id' => $this->id,
429		'is_inherited' => true,
430		];
431		}
432
433		DB::table('bedard_shop_category_product')->whereProductId($this->id)->whereIsInherited(1)->delete();
434		DB::table('bedard_shop_category_product')->insert($data);
435
436		$categoryScope = array_merge($categoryIds, $parentIds);
437		Discount::syncProductPrice($this, $categoryScope);
438		}
439
440		/**
441		* Validate inventories.
442		*
443		* @throws \October\Rain\Database\ModelException
444		* @return void
445		*/
446	View Code Duplication	protected function validateInventories()
		1 ignored issue – show Duplication introduced 2016-11-04 13:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
447		{
448		if (! is_array($this->optionsInventories) \|\|
449		! is_array($this->optionsInventories['options'])) {
450		return;
451		}
452
453		$takenValueCombinations = [];
454		foreach ($this->optionsInventories['inventories'] as $inventory) {
455		// validate the inventory
456		$model = new Inventory($inventory);
457		$model->validate();
458
459		// validate that the value combinations are unique
460		sort($inventory['valueIds']);
461		$valueCombination = json_encode($inventory['valueIds']);
462
463		if (in_array($valueCombination, $takenValueCombinations)) {
464		Flash::error(Lang::get('bedard.shop::lang.products.form.duplicate_inventories_error'));
465		throw new ModelException($this);
466		}
467
468		$takenValueCombinations[] = $valueCombination;
469		}
470		}
471
472		/**
473		* Validate options.
474		*
475		* @throws \October\Rain\Database\ModelException
476		* @return void
477		*/
478	View Code Duplication	protected function validateOptions()
		1 ignored issue – show Duplication introduced 2016-11-04 13:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
479		{
480		if (! is_array($this->optionsInventories) \|\|
481		! is_array($this->optionsInventories['options'])) {
482		return;
483		}
484
485		$names = [];
486		foreach ($this->optionsInventories['options'] as $option) {
487		// validate the option
488		$model = new Option($option);
489		$model->validate();
490
491		// validate that names are unique
492		$name = strtolower(trim($option['name']));
493
494		if (in_array($name, $names)) {
495		Flash::error(Lang::get('bedard.shop::lang.products.form.duplicate_options_error'));
496		throw new ModelException($this);
497		}
498
499		$names[] = $name;
500		}
501		}
502		}
503

scottbedard / oc-shop-plugin

Push — master ( 8a92d6...46e7ad )

Product::saveRelatedOptions() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like