StartEndable - Code Metrics - Inspection of "Beginning to set up promotion forms" - scottbedard/oc-shop-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 20c7c7...fa6eea )

by Scott

created 2016-12-15 13:34 UTC

StartEndable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	0
dl	0
loc	32
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	bootStartEndable()	0	8	1
A	validateStartEndDates()	0	10	4

<?php namespace Bedard\Shop\Traits;

use Flash;
use Lang;
use October\Rain\Database\ModelException;

trait StartEndable
{
    /**
     * Boot the startendable trait for this model.
     *
     * @return void
     */
    public static function bootStartEndable()
    {
        static::extend(function($model) {
            $model->bindEvent('model.afterValidate', function() use ($model) {
                $model->validateStartEndDates();
            });
        });
    }

    /**
     * Ensure the start and end dates are valid.
     *
     * @return void
     */
    public function validateStartEndDates()
    {
        // Start date must be after the end date
        if ($this->start_at !== null &&
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->end_at !== null &&
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->start_at >= $this->end_at) {
            Flash::error(Lang::get('bedard.shop::lang.traits.startendable.start_at_invalid'));
            throw new ModelException($this);
        }
    }
}


1			<?php namespace Bedard\Shop\Traits;
2
3			use Flash;
4			use Lang;
5			use October\Rain\Database\ModelException;
6
7			trait StartEndable
8			{
9			/**
10			* Boot the startendable trait for this model.
11			*
12			* @return void
13			*/
14			public static function bootStartEndable()
15			{
16			static::extend(function($model) {
17			$model->bindEvent('model.afterValidate', function() use ($model) {
18			$model->validateStartEndDates();
19			});
20			});
21			}
22
23			/**
24			* Ensure the start and end dates are valid.
25			*
26			* @return void
27			*/
28			public function validateStartEndDates()
29			{
30			// Start date must be after the end date
31			if ($this->start_at !== null &&
			0 ignored issues – show Bug introduced 2016-12-15 13:36 UTC by Report Bug Copy Issue Report The property `start_at` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32			$this->end_at !== null &&
			0 ignored issues – show Bug introduced 2016-12-15 13:36 UTC by Report Bug Copy Issue Report The property `end_at` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33			$this->start_at >= $this->end_at) {
34			Flash::error(Lang::get('bedard.shop::lang.traits.startendable.start_at_invalid'));
35			throw new ModelException($this);
36			}
37			}
38			}
39

scottbedard / oc-shop-plugin

Push — master ( 20c7c7...fa6eea )

StartEndable A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like