Cart - Code Metrics - Inspection of "Add endpoint for determining if cart exists" - scottbedard/oc-shop-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bb1191...96b974 )

by Scott

created 2016-11-30 04:22 UTC

Cart A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	9
c	1
b	0
f	0
lcom	0
cbo	2
dl	0
loc	70
rs	10

4 Methods

Rating	Name	Size	Complexity
A	add()	10	2
A	exists()	10	3
A	index()	10	2
A	store()	11	2

<?php namespace Bedard\Shop\Api;

use Bedard\Shop\Classes\ApiController;
use Bedard\Shop\Repositories\CartRepository;
use Exception;
use Log;

class Cart extends ApiController
{
    /**
     * Add an inventory to the cart.
     *
     * @param CartRepository $repository
     */
    public function add(CartRepository $repository)
    {
        try {

            // @todo
        } catch (Exception $e) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            Log::error($e->getMessage());

            abort(500, $e->getMessage());
        }
    }

    /**
     * Determine if a cart exists or not.
     *
     * @param  CartRepository $repository
     * @return bool
     */
    public function exists(CartRepository $repository)
    {
        try {
            return $repository->exists() ? 'true' : 'false';
        } catch (Exception $e) {
            Log::error($e->getMessage());

            abort(500, $e->getMessage());
        }
    }

    /**
     * Show the current cart.
     *
     * @param  \Bedard\Shop\Repositories\CartRepository     $repository
     * @return \Bedard\Shop\Models\Cart
     */
    public function index(CartRepository $repository)
    {
        try {
            return $repository->loadCart();
        } catch (Exception $e) {
            Log::error($e->getMessage());

            abort(500, $e->getMessage());
        }
    }

    /**
     * Create a new cart.
     *
     * @param  \Bedard\Shop\Repositories\CartRepository     $repository
     * @return \Bedard\Shop\Models\Cart
     */
    public function store(CartRepository $repository)
    {
        try {


            // @todo
        } catch (Exception $e) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            Log::error($e->getMessage());

            abort(500, $e->getMessage());
        }
    }
}


1			<?php namespace Bedard\Shop\Api;
2
3			use Bedard\Shop\Classes\ApiController;
4			use Bedard\Shop\Repositories\CartRepository;
5			use Exception;
6			use Log;
7
8			class Cart extends ApiController
9			{
10			/**
11			* Add an inventory to the cart.
12			*
13			* @param CartRepository $repository
14			*/
15			public function add(CartRepository $repository)
16			{
17			try {
			0 ignored issues – show Unused Code introduced 2016-11-28 15:48 UTC by Report Bug Copy Issue Report This `try` statement is empty and can be removed. This check looks for `try` blocks that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. If there is nothing in the `try` then the `catch` block can never be executed either. Thus, these `try` statements can be removed completely. Loading history...
18			// @todo
19			} catch (Exception $e) {
			0 ignored issues – show Unused Code introduced 2016-11-28 15:48 UTC by Report Bug Copy Issue Report `catch (\Exception $e) { ...0, $e->getMessage()); }` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
20			Log::error($e->getMessage());
21
22			abort(500, $e->getMessage());
23			}
24			}
25
26			/**
27			* Determine if a cart exists or not.
28			*
29			* @param CartRepository $repository
30			* @return bool
31			*/
32			public function exists(CartRepository $repository)
33			{
34			try {
35			return $repository->exists() ? 'true' : 'false';
36			} catch (Exception $e) {
37			Log::error($e->getMessage());
38
39			abort(500, $e->getMessage());
40			}
41			}
42
43			/**
44			* Show the current cart.
45			*
46			* @param \Bedard\Shop\Repositories\CartRepository $repository
47			* @return \Bedard\Shop\Models\Cart
48			*/
49			public function index(CartRepository $repository)
50			{
51			try {
52			return $repository->loadCart();
53			} catch (Exception $e) {
54			Log::error($e->getMessage());
55
56			abort(500, $e->getMessage());
57			}
58			}
59
60			/**
61			* Create a new cart.
62			*
63			* @param \Bedard\Shop\Repositories\CartRepository $repository
64			* @return \Bedard\Shop\Models\Cart
65			*/
66			public function store(CartRepository $repository)
67			{
68			try {
			0 ignored issues – show Unused Code introduced 2016-11-30 04:24 UTC by Report Bug Copy Issue Report This `try` statement is empty and can be removed. This check looks for `try` blocks that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. If there is nothing in the `try` then the `catch` block can never be executed either. Thus, these `try` statements can be removed completely. Loading history...
69
70			// @todo
71			} catch (Exception $e) {
			0 ignored issues – show Unused Code introduced 2016-11-26 10:01 UTC by Report Bug Copy Issue Report `catch (\Exception $e) { ...0, $e->getMessage()); }` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
72			Log::error($e->getMessage());
73
74			abort(500, $e->getMessage());
75			}
76			}
77			}
78

scottbedard / oc-shop-plugin

Push — master ( bb1191...96b974 )

Cart A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like