Address::scopeIsBilling() - Code Metrics - Inspection of "Only allow one primary address of each type" - scottbedard/oc-shop-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 56bbda...d5b9cf )

by Scott

created 2016-12-22 15:32 UTC

Address::scopeIsBilling() A

↳ Parent: Address

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php namespace Bedard\Shop\Models;

use Model;

/**
 * Address Model.
 */
class Address extends Model
{
    /**
     * @var string The database table used by the model.
     */
    public $table = 'bedard_shop_addresses';

    /**
     * @var array Default attributes
     */
    public $attributes = [
        'additional_data' => '',
    ];

    /**
     * @var array Attribute casting
     */
    protected $casts = [
        'is_billing' => 'boolean',
        'is_primary' => 'boolean',
        'is_shipping' => 'boolean',
    ];


    /**
     * @var array Jsonable fields
     */
    protected $jsonable = [
        'additional_data',
    ];

    /**
     * @var array Guarded fields
     */
    protected $guarded = ['*'];

    /**
     * @var array Fillable fields
     */
    protected $fillable = [
        'additional_data',
        'city',
        'country',
        'customer_id',
        'is_billing',
        'is_primary',
        'is_shipping',
        'line_1',
        'line_2',
        'line_3',
        'postcode',
        'province',
    ];

    /**
     * @var array Relations
     */
    public $belongsTo = [
        'customer' => [
            'Bedard\Shop\Models\Customer',
        ],
    ];

    /**
     * After save.
     *
     * @return void
     */
    public function afterSave()
    {
        $this->updatePrimaryAddresses();
    }

    /**
     * Select shipping addresses.
     *
     * @param  \October\Rain\Database\Builder   $query
     * @return \October\Rain\Database\Builder
     */
    public function scopeIsShipping($query)
    {
        return $query->whereIsShipping(true);
    }

    /**
     * Select billing addresses.
     *
     * @param  \October\Rain\Database\Builder   $query
     * @return \October\Rain\Database\Builder
     */
    public function scopeIsBilling($query)
    {
        return $query->whereIsBilling(true);
    }

    /**
     * Select primary addresses.
     *
     * @param  \October\Rain\Database\Builder   $query
     * @return \October\Rain\Database\Builder
     */
    public function scopeIsPrimary($query)
    {
        return $query->whereIsPrimary(true);
    }

    /**
     * Ensure that only one billing and shipping address may be primary.
     *
     * @return void
     */
    protected function updatePrimaryAddresses()
    {
        if (! $this->customer_id) {
            return;
        }

        $query = self::whereCustomerId($this->customer_id)
            ->where('id', '<>', $this->id)
            ->isPrimary();

        if ($this->is_shipping && $this->is_primary) {
            $shipping = $query->isShipping()->update(['is_primary' => false]);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        if ($this->is_billing && $this->is_primary) {
            $shipping = $query->isBilling()->update(['is_primary' => false]);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
    }
}


1			<?php namespace Bedard\Shop\Models;
2
3			use Model;
4
5			/**
6			* Address Model.
7			*/
8			class Address extends Model
9			{
10			/**
11			* @var string The database table used by the model.
12			*/
13			public $table = 'bedard_shop_addresses';
14
15			/**
16			* @var array Default attributes
17			*/
18			public $attributes = [
19			'additional_data' => '',
20			];
21
22			/**
23			* @var array Attribute casting
24			*/
25			protected $casts = [
26			'is_billing' => 'boolean',
27			'is_primary' => 'boolean',
28			'is_shipping' => 'boolean',
29			];
30
31
32			/**
33			* @var array Jsonable fields
34			*/
35			protected $jsonable = [
36			'additional_data',
37			];
38
39			/**
40			* @var array Guarded fields
41			*/
42			protected $guarded = ['*'];
43
44			/**
45			* @var array Fillable fields
46			*/
47			protected $fillable = [
48			'additional_data',
49			'city',
50			'country',
51			'customer_id',
52			'is_billing',
53			'is_primary',
54			'is_shipping',
55			'line_1',
56			'line_2',
57			'line_3',
58			'postcode',
59			'province',
60			];
61
62			/**
63			* @var array Relations
64			*/
65			public $belongsTo = [
66			'customer' => [
67			'Bedard\Shop\Models\Customer',
68			],
69			];
70
71			/**
72			* After save.
73			*
74			* @return void
75			*/
76			public function afterSave()
77			{
78			$this->updatePrimaryAddresses();
79			}
80
81			/**
82			* Select shipping addresses.
83			*
84			* @param \October\Rain\Database\Builder $query
85			* @return \October\Rain\Database\Builder
86			*/
87			public function scopeIsShipping($query)
88			{
89			return $query->whereIsShipping(true);
90			}
91
92			/**
93			* Select billing addresses.
94			*
95			* @param \October\Rain\Database\Builder $query
96			* @return \October\Rain\Database\Builder
97			*/
98			public function scopeIsBilling($query)
99			{
100			return $query->whereIsBilling(true);
101			}
102
103			/**
104			* Select primary addresses.
105			*
106			* @param \October\Rain\Database\Builder $query
107			* @return \October\Rain\Database\Builder
108			*/
109			public function scopeIsPrimary($query)
110			{
111			return $query->whereIsPrimary(true);
112			}
113
114			/**
115			* Ensure that only one billing and shipping address may be primary.
116			*
117			* @return void
118			*/
119			protected function updatePrimaryAddresses()
120			{
121			if (! $this->customer_id) {
122			return;
123			}
124
125			$query = self::whereCustomerId($this->customer_id)
126			->where('id', '<>', $this->id)
127			->isPrimary();
128
129			if ($this->is_shipping && $this->is_primary) {
130			$shipping = $query->isShipping()->update(['is_primary' => false]);
			0 ignored issues – show Unused Code introduced 2016-12-22 15:34 UTC by Report Bug Copy Issue Report `$shipping` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
131			}
132
133			if ($this->is_billing && $this->is_primary) {
134			$shipping = $query->isBilling()->update(['is_primary' => false]);
			0 ignored issues – show Unused Code introduced 2016-12-22 15:34 UTC by Report Bug Copy Issue Report `$shipping` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
135			}
136			}
137			}
138

scottbedard / oc-shop-plugin

Push — master ( 56bbda...d5b9cf )

Address::scopeIsBilling() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like