AdWordsService::getSearchParameters() - Code Metrics - Inspection of "added basic readme" - schulzefelix/laravel-adwords-targeting-idea-service - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e7e845...1ac605 )

by Felix

created 2017-06-04 21:35 UTC

AdWordsService::getSearchParameters() C

↳ Parent: AdWordsService

Complexity

Conditions	7
Paths	20

Size

Total Lines	51
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	51
rs	6.9743
c	0
b	0
f	0
cc	7
eloc	33
nc	20
nop	5

How to fix Long Method

<?php

namespace SchulzeFelix\AdWords;

use Google\AdsApi\AdWords\v201705\cm\ApiException;
use Google\AdsApi\AdWords\v201705\cm\Language;
use Google\AdsApi\AdWords\v201705\cm\Location;
use Google\AdsApi\AdWords\v201705\cm\NetworkSetting;
use Google\AdsApi\AdWords\v201705\cm\Paging;
use Google\AdsApi\AdWords\v201705\cm\RateExceededError;
use Google\AdsApi\AdWords\v201705\o\AttributeType;
use Google\AdsApi\AdWords\v201705\o\IdeaTextFilterSearchParameter;
use Google\AdsApi\AdWords\v201705\o\IdeaType;
use Google\AdsApi\AdWords\v201705\o\LanguageSearchParameter;
use Google\AdsApi\AdWords\v201705\o\LocationSearchParameter;
use Google\AdsApi\AdWords\v201705\o\NetworkSearchParameter;
use Google\AdsApi\AdWords\v201705\o\RelatedToQuerySearchParameter;
use Google\AdsApi\AdWords\v201705\o\TargetingIdeaSelector;
use Google\AdsApi\AdWords\v201705\o\TargetingIdeaService;

class AdWordsService
{
    const PAGE_LIMIT = 1000;

    const MAX_RETRIES = 10;

    /** @var TargetingIdeaService */
    protected $targetingIdeaService;

    public function __construct(TargetingIdeaService $targetingIdeaService)
    {
        $this->targetingIdeaService = $targetingIdeaService;
    }

    /**
     * Query the Google AdWords TargetingIdeaService with given parameters.
     *
     * @param array $keywords
     * @param $requestType
     * @param $language
     * @param $location
     * @param bool $withTargetedMonthlySearches
     * @param $included
     * @param $excluded
     *
     * @throws ApiException
     *
     * @return \Google\AdsApi\AdWords\v201705\o\TargetingIdeaPage
     */
    public function performQuery(array $keywords, $requestType, $language = null, $location = null, $withTargetedMonthlySearches = false, $included = null, $excluded = null)
    {

        // Create selector.
        $selector = new TargetingIdeaSelector();
        $selector->setRequestType($requestType);
        $selector->setIdeaType(IdeaType::KEYWORD);
        $selector->setRequestedAttributeTypes($this->getRequestedAttributeTypes($withTargetedMonthlySearches));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $selector->setPaging(new Paging(0, self::PAGE_LIMIT));
        $selector->setSearchParameters($this->getSearchParameters($keywords, $language, $location, $included, $excluded));

        $currentTry = 0;

        while (true) {
            try {
                $results = $this->targetingIdeaService->get($selector);

                return $results;
            } catch (ApiException $exception) {
                $error = $exception->getErrors()[0];
                if ($error instanceof RateExceededError and ++$currentTry < self::MAX_RETRIES) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                    sleep($error->getRetryAfterSeconds());
                } else {
                    throw $exception;
                }
            }
        }
    }

    /**
     * @return TargetingIdeaService
     */
    public function getTargetingIdeaService()
    {
        return $this->targetingIdeaService;
    }

    /**
     * @param bool $withTargetedMonthlySearches
     *
     * @return array
     */
    private function getRequestedAttributeTypes($withTargetedMonthlySearches = false)
    {
        if ($withTargetedMonthlySearches) {
            return [
                AttributeType::KEYWORD_TEXT,
                AttributeType::SEARCH_VOLUME,
                AttributeType::COMPETITION,
                AttributeType::AVERAGE_CPC,
                AttributeType::TARGETED_MONTHLY_SEARCHES,
            ];
        }

        return [
            AttributeType::KEYWORD_TEXT,
            AttributeType::SEARCH_VOLUME,
            AttributeType::COMPETITION,
            AttributeType::AVERAGE_CPC,
        ];
    }

    /**
     * @param array $keywords
     * @param $languageId
     * @param $locationId
     * @param $included
     * @param $excluded
     *
     * @return array
     */
    private function getSearchParameters(array $keywords, $languageId, $locationId, $included, $excluded)
    {
        $searchParameters = [];

        //Create Language Parameter
        if (!is_null($languageId)) {
            $languageParameter = new LanguageSearchParameter();
            $language = new Language();
            $language->setId($languageId);
            $languageParameter->setLanguages([$language]);
            $searchParameters[] = $languageParameter;
        }

        //Create Location Parameter
        if (!is_null($locationId)) {
            $locationParameter = new LocationSearchParameter();
            $location = new Location();
            $location->setId($locationId);
            $locationParameter->setLocations([$location]);
            $searchParameters[] = $locationParameter;
        }

        //Network Settings
        $networkSetting = new NetworkSetting();
        $networkSetting->setTargetGoogleSearch(true);
        $networkSetting->setTargetSearchNetwork(false);
        $networkSetting->setTargetContentNetwork(false);
        $networkSetting->setTargetPartnerSearchNetwork(false);

        $networkSearchParameter = new NetworkSearchParameter();
        $networkSearchParameter->setNetworkSetting($networkSetting);
        $searchParameters[] = $networkSearchParameter;

        // Create related to query search parameter.
        $relatedToQuerySearchParameter = new RelatedToQuerySearchParameter();
        $relatedToQuerySearchParameter->setQueries($keywords);
        $searchParameters[] = $relatedToQuerySearchParameter;

        if(!is_null($included) or !is_null($excluded)){
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $ideaTextFilterSearchParameter = new IdeaTextFilterSearchParameter();
            if(!is_null($included)) {
                $ideaTextFilterSearchParameter->setIncluded($included);
            }
            if(!is_null($excluded)) {
                $ideaTextFilterSearchParameter->setExcluded($excluded);
            }
            $searchParameters[] = $ideaTextFilterSearchParameter;
        }

        return $searchParameters;
    }
}


Push — master ( e7e845...1ac605 )

AdWordsService::getSearchParameters() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

schulzefelix / laravel-adwords-targeting-idea-service

Push — master ( e7e845...1ac605 )

AdWordsService::getSearchParameters() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like