Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | class MigrateResetCommand extends Command |
||
11 | { |
||
12 | use DatabaseAwareCommandTrait; |
||
13 | use MigrationAwareCommandTrait; |
||
14 | |||
15 | public static $name = 'migrate:reset'; |
||
16 | |||
17 | /** |
||
18 | * @var Migrator |
||
19 | */ |
||
20 | protected $migrator; |
||
21 | |||
22 | /** |
||
23 | * @var string |
||
24 | */ |
||
25 | protected $migrationsPath; |
||
26 | |||
27 | public function __construct( |
||
37 | |||
38 | public function run() |
||
52 | |||
53 | View Code Duplication | public static function register(Cli $cli) |
|
63 | } |
||
64 |
Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects.