Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | class MigrateInstallCommand extends Command |
||
11 | { |
||
12 | use DatabaseAwareCommandTrait; |
||
13 | use MigrationAwareCommandTrait; |
||
14 | |||
15 | public static $name = 'migrate:install'; |
||
16 | protected $repository; |
||
17 | |||
18 | public function __construct( |
||
26 | |||
27 | public function run() |
||
40 | |||
41 | View Code Duplication | public static function register(Cli $cli) |
|
50 | } |
||
51 |
Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects.