Passed
Pull Request — master (#1487)
by Martin Poirier
03:02
created
src/Metadata/Driver/DoctrinePHPCRTypeDriver.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
             && ($fieldType = $this->normalizeFieldType($typeOfFiled))
30 30
         ) {
31 31
             $field = $doctrineMetadata->getFieldMapping($propertyName);
32
-            if (!empty($field['multivalue'])) {
32
+            if ( ! empty($field['multivalue'])) {
33 33
                 $fieldType = 'array';
34 34
             }
35 35
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
                 return;
46 46
             }
47 47
 
48
-            if (!$doctrineMetadata->isSingleValuedAssociation($propertyName)) {
48
+            if ( ! $doctrineMetadata->isSingleValuedAssociation($propertyName)) {
49 49
                 $targetEntity = sprintf('ArrayCollection<%s>', $targetEntity);
50 50
             }
51 51
 
Please login to merge, or discard this patch.
src/Metadata/Driver/XmlDriver.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -54,14 +54,14 @@  discard block
 block discarded – undo
54 54
         }
55 55
 
56 56
         $metadata = new ClassMetadata($name = $class->name);
57
-        if (!$elems = $elem->xpath("./class[@name = '" . $name . "']")) {
57
+        if ( ! $elems = $elem->xpath("./class[@name = '".$name."']")) {
58 58
             throw new InvalidMetadataException(sprintf('Could not find class %s inside XML element.', $name));
59 59
         }
60 60
 
61 61
         $elem = reset($elems);
62 62
 
63 63
         $metadata->fileResources[] = $path;
64
-        $fileResource =  $class->getFilename();
64
+        $fileResource = $class->getFilename();
65 65
         if (false !== $fileResource) {
66 66
             $metadata->fileResources[] = $fileResource;
67 67
         }
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         $discriminatorFieldName = (string) $elem->attributes()->{'discriminator-field-name'};
101 101
         $discriminatorMap = [];
102 102
         foreach ($elem->xpath('./discriminator-class') as $entry) {
103
-            if (!isset($entry->attributes()->value)) {
103
+            if ( ! isset($entry->attributes()->value)) {
104 104
                 throw new InvalidMetadataException('Each discriminator-class element must have a "value" attribute.');
105 105
             }
106 106
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 
110 110
         if ('true' === (string) $elem->attributes()->{'discriminator-disabled'}) {
111 111
             $metadata->discriminatorDisabled = true;
112
-        } elseif (!empty($discriminatorFieldName) || !empty($discriminatorMap)) {
112
+        } elseif ( ! empty($discriminatorFieldName) || ! empty($discriminatorMap)) {
113 113
             $discriminatorGroups = [];
114 114
             foreach ($elem->xpath('./discriminator-groups/group') as $entry) {
115 115
                 $discriminatorGroups[] = (string) $entry;
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
         }
120 120
 
121 121
         foreach ($elem->xpath('./xml-namespace') as $xmlNamespace) {
122
-            if (!isset($xmlNamespace->attributes()->uri)) {
122
+            if ( ! isset($xmlNamespace->attributes()->uri)) {
123 123
                 throw new InvalidMetadataException('The prefix attribute must be set for all xml-namespace elements.');
124 124
             }
125 125
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
                     $this->parseExpression((string) $method->attributes()->expression)
155 155
                 );
156 156
             } else {
157
-                if (!isset($method->attributes()->method)) {
157
+                if ( ! isset($method->attributes()->method)) {
158 158
                     throw new InvalidMetadataException('The method attribute must be set for all virtual-property elements.');
159 159
                 }
160 160
 
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
             $propertiesNodes[] = $method;
166 166
         }
167 167
 
168
-        if (!$excludeAll) {
168
+        if ( ! $excludeAll) {
169 169
             foreach ($class->getProperties() as $property) {
170 170
                 if ($property->class !== $name || (isset($property->info) && $property->info['class'] !== $name)) {
171 171
                     continue;
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
                 $pName = $property->getName();
175 175
                 $propertiesMetadata[] = new PropertyMetadata($name, $pName);
176 176
 
177
-                $pElems = $elem->xpath("./property[@name = '" . $pName . "']");
177
+                $pElems = $elem->xpath("./property[@name = '".$pName."']");
178 178
                 $propertiesNodes[] = $pElems ? reset($pElems) : null;
179 179
             }
180 180
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
                     || isset($propertiesNodes[$propertyKey]);
186 186
 
187 187
                 $pElem = $propertiesNodes[$propertyKey];
188
-                if (!empty($pElem)) {
188
+                if ( ! empty($pElem)) {
189 189
                     if (null !== $exclude = $pElem->attributes()->exclude) {
190 190
                         $isExclude = 'true' === strtolower((string) $exclude);
191 191
                     }
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
                     }
208 208
 
209 209
                     if (null !== $excludeIf = $pElem->attributes()->{'expose-if'}) {
210
-                        $pMetadata->excludeIf = $this->parseExpression('!(' . (string) $excludeIf . ')');
210
+                        $pMetadata->excludeIf = $this->parseExpression('!('.(string) $excludeIf.')');
211 211
                         $isExpose = true;
212 212
                     }
213 213
 
@@ -335,16 +335,16 @@  discard block
 block discarded – undo
335 335
                     $metadata->isMap = $metadata->isMap || PropertyMetadata::isCollectionMap($pMetadata->type);
336 336
                 }
337 337
 
338
-                if (!$pMetadata->serializedName) {
338
+                if ( ! $pMetadata->serializedName) {
339 339
                     $pMetadata->serializedName = $this->namingStrategy->translateName($pMetadata);
340 340
                 }
341 341
 
342
-                if (!empty($pElem) && null !== $name = $pElem->attributes()->name) {
342
+                if ( ! empty($pElem) && null !== $name = $pElem->attributes()->name) {
343 343
                     $pMetadata->name = (string) $name;
344 344
                 }
345 345
 
346 346
                 if (
347
-                    (ExclusionPolicy::NONE === (string) $exclusionPolicy && !$isExclude)
347
+                    (ExclusionPolicy::NONE === (string) $exclusionPolicy && ! $isExclude)
348 348
                     || (ExclusionPolicy::ALL === (string) $exclusionPolicy && $isExpose)
349 349
                 ) {
350 350
                     $metadata->addPropertyMetadata($pMetadata);
@@ -353,11 +353,11 @@  discard block
 block discarded – undo
353 353
         }
354 354
 
355 355
         foreach ($elem->xpath('./callback-method') as $method) {
356
-            if (!isset($method->attributes()->type)) {
356
+            if ( ! isset($method->attributes()->type)) {
357 357
                 throw new InvalidMetadataException('The type attribute must be set for all callback-method elements.');
358 358
             }
359 359
 
360
-            if (!isset($method->attributes()->name)) {
360
+            if ( ! isset($method->attributes()->name)) {
361 361
                 throw new InvalidMetadataException('The name attribute must be set for all callback-method elements.');
362 362
             }
363 363
 
@@ -375,11 +375,11 @@  discard block
 block discarded – undo
375 375
                     break;
376 376
 
377 377
                 case 'handler':
378
-                    if (!isset($method->attributes()->format)) {
378
+                    if ( ! isset($method->attributes()->format)) {
379 379
                         throw new InvalidMetadataException('The format attribute must be set for "handler" callback methods.');
380 380
                     }
381 381
 
382
-                    if (!isset($method->attributes()->direction)) {
382
+                    if ( ! isset($method->attributes()->direction)) {
383 383
                         throw new InvalidMetadataException('The direction attribute must be set for "handler" callback methods.');
384 384
                     }
385 385
 
Please login to merge, or discard this patch.
src/Metadata/Driver/AbstractDoctrineTypeDriver.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         \assert($classMetadata instanceof ClassMetadata);
84 84
 
85 85
         // Abort if the given class is not a mapped entity
86
-        if (!$doctrineMetadata = $this->tryLoadingDoctrineMetadata($class->name)) {
86
+        if ( ! $doctrineMetadata = $this->tryLoadingDoctrineMetadata($class->name)) {
87 87
             return $classMetadata;
88 88
         }
89 89
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 
130 130
     protected function tryLoadingDoctrineMetadata(string $className): ?DoctrineClassMetadata
131 131
     {
132
-        if (!$manager = $this->registry->getManagerForClass($className)) {
132
+        if ( ! $manager = $this->registry->getManagerForClass($className)) {
133 133
             return null;
134 134
         }
135 135
 
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 
143 143
     protected function normalizeFieldType(string $type): ?string
144 144
     {
145
-        if (!isset($this->fieldMapping[$type])) {
145
+        if ( ! isset($this->fieldMapping[$type])) {
146 146
             return null;
147 147
         }
148 148
 
Please login to merge, or discard this patch.
src/SerializationContext.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      */
65 65
     public function startVisiting($object): void
66 66
     {
67
-        if (!\is_object($object)) {
67
+        if ( ! \is_object($object)) {
68 68
             return;
69 69
         }
70 70
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
      */
78 78
     public function stopVisiting($object): void
79 79
     {
80
-        if (!\is_object($object)) {
80
+        if ( ! \is_object($object)) {
81 81
             return;
82 82
         }
83 83
 
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      */
95 95
     public function isVisiting($object): bool
96 96
     {
97
-        if (!\is_object($object)) {
97
+        if ( ! \is_object($object)) {
98 98
             return false;
99 99
         }
100 100
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
             $path[] = \get_class($obj);
109 109
         }
110 110
 
111
-        if (!$path) {
111
+        if ( ! $path) {
112 112
             return null;
113 113
         }
114 114
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 
128 128
     public function getObject(): ?object
129 129
     {
130
-        return !$this->visitingStack->isEmpty() ? $this->visitingStack->top() : null;
130
+        return ! $this->visitingStack->isEmpty() ? $this->visitingStack->top() : null;
131 131
     }
132 132
 
133 133
     public function getVisitingStack(): \SplStack
Please login to merge, or discard this patch.
src/Naming/CamelCaseNamingStrategy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 
32 32
     public function translateName(PropertyMetadata $property): string
33 33
     {
34
-        $name = preg_replace('/[A-Z]+/', $this->separator . '\\0', $property->name);
34
+        $name = preg_replace('/[A-Z]+/', $this->separator.'\\0', $property->name);
35 35
 
36 36
         if ($this->lowerCase) {
37 37
             return strtolower($name);
Please login to merge, or discard this patch.
src/Accessor/DefaultAccessorStrategy.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
         $accessor = $this->readAccessors[$metadata->class] ?? null;
87 87
         if (null === $accessor) {
88
-            $accessor = \Closure::bind(static function ($o, $name) {
88
+            $accessor = \Closure::bind(static function($o, $name) {
89 89
                 return $o->$name;
90 90
             }, null, $metadata->class);
91 91
             $this->readAccessors[$metadata->class] = $accessor;
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 
125 125
         $accessor = $this->writeAccessors[$metadata->class] ?? null;
126 126
         if (null === $accessor) {
127
-            $accessor = \Closure::bind(static function ($o, $name, $value): void {
127
+            $accessor = \Closure::bind(static function($o, $name, $value): void {
128 128
                 $o->$name = $value;
129 129
             }, null, $metadata->class);
130 130
             $this->writeAccessors[$metadata->class] = $accessor;
Please login to merge, or discard this patch.
src/EventDispatcher/EventDispatcher.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 
31 31
     public static function getDefaultMethodName(string $eventName): string
32 32
     {
33
-        return 'on' . str_replace(['_', '.'], '', $eventName);
33
+        return 'on'.str_replace(['_', '.'], '', $eventName);
34 34
     }
35 35
 
36 36
     /**
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     public function addSubscriber(EventSubscriberInterface $subscriber): void
57 57
     {
58 58
         foreach ($subscriber->getSubscribedEvents() as $eventData) {
59
-            if (!isset($eventData['event'])) {
59
+            if ( ! isset($eventData['event'])) {
60 60
                 throw new InvalidArgumentException(sprintf('Each event must have a "event" key.'));
61 61
             }
62 62
 
@@ -71,33 +71,33 @@  discard block
 block discarded – undo
71 71
 
72 72
     public function hasListeners(string $eventName, string $class, string $format): bool
73 73
     {
74
-        if (!isset($this->listeners[$eventName])) {
74
+        if ( ! isset($this->listeners[$eventName])) {
75 75
             return false;
76 76
         }
77 77
 
78
-        if (!isset($this->classListeners[$eventName][$class][$format])) {
78
+        if ( ! isset($this->classListeners[$eventName][$class][$format])) {
79 79
             $this->classListeners[$eventName][$class][$format] = $this->initializeListeners($eventName, $class, $format);
80 80
         }
81 81
 
82
-        return !!$this->classListeners[$eventName][$class][$format];
82
+        return ! ! $this->classListeners[$eventName][$class][$format];
83 83
     }
84 84
 
85 85
     public function dispatch(string $eventName, string $class, string $format, Event $event): void
86 86
     {
87
-        if (!isset($this->listeners[$eventName])) {
87
+        if ( ! isset($this->listeners[$eventName])) {
88 88
             return;
89 89
         }
90 90
 
91 91
         $object = $event instanceof ObjectEvent ? $event->getObject() : null;
92 92
         $realClass = is_object($object) ? get_class($object) : '';
93
-        $objectClass = $realClass !== $class ? $realClass . $class : $class;
93
+        $objectClass = $realClass !== $class ? $realClass.$class : $class;
94 94
 
95
-        if (!isset($this->classListeners[$eventName][$objectClass][$format])) {
95
+        if ( ! isset($this->classListeners[$eventName][$objectClass][$format])) {
96 96
             $this->classListeners[$eventName][$objectClass][$format] = $this->initializeListeners($eventName, $class, $format);
97 97
         }
98 98
 
99 99
         foreach ($this->classListeners[$eventName][$objectClass][$format] as $listener) {
100
-            if (!empty($listener[3]) && !($object instanceof $listener[3])) {
100
+            if ( ! empty($listener[3]) && ! ($object instanceof $listener[3])) {
101 101
                 continue;
102 102
             }
103 103
 
Please login to merge, or discard this patch.
src/EventDispatcher/Subscriber/DoctrineProxySubscriber.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -40,14 +40,14 @@  discard block
 block discarded – undo
40 40
         // If the set type name is not an actual class, but a faked type for which a custom handler exists, we do not
41 41
         // modify it with this subscriber. Also, we forgo autoloading here as an instance of this type is already created,
42 42
         // so it must be loaded if its a real class.
43
-        $virtualType = !class_exists($type['name'], false);
43
+        $virtualType = ! class_exists($type['name'], false);
44 44
 
45 45
         if (
46 46
             $object instanceof PersistentCollection
47 47
             || $object instanceof MongoDBPersistentCollection
48 48
             || $object instanceof PHPCRPersistentCollection
49 49
         ) {
50
-            if (!$virtualType) {
50
+            if ( ! $virtualType) {
51 51
                 $event->setType('ArrayCollection');
52 52
             }
53 53
 
@@ -56,13 +56,13 @@  discard block
 block discarded – undo
56 56
 
57 57
         if (
58 58
             ($this->skipVirtualTypeInit && $virtualType) ||
59
-            (!$object instanceof Proxy && !$object instanceof LazyLoadingInterface)
59
+            ( ! $object instanceof Proxy && ! $object instanceof LazyLoadingInterface)
60 60
         ) {
61 61
             return;
62 62
         }
63 63
 
64 64
         // do not initialize the proxy if is going to be excluded by-class by some exclusion strategy
65
-        if (false === $this->initializeExcluded && !$virtualType) {
65
+        if (false === $this->initializeExcluded && ! $virtualType) {
66 66
             $context = $event->getContext();
67 67
             $exclusionStrategy = $context->getExclusionStrategy();
68 68
             $metadata = $context->getMetadataFactory()->getMetadataForClass(get_parent_class($object));
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             $object->__load();
78 78
         }
79 79
 
80
-        if (!$virtualType) {
80
+        if ( ! $virtualType) {
81 81
             $event->setType(get_parent_class($object), $type['params']);
82 82
         }
83 83
     }
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
     {
87 87
         $type = $event->getType();
88 88
         // is a virtual type? then there is no need to change the event name
89
-        if (!class_exists($type['name'], false)) {
89
+        if ( ! class_exists($type['name'], false)) {
90 90
             return;
91 91
         }
92 92
 
Please login to merge, or discard this patch.
src/Exclusion/GroupsExclusionStrategy.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -54,14 +54,14 @@  discard block
 block discarded – undo
54 54
         if ($this->nestedGroups) {
55 55
             $groups = $this->getGroupsFor($navigatorContext);
56 56
 
57
-            if (!$property->groups) {
58
-                return !in_array(self::DEFAULT_GROUP, $groups);
57
+            if ( ! $property->groups) {
58
+                return ! in_array(self::DEFAULT_GROUP, $groups);
59 59
             }
60 60
 
61 61
             return $this->shouldSkipUsingGroups($property, $groups);
62 62
         } else {
63
-            if (!$property->groups) {
64
-                return !isset($this->groups[self::DEFAULT_GROUP]);
63
+            if ( ! $property->groups) {
64
+                return ! isset($this->groups[self::DEFAULT_GROUP]);
65 65
             }
66 66
 
67 67
             foreach ($property->groups as $group) {
@@ -87,14 +87,14 @@  discard block
 block discarded – undo
87 87
 
88 88
     public function getGroupsFor(Context $navigatorContext): array
89 89
     {
90
-        if (!$this->nestedGroups) {
90
+        if ( ! $this->nestedGroups) {
91 91
             return array_keys($this->groups);
92 92
         }
93 93
 
94 94
         $paths = $navigatorContext->getCurrentPath();
95 95
         $groups = $this->groups;
96 96
         foreach ($paths as $index => $path) {
97
-            if (!array_key_exists($path, $groups)) {
97
+            if ( ! array_key_exists($path, $groups)) {
98 98
                 if ($index > 0) {
99 99
                     $groups = [self::DEFAULT_GROUP];
100 100
                 } else {
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
             }
106 106
 
107 107
             $groups = $groups[$path];
108
-            if (!array_filter($groups, 'is_string')) {
108
+            if ( ! array_filter($groups, 'is_string')) {
109 109
                 $groups += [self::DEFAULT_GROUP];
110 110
             }
111 111
         }
Please login to merge, or discard this patch.