schmittjoh / serializer

src/JMS/Serializer/XmlSerializationVisitor.php

Doc Comments +6 added lines

@@ -127,6 +127,9 @@ 
         return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string)$data);
     }
 
+    /**
+     * @param string $data
+     */
     public function visitSimpleString($data, array $type, Context $context)
     {
         if (null === $this->document) {
@@ -474,6 +477,9 @@ 
         return $this->document->createElementNS($namespace, $prefix . ':' . $tagName);
     }
 
+    /**
+     * @param string $value
+     */
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
     {
         if (null !== $namespace) {

Spacing +24 added lines, -24 removed lines

@@ -124,24 +124,24 @@ 
 
         if (null === $this->document) {
             $this->document = $this->createDocument(null, null, true);
-            $this->currentNode->appendChild($doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string)$data));
+            $this->currentNode->appendChild($doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string) $data));
 
             return;
         }
 
-        return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string)$data);
+        return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string) $data);
     }
 
     public function visitSimpleString($data, array $type, Context $context)
     {
         if (null === $this->document) {
             $this->document = $this->createDocument(null, null, true);
-            $this->currentNode->appendChild($this->document->createTextNode((string)$data));
+            $this->currentNode->appendChild($this->document->createTextNode((string) $data));
 
             return;
         }
 
-        return $this->document->createTextNode((string)$data);
+        return $this->document->createTextNode((string) $data);
     }
 
     public function visitBoolean($data, array $type, Context $context)
@@ -189,7 +189,7 @@ 
             $this->setCurrentNode($entryNode);
 
             if (null !== $keyAttributeName) {
-                $entryNode->setAttribute($keyAttributeName, (string)$k);
+                $entryNode->setAttribute($keyAttributeName, (string) $k);
             }
 
             if (null !== $node = $this->navigator->accept($v, $this->getElementType($type), $context)) {
@@ -241,7 +241,7 @@ 
             $node = $this->navigator->accept($v, $metadata->type, $context);
             $this->revertCurrentMetadata();
 
-            if (!$node instanceof \DOMCharacterData) {
+            if ( ! $node instanceof \DOMCharacterData) {
                 throw new RuntimeException(sprintf('Unsupported value for XML attribute for %s. Expected character data, but got %s.', $metadata->name, json_encode($v)));
             }
             $attributeName = $this->namingStrategy->translateName($metadata);
@@ -251,7 +251,7 @@ 
         }
 
         if (($metadata->xmlValue && $this->currentNode->childNodes->length > 0)
-            || (!$metadata->xmlValue && $this->hasValue)
+            || ( ! $metadata->xmlValue && $this->hasValue)
         ) {
             throw new RuntimeException(sprintf('If you make use of @XmlValue, all other properties in the class must have the @XmlAttribute annotation. Invalid usage detected in class %s.', $metadata->class));
         }
@@ -263,7 +263,7 @@ 
             $node = $this->navigator->accept($v, $metadata->type, $context);
             $this->revertCurrentMetadata();
 
-            if (!$node instanceof \DOMCharacterData) {
+            if ( ! $node instanceof \DOMCharacterData) {
                 throw new RuntimeException(sprintf('Unsupported value for property %s::$%s. Expected character data, but got %s.', $metadata->reflection->class, $metadata->reflection->name, is_object($node) ? get_class($node) : gettype($node)));
             }
 
@@ -273,7 +273,7 @@ 
         }
 
         if ($metadata->xmlAttributeMap) {
-            if (!is_array($v)) {
+            if ( ! is_array($v)) {
                 throw new RuntimeException(sprintf('Unsupported value type for XML attribute map. Expected array but got %s.', gettype($v)));
             }
 
@@ -282,7 +282,7 @@ 
                 $node = $this->navigator->accept($value, null, $context);
                 $this->revertCurrentMetadata();
 
-                if (!$node instanceof \DOMCharacterData) {
+                if ( ! $node instanceof \DOMCharacterData) {
                     throw new RuntimeException(sprintf('Unsupported value for a XML attribute map value. Expected character data, but got %s.', json_encode($v)));
                 }
 
@@ -292,7 +292,7 @@ 
             return;
         }
 
-        if ($addEnclosingElement = !$this->isInLineCollection($metadata) && !$metadata->inline) {
+        if ($addEnclosingElement = ! $this->isInLineCollection($metadata) && ! $metadata->inline) {
             $elementName = $this->namingStrategy->translateName($metadata);
 
             $namespace = null !== $metadata->xmlNamespace
@@ -335,7 +335,7 @@ 
 
     private function isSkippableEmptyObject($node, PropertyMetadata $metadata)
     {
-        return $node === null && !$metadata->xmlCollection && $metadata->skipWhenEmpty;
+        return $node === null && ! $metadata->xmlCollection && $metadata->skipWhenEmpty;
     }
 
     private function isSkippableCollection(PropertyMetadata $metadata)
@@ -345,7 +345,7 @@ 
 
     private function isElementEmpty(\DOMElement $element)
     {
-        return !$element->hasChildNodes() && !$element->hasAttributes();
+        return ! $element->hasChildNodes() && ! $element->hasAttributes();
     }
 
     public function endVisitingObject(ClassMetadata $metadata, $data, array $type, Context $context)
@@ -424,12 +424,12 @@ 
     {
         if (null === $this->document) {
             $this->document = $this->createDocument(null, null, true);
-            $this->currentNode->appendChild($textNode = $this->document->createTextNode((string)$data));
+            $this->currentNode->appendChild($textNode = $this->document->createTextNode((string) $data));
 
             return $textNode;
         }
 
-        return $this->document->createTextNode((string)$data);
+        return $this->document->createTextNode((string) $data);
     }
 
     /**
@@ -446,7 +446,7 @@ 
 
     private function attachNullNamespace()
     {
-        if (!$this->nullWasVisited) {
+        if ( ! $this->nullWasVisited) {
             $this->document->documentElement->setAttributeNS(
                 'http://www.w3.org/2000/xmlns/',
                 'xmlns:xsi',
@@ -467,7 +467,7 @@ 
         foreach ($metadata->xmlNamespaces as $prefix => $uri) {
             $attribute = 'xmlns';
             if ($prefix !== '') {
-                $attribute .= ':' . $prefix;
+                $attribute .= ':'.$prefix;
             } elseif ($element->namespaceURI === $uri) {
                 continue;
             }
@@ -483,19 +483,19 @@ 
         if ($this->currentNode->isDefaultNamespace($namespace)) {
             return $this->document->createElementNS($namespace, $tagName);
         }
-        if (!($prefix = $this->currentNode->lookupPrefix($namespace)) && !($prefix = $this->document->lookupPrefix($namespace))) {
-            $prefix = 'ns-' . substr(sha1($namespace), 0, 8);
+        if ( ! ($prefix = $this->currentNode->lookupPrefix($namespace)) && ! ($prefix = $this->document->lookupPrefix($namespace))) {
+            $prefix = 'ns-'.substr(sha1($namespace), 0, 8);
         }
-        return $this->document->createElementNS($namespace, $prefix . ':' . $tagName);
+        return $this->document->createElementNS($namespace, $prefix.':'.$tagName);
     }
 
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
     {
         if (null !== $namespace) {
-            if (!$prefix = $node->lookupPrefix($namespace)) {
-                $prefix = 'ns-' . substr(sha1($namespace), 0, 8);
+            if ( ! $prefix = $node->lookupPrefix($namespace)) {
+                $prefix = 'ns-'.substr(sha1($namespace), 0, 8);
             }
-            $node->setAttributeNS($namespace, $prefix . ':' . $name, $value);
+            $node->setAttributeNS($namespace, $prefix.':'.$name, $value);
         } else {
             $node->setAttribute($name, $value);
         }
@@ -519,6 +519,6 @@ 
      */
     public function setFormatOutput($formatOutput)
     {
-        $this->formatOutput = (boolean)$formatOutput;
+        $this->formatOutput = (boolean) $formatOutput;
     }
 }

src/JMS/Serializer/YamlSerializationVisitor.php

Spacing +11 added lines, -11 removed lines

@@ -84,7 +84,7 @@ 
         $isHash = isset($type['params'][1]);
 
         $count = $this->writer->changeCount;
-        $isList = (isset($type['params'][0]) && !isset($type['params'][1]))
+        $isList = (isset($type['params'][0]) && ! isset($type['params'][1]))
             || array_keys($data) === range(0, count($data) - 1);
 
         foreach ($data as $k => $v) {
@@ -92,10 +92,10 @@ 
                 continue;
             }
 
-            if ($isList && !$isHash) {
+            if ($isList && ! $isHash) {
                 $this->writer->writeln('-');
             } else {
-                $this->writer->writeln(Inline::dump($k) . ':');
+                $this->writer->writeln(Inline::dump($k).':');
             }
 
             $this->writer->indent();
@@ -103,7 +103,7 @@ 
             if (null !== $v = $this->navigator->accept($v, $this->getElementType($type), $context)) {
                 $this->writer
                     ->rtrim(false)
-                    ->writeln(' ' . $v);
+                    ->writeln(' '.$v);
             }
 
             $this->writer->outdent();
@@ -133,7 +133,7 @@ 
 
     public function visitDouble($data, array $type, Context $context)
     {
-        $v = (string)$data;
+        $v = (string) $data;
 
         if ('' === $this->writer->content) {
             $this->writer->writeln($v);
@@ -144,7 +144,7 @@ 
 
     public function visitInteger($data, array $type, Context $context)
     {
-        $v = (string)$data;
+        $v = (string) $data;
 
         if ('' === $this->writer->content) {
             $this->writer->writeln($v);
@@ -167,9 +167,9 @@ 
 
         $name = $this->namingStrategy->translateName($metadata);
 
-        if (!$metadata->inline) {
+        if ( ! $metadata->inline) {
             $this->writer
-                ->writeln(Inline::dump($name) . ':')
+                ->writeln(Inline::dump($name).':')
                 ->indent();
         }
 
@@ -180,12 +180,12 @@ 
         if (null !== $v = $this->navigator->accept($v, $metadata->type, $context)) {
             $this->writer
                 ->rtrim(false)
-                ->writeln(' ' . $v);
-        } elseif ($count === $this->writer->changeCount && !$metadata->inline) {
+                ->writeln(' '.$v);
+        } elseif ($count === $this->writer->changeCount && ! $metadata->inline) {
             $this->writer->revert();
         }
 
-        if (!$metadata->inline) {
+        if ( ! $metadata->inline) {
             $this->writer->outdent();
         }
         $this->revertCurrentMetadata();

src/JMS/Serializer/Handler/LazyHandlerRegistry.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
             return $this->initializedHandlers[$direction][$typeName][$format];
         }
 
-        if (!isset($this->handlers[$direction][$typeName][$format])) {
+        if ( ! isset($this->handlers[$direction][$typeName][$format])) {
             return null;
         }
 

src/JMS/Serializer/Handler/HandlerRegistry.php

Spacing +4 added lines, -4 removed lines

@@ -34,10 +34,10 @@ 
 
         switch ($direction) {
             case GraphNavigator::DIRECTION_DESERIALIZATION:
-                return 'deserialize' . $type . 'From' . $format;
+                return 'deserialize'.$type.'From'.$format;
 
             case GraphNavigator::DIRECTION_SERIALIZATION:
-                return 'serialize' . $type . 'To' . $format;
+                return 'serialize'.$type.'To'.$format;
 
             default:
                 throw new LogicException(sprintf('The direction %s does not exist; see GraphNavigator::DIRECTION_??? constants.', json_encode($direction)));
@@ -52,7 +52,7 @@ 
     public function registerSubscribingHandler(SubscribingHandlerInterface $handler)
     {
         foreach ($handler->getSubscribingMethods() as $methodData) {
-            if (!isset($methodData['type'], $methodData['format'])) {
+            if ( ! isset($methodData['type'], $methodData['format'])) {
                 throw new RuntimeException(sprintf('For each subscribing method a "type" and "format" attribute must be given, but only got "%s" for %s.', implode('" and "', array_keys($methodData)), get_class($handler)));
             }
 
@@ -79,7 +79,7 @@ 
 
     public function getHandler($direction, $typeName, $format)
     {
-        if (!isset($this->handlers[$direction][$typeName][$format])) {
+        if ( ! isset($this->handlers[$direction][$typeName][$format])) {
             return null;
         }
 

src/JMS/Serializer/Handler/PhpCollectionHandler.php

Spacing +2 added lines, -2 removed lines

@@ -41,14 +41,14 @@
                     'direction' => GraphNavigator::DIRECTION_SERIALIZATION,
                     'type' => $type,
                     'format' => $format,
-                    'method' => 'serialize' . $shortName,
+                    'method' => 'serialize'.$shortName,
                 );
 
                 $methods[] = array(
                     'direction' => GraphNavigator::DIRECTION_DESERIALIZATION,
                     'type' => $type,
                     'format' => $format,
-                    'method' => 'deserialize' . $shortName,
+                    'method' => 'deserialize'.$shortName,
                 );
             }
         }

src/JMS/Serializer/Handler/ConstraintViolationHandler.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
                     'direction' => GraphNavigator::DIRECTION_SERIALIZATION,
                     'type' => $type,
                     'format' => $format,
-                    'method' => $method . 'To' . $format,
+                    'method' => $method.'To'.$format,
                 );
             }
         }

src/JMS/Serializer/SerializationContext.php

Spacing +5 added lines, -5 removed lines

@@ -49,7 +49,7 @@ 
 
     public function startVisiting($object)
     {
-        if (!is_object($object)) {
+        if ( ! is_object($object)) {
             return;
         }
         $this->visitingSet->attach($object);
@@ -58,7 +58,7 @@ 
 
     public function stopVisiting($object)
     {
-        if (!is_object($object)) {
+        if ( ! is_object($object)) {
             return;
         }
         $this->visitingSet->detach($object);
@@ -71,7 +71,7 @@ 
 
     public function isVisiting($object)
     {
-        if (!is_object($object)) {
+        if ( ! is_object($object)) {
             return false;
         }
 
@@ -85,7 +85,7 @@ 
             $path[] = get_class($obj);
         }
 
-        if (!$path) {
+        if ( ! $path) {
             return null;
         }
 
@@ -104,7 +104,7 @@ 
 
     public function getObject()
     {
-        return !$this->visitingStack->isEmpty() ? $this->visitingStack->top() : null;
+        return ! $this->visitingStack->isEmpty() ? $this->visitingStack->top() : null;
     }
 
     public function getVisitingStack()

src/JMS/Serializer/Metadata/PropertyMetadata.php

Spacing +11 added lines, -11 removed lines

@@ -59,22 +59,22 @@
             $class = $this->reflection->getDeclaringClass();
 
             if (empty($getter)) {
-                if ($class->hasMethod('get' . $this->name) && $class->getMethod('get' . $this->name)->isPublic()) {
-                    $getter = 'get' . $this->name;
-                } elseif ($class->hasMethod('is' . $this->name) && $class->getMethod('is' . $this->name)->isPublic()) {
-                    $getter = 'is' . $this->name;
-                } elseif ($class->hasMethod('has' . $this->name) && $class->getMethod('has' . $this->name)->isPublic()) {
-                    $getter = 'has' . $this->name;
+                if ($class->hasMethod('get'.$this->name) && $class->getMethod('get'.$this->name)->isPublic()) {
+                    $getter = 'get'.$this->name;
+                } elseif ($class->hasMethod('is'.$this->name) && $class->getMethod('is'.$this->name)->isPublic()) {
+                    $getter = 'is'.$this->name;
+                } elseif ($class->hasMethod('has'.$this->name) && $class->getMethod('has'.$this->name)->isPublic()) {
+                    $getter = 'has'.$this->name;
                 } else {
-                    throw new RuntimeException(sprintf('There is neither a public %s method, nor a public %s method, nor a public %s method in class %s. Please specify which public method should be used for retrieving the value of the property %s.', 'get' . ucfirst($this->name), 'is' . ucfirst($this->name), 'has' . ucfirst($this->name), $this->class, $this->name));
+                    throw new RuntimeException(sprintf('There is neither a public %s method, nor a public %s method, nor a public %s method in class %s. Please specify which public method should be used for retrieving the value of the property %s.', 'get'.ucfirst($this->name), 'is'.ucfirst($this->name), 'has'.ucfirst($this->name), $this->class, $this->name));
                 }
             }
 
-            if (empty($setter) && !$this->readOnly) {
-                if ($class->hasMethod('set' . $this->name) && $class->getMethod('set' . $this->name)->isPublic()) {
-                    $setter = 'set' . $this->name;
+            if (empty($setter) && ! $this->readOnly) {
+                if ($class->hasMethod('set'.$this->name) && $class->getMethod('set'.$this->name)->isPublic()) {
+                    $setter = 'set'.$this->name;
                 } else {
-                    throw new RuntimeException(sprintf('There is no public %s method in class %s. Please specify which public method should be used for setting the value of the property %s.', 'set' . ucfirst($this->name), $this->class, $this->name));
+                    throw new RuntimeException(sprintf('There is no public %s method in class %s. Please specify which public method should be used for setting the value of the property %s.', 'set'.ucfirst($this->name), $this->class, $this->name));
                 }
             }
         }

src/JMS/Serializer/Metadata/ClassMetadata.php

Spacing +12 added lines, -12 removed lines

@@ -88,12 +88,12 @@ 
      */
     public function setAccessorOrder($order, array $customOrder = array())
     {
-        if (!in_array($order, array(self::ACCESSOR_ORDER_UNDEFINED, self::ACCESSOR_ORDER_ALPHABETICAL, self::ACCESSOR_ORDER_CUSTOM), true)) {
+        if ( ! in_array($order, array(self::ACCESSOR_ORDER_UNDEFINED, self::ACCESSOR_ORDER_ALPHABETICAL, self::ACCESSOR_ORDER_CUSTOM), true)) {
             throw new InvalidArgumentException(sprintf('The accessor order "%s" is invalid.', $order));
         }
 
         foreach ($customOrder as $name) {
-            if (!is_string($name)) {
+            if ( ! is_string($name)) {
                 throw new InvalidArgumentException(sprintf('$customOrder is expected to be a list of strings, but got element of value %s.', json_encode($name)));
             }
         }
@@ -129,7 +129,7 @@ 
 
     public function merge(MergeableInterface $object)
     {
-        if (!$object instanceof ClassMetadata) {
+        if ( ! $object instanceof ClassMetadata) {
             throw new InvalidArgumentException('$object must be an instance of ClassMetadata.');
         }
         parent::merge($object);
@@ -153,7 +153,7 @@ 
                 $this->discriminatorBaseClass,
                 $this->discriminatorBaseClass
             ));
-        } elseif (!$this->discriminatorFieldName && $object->discriminatorFieldName) {
+        } elseif ( ! $this->discriminatorFieldName && $object->discriminatorFieldName) {
             $this->discriminatorFieldName = $object->discriminatorFieldName;
             $this->discriminatorMap = $object->discriminatorMap;
         }
@@ -168,7 +168,7 @@ 
             $this->discriminatorBaseClass = $object->discriminatorBaseClass;
         }
 
-        if ($this->discriminatorMap && !$this->reflection->isAbstract()) {
+        if ($this->discriminatorMap && ! $this->reflection->isAbstract()) {
             if (false === $typeValue = array_search($this->name, $this->discriminatorMap, true)) {
                 throw new \LogicException(sprintf(
                     'The sub-class "%s" is not listed in the discriminator of the base class "%s".',
@@ -180,7 +180,7 @@ 
             $this->discriminatorValue = $typeValue;
 
             if (isset($this->propertyMetadata[$this->discriminatorFieldName])
-                && !$this->propertyMetadata[$this->discriminatorFieldName] instanceof StaticPropertyMetadata
+                && ! $this->propertyMetadata[$this->discriminatorFieldName] instanceof StaticPropertyMetadata
             ) {
                 throw new \LogicException(sprintf(
                     'The discriminator field name "%s" of the base-class "%s" conflicts with a regular property of the sub-class "%s".',
@@ -207,12 +207,12 @@ 
 
     public function registerNamespace($uri, $prefix = null)
     {
-        if (!is_string($uri)) {
+        if ( ! is_string($uri)) {
             throw new InvalidArgumentException(sprintf('$uri is expected to be a strings, but got value %s.', json_encode($uri)));
         }
 
         if ($prefix !== null) {
-            if (!is_string($prefix)) {
+            if ( ! is_string($prefix)) {
                 throw new InvalidArgumentException(sprintf('$prefix is expected to be a strings, but got value %s.', json_encode($prefix)));
             }
         } else {
@@ -300,19 +300,19 @@ 
             case self::ACCESSOR_ORDER_CUSTOM:
                 $order = $this->customOrder;
                 $currentSorting = $this->propertyMetadata ? array_combine(array_keys($this->propertyMetadata), range(1, count($this->propertyMetadata))) : [];
-                uksort($this->propertyMetadata, function ($a, $b) use ($order, $currentSorting) {
+                uksort($this->propertyMetadata, function($a, $b) use ($order, $currentSorting) {
                     $existsA = isset($order[$a]);
                     $existsB = isset($order[$b]);
 
-                    if (!$existsA && !$existsB) {
+                    if ( ! $existsA && ! $existsB) {
                         return $currentSorting[$a] - $currentSorting[$b];
                     }
 
-                    if (!$existsA) {
+                    if ( ! $existsA) {
                         return 1;
                     }
 
-                    if (!$existsB) {
+                    if ( ! $existsB) {
                         return -1;
                     }