Completed
Pull Request — master (#640)
by Ayrton
07:37
created
src/JMS/Serializer/SerializerBuilder.php 1 patch
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -23,17 +23,11 @@
 block discarded – undo
23 23
 use JMS\Serializer\Handler\PhpCollectionHandler;
24 24
 use JMS\Serializer\Handler\PropelCollectionHandler;
25 25
 use JMS\Serializer\Exception\RuntimeException;
26
-use Metadata\Driver\DriverInterface;
27 26
 use Metadata\MetadataFactory;
28
-use JMS\Serializer\Metadata\Driver\AnnotationDriver;
29 27
 use JMS\Serializer\Handler\HandlerRegistry;
30 28
 use JMS\Serializer\Construction\UnserializeObjectConstructor;
31 29
 use PhpCollection\Map;
32 30
 use JMS\Serializer\EventDispatcher\EventDispatcher;
33
-use Metadata\Driver\DriverChain;
34
-use JMS\Serializer\Metadata\Driver\YamlDriver;
35
-use JMS\Serializer\Metadata\Driver\XmlDriver;
36
-use Metadata\Driver\FileLocator;
37 31
 use JMS\Serializer\Handler\DateHandler;
38 32
 use JMS\Serializer\Handler\ArrayCollectionHandler;
39 33
 use JMS\Serializer\Construction\ObjectConstructorInterface;
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlDeserializationVisitor.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -346,7 +346,6 @@
 block discarded – undo
346 346
     /**
347 347
      * Retrieves internalSubset even in bugfixed php versions
348 348
      *
349
-     * @param \DOMDocumentType $child
350 349
      * @param string $data
351 350
      * @return string
352 351
      */
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlSerializationVisitor.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -44,6 +44,9 @@  discard block
 block discarded – undo
44 44
     private $nullWasVisited;
45 45
     private $objectMetadataStack;
46 46
 
47
+    /**
48
+     * @param Naming\PropertyNamingStrategyInterface $namingStrategy
49
+     */
47 50
     public function __construct($namingStrategy)
48 51
     {
49 52
         parent::__construct($namingStrategy);
@@ -126,6 +129,9 @@  discard block
 block discarded – undo
126 129
         return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string) $data);
127 130
     }
128 131
 
132
+    /**
133
+     * @param string $data
134
+     */
129 135
     public function visitSimpleString($data, array $type, Context $context)
130 136
     {
131 137
         if (null === $this->document) {
@@ -437,6 +443,9 @@  discard block
 block discarded – undo
437 443
         }
438 444
     }
439 445
 
446
+    /**
447
+     * @return \DOMNode
448
+     */
440 449
     private function createElement($tagName, $namespace = null)
441 450
     {
442 451
         if (null !== $namespace) {
@@ -456,6 +465,9 @@  discard block
 block discarded – undo
456 465
         }
457 466
     }
458 467
 
468
+    /**
469
+     * @param string $value
470
+     */
459 471
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
460 472
     {
461 473
         if (null !== $namespace) {
Please login to merge, or discard this patch.
src/JMS/Serializer/SerializationContext.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,6 @@
 block discarded – undo
18 18
 
19 19
 namespace JMS\Serializer;
20 20
 
21
-use JMS\Serializer\Exception\LogicException;
22 21
 use JMS\Serializer\Exception\RuntimeException;
23 22
 use Metadata\MetadataFactoryInterface;
24 23
 
Please login to merge, or discard this patch.