AnnotationDriver::__construct() - Code Metrics - Inspection of "Create an attribute driver decoupled from the anno..." - schmittjoh/serializer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1469)

by Asmir

created 2023-02-03 04:57 UTC

AnnotationDriver::__construct() A

↳ Parent: AnnotationDriver

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
c	1
b	0
f	0
nc	1
nop	4
dl	0
loc	5
rs	10
ccs	0
cts	0
cp	0
crap	2

<?php

declare(strict_types=1);

namespace JMS\Serializer\Metadata\Driver;

use Doctrine\Common\Annotations\Reader;
use JMS\Serializer\Expression\CompilableExpressionEvaluatorInterface;
use JMS\Serializer\Naming\PropertyNamingStrategyInterface;
use JMS\Serializer\Type\ParserInterface;

class AnnotationDriver extends AnnotationOrAttributeDriver
{
    /**
     * @var Reader
     */
    private $reader;

    public function __construct(Reader $reader, PropertyNamingStrategyInterface $namingStrategy, ?ParserInterface $typeParser = null, ?CompilableExpressionEvaluatorInterface $expressionEvaluator = null)
    {
        parent::__construct($namingStrategy, $typeParser, $expressionEvaluator);

        $this->reader = $reader;
    }

    /**
     * @return list<object>
filter:
    dependency_paths: ["lib/*"]
     */
    protected function getClassAnnotations(\ReflectionClass $class): array
    {
        return $this->reader->getClassAnnotations($class);

    }

    /**
     * @return list<object>
     */
    protected function getMethodAnnotations(\ReflectionMethod $method): array
    {
        return $this->reader->getMethodAnnotations($method);

    }

    /**
     * @return list<object>
     */
    protected function getPropertyAnnotations(\ReflectionProperty $property): array
    {
        return $this->reader->getPropertyAnnotations($property);

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace JMS\Serializer\Metadata\Driver;
6
7			use Doctrine\Common\Annotations\Reader;
8			use JMS\Serializer\Expression\CompilableExpressionEvaluatorInterface;
9			use JMS\Serializer\Naming\PropertyNamingStrategyInterface;
10			use JMS\Serializer\Type\ParserInterface;
11
12			class AnnotationDriver extends AnnotationOrAttributeDriver
13			{
14			/**
15			* @var Reader
16			*/
17			private $reader;
18
19			public function __construct(Reader $reader, PropertyNamingStrategyInterface $namingStrategy, ?ParserInterface $typeParser = null, ?CompilableExpressionEvaluatorInterface $expressionEvaluator = null)
20			{
21			parent::__construct($namingStrategy, $typeParser, $expressionEvaluator);
22
23			$this->reader = $reader;
24			}
25
26			/**
27			* @return list<object>
			0 ignored issues – show Bug introduced 2023-02-03 05:07 UTC by Report Bug Copy Issue Report The type `JMS\Serializer\Metadata\Driver\list` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
28			*/
29			protected function getClassAnnotations(\ReflectionClass $class): array
30			{
31			return $this->reader->getClassAnnotations($class);
			0 ignored issues – show Bug Best Practice introduced 2023-02-03 05:07 UTC by Report Bug Copy Issue Report The expression `return $this->reader->getClassAnnotations($class)` returns the type `array<mixed,object>` which is incompatible with the documented return type `JMS\Serializer\Metadata\Driver\list`. Loading history...
32			}
33
34			/**
35			* @return list<object>
36			*/
37			protected function getMethodAnnotations(\ReflectionMethod $method): array
38			{
39			return $this->reader->getMethodAnnotations($method);
			0 ignored issues – show Bug Best Practice introduced 2023-02-03 05:07 UTC by Report Bug Copy Issue Report The expression `return $this->reader->ge...hodAnnotations($method)` returns the type `array<mixed,object>` which is incompatible with the documented return type `JMS\Serializer\Metadata\Driver\list`. Loading history...
40			}
41
42			/**
43			* @return list<object>
44			*/
45			protected function getPropertyAnnotations(\ReflectionProperty $property): array
46			{
47			return $this->reader->getPropertyAnnotations($property);
			0 ignored issues – show Bug Best Practice introduced 2023-02-03 05:07 UTC by Report Bug Copy Issue Report The expression `return $this->reader->ge...yAnnotations($property)` returns the type `array<mixed,object>` which is incompatible with the documented return type `JMS\Serializer\Metadata\Driver\list`. Loading history...
48			}
49			}
50

schmittjoh / serializer

Pull Request — master (#1469)

AnnotationDriver::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like