JMS\Serializer\Metadata\Driver\AttributeDriver

Complexity

Total Complexity

6

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	loadMetadataForClass()	0	9	5

<?php

declare(strict_types=1);

namespace JMS\Serializer\Metadata\Driver;

use Metadata\ClassMetadata as BaseClassMetadata;
use Metadata\Driver\DriverInterface;
use Metadata\MergeableInterface;

class AttributeDriver implements DriverInterface
{
    private $annotationDriver;

    private $decorated;

    public function __construct(AnnotationDriver $annotationDriver, DriverInterface $decorated)
    {
        $this->annotationDriver = $annotationDriver;
        $this->decorated = $decorated;
    }

    public function loadMetadataForClass(\ReflectionClass $class): ?BaseClassMetadata
    {
        $metadata = $this->decorated->loadMetadataForClass($class);
        $attributeMetadata = !$class->isInternal() ? $this->annotationDriver->loadMetadataForClass($class) : null;
        if ($metadata instanceof MergeableInterface && $attributeMetadata instanceof MergeableInterface) {
            $metadata->merge($attributeMetadata);
        }

        return $metadata ?: $attributeMetadata;

The expression return $metadata ?: $attributeMetadata could return the type Metadata\MergeableInterface which is incompatible with the type-hinted return Metadata\ClassMetadata|null. Consider adding an additional type-check to rule them out.

    }
}