Completed
Pull Request — master (#813)
by Adrián
06:59
created
src/JMS/Serializer/XmlDeserializationVisitor.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -346,7 +346,6 @@
 block discarded – undo
346 346
     /**
347 347
      * Retrieves internalSubset even in bugfixed php versions
348 348
      *
349
-     * @param \DOMDocumentType $child
350 349
      * @param string $data
351 350
      * @return string
352 351
      */
Please login to merge, or discard this patch.
src/JMS/Serializer/Handler/DateHandler.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -72,8 +72,7 @@  discard block
 block discarded – undo
72 72
         \DateTimeInterface $date,
73 73
         array $type,
74 74
         Context $context
75
-    )
76
-    {
75
+    ) {
77 76
         if ($visitor instanceof XmlSerializationVisitor && false === $this->xmlCData) {
78 77
             return $visitor->visitSimpleString($date->format($this->getFormat($type)), $type, $context);
79 78
         }
@@ -96,8 +95,7 @@  discard block
 block discarded – undo
96 95
         \DateTimeImmutable $date,
97 96
         array $type,
98 97
         Context $context
99
-    )
100
-    {
98
+    ) {
101 99
         return $this->serializeDateTimeInterface($visitor, $date, $type, $context);
102 100
     }
103 101
 
Please login to merge, or discard this patch.
src/JMS/Serializer/GraphNavigator.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -82,8 +82,7 @@
 block discarded – undo
82 82
         ObjectConstructorInterface $objectConstructor,
83 83
         EventDispatcherInterface $dispatcher = null,
84 84
         ExpressionEvaluatorInterface $expressionEvaluator = null
85
-    )
86
-    {
85
+    ) {
87 86
         $this->dispatcher = $dispatcher;
88 87
         $this->metadataFactory = $metadataFactory;
89 88
         $this->handlerRegistry = $handlerRegistry;
Please login to merge, or discard this patch.
src/JMS/Serializer/Serializer.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,8 +83,7 @@
 block discarded – undo
83 83
         EventDispatcherInterface $dispatcher = null,
84 84
         TypeParser $typeParser = null,
85 85
         ExpressionEvaluatorInterface $expressionEvaluator = null
86
-    )
87
-    {
86
+    ) {
88 87
         $this->factory = $factory;
89 88
         $this->handlerRegistry = $handlerRegistry;
90 89
         $this->objectConstructor = $objectConstructor;
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlSerializationVisitor.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -127,6 +127,9 @@  discard block
 block discarded – undo
127 127
         return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string)$data);
128 128
     }
129 129
 
130
+    /**
131
+     * @param string $data
132
+     */
130 133
     public function visitSimpleString($data, array $type, Context $context)
131 134
     {
132 135
         if (null === $this->document) {
@@ -474,6 +477,9 @@  discard block
 block discarded – undo
474 477
         return $this->document->createElementNS($namespace, $prefix . ':' . $tagName);
475 478
     }
476 479
 
480
+    /**
481
+     * @param string $value
482
+     */
477 483
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
478 484
     {
479 485
         if (null !== $namespace) {
Please login to merge, or discard this patch.