Completed
Pull Request — master (#585)
by Jason
03:32
created
src/JMS/Serializer/Metadata/Driver/YamlDriver.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
 
168 168
                     //we need read_only before setter and getter set, because that method depends on flag being set
169 169
                     if (isset($pConfig['read_only'])) {
170
-                          $pMetadata->readOnly = (Boolean) $pConfig['read_only'];
170
+                            $pMetadata->readOnly = (Boolean) $pConfig['read_only'];
171 171
                     } else {
172 172
                         $pMetadata->readOnly = $pMetadata->readOnly || $readOnlyClass;
173 173
                     }
Please login to merge, or discard this patch.
src/JMS/Serializer/TypeParser.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
                 |(.)
50 50
             /x',
51 51
             array(self::T_NAME => 'T_NAME', self::T_STRING => 'T_STRING', self::T_OPEN_BRACKET => 'T_OPEN_BRACKET',
52
-                  self::T_CLOSE_BRACKET => 'T_CLOSE_BRACKET', self::T_COMMA => 'T_COMMA', self::T_NONE => 'T_NONE'),
52
+                    self::T_CLOSE_BRACKET => 'T_CLOSE_BRACKET', self::T_COMMA => 'T_COMMA', self::T_NONE => 'T_NONE'),
53 53
             function($value) {
54 54
                 switch ($value[0]) {
55 55
                     case '"':
Please login to merge, or discard this patch.
src/JMS/Serializer/YamlSerializationVisitor.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -168,8 +168,8 @@
 block discarded – undo
168 168
 
169 169
         if ( ! $metadata->inline) {
170 170
             $this->writer
171
-                 ->writeln(Inline::dump($name).':')
172
-                 ->indent();
171
+                    ->writeln(Inline::dump($name).':')
172
+                    ->indent();
173 173
         }
174 174
 
175 175
         $this->setCurrentMetadata($metadata);
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlDeserializationVisitor.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@
 block discarded – undo
226 226
             throw new RuntimeException(sprintf('You must define a type for %s::$%s.', $metadata->reflection->class, $metadata->name));
227 227
         }
228 228
 
229
-       if ($metadata->xmlAttribute) {
229
+        if ($metadata->xmlAttribute) {
230 230
 
231 231
             $attributes = $data->attributes($metadata->xmlNamespace);
232 232
             if (isset($attributes[$name])) {
Please login to merge, or discard this patch.
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -346,7 +346,6 @@
 block discarded – undo
346 346
     /**
347 347
      * Retrieves internalSubset even in bugfixed php versions
348 348
      *
349
-     * @param \DOMDocumentType $child
350 349
      * @param string $data
351 350
      * @return string
352 351
      */
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlSerializationVisitor.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -44,6 +44,9 @@  discard block
 block discarded – undo
44 44
     private $nullWasVisited;
45 45
     private $objectMetadataStack;
46 46
 
47
+    /**
48
+     * @param Naming\PropertyNamingStrategyInterface $namingStrategy
49
+     */
47 50
     public function __construct($namingStrategy)
48 51
     {
49 52
         parent::__construct($namingStrategy);
@@ -126,6 +129,9 @@  discard block
 block discarded – undo
126 129
         return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string) $data);
127 130
     }
128 131
 
132
+    /**
133
+     * @param string $data
134
+     */
129 135
     public function visitSimpleString($data, array $type, Context $context)
130 136
     {
131 137
         if (null === $this->document) {
@@ -437,6 +443,9 @@  discard block
 block discarded – undo
437 443
         }
438 444
     }
439 445
 
446
+    /**
447
+     * @return \DOMNode
448
+     */
440 449
     private function createElement($tagName, $namespace = null)
441 450
     {
442 451
         if (null !== $namespace) {
@@ -456,6 +465,9 @@  discard block
 block discarded – undo
456 465
         }
457 466
     }
458 467
 
468
+    /**
469
+     * @param string $value
470
+     */
459 471
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
460 472
     {
461 473
         if (null !== $namespace) {
Please login to merge, or discard this patch.