Completed
Pull Request — master (#727)
by Gerben
06:35
created
src/JMS/Serializer/Metadata/Driver/YamlDriver.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
 
168 168
                     //we need read_only before setter and getter set, because that method depends on flag being set
169 169
                     if (isset($pConfig['read_only'])) {
170
-                          $pMetadata->readOnly = (Boolean) $pConfig['read_only'];
170
+                            $pMetadata->readOnly = (Boolean) $pConfig['read_only'];
171 171
                     } else {
172 172
                         $pMetadata->readOnly = $pMetadata->readOnly || $readOnlyClass;
173 173
                     }
Please login to merge, or discard this patch.
src/JMS/Serializer/TypeParser.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
                 |(.)
50 50
             /x',
51 51
             array(self::T_NAME => 'T_NAME', self::T_STRING => 'T_STRING', self::T_OPEN_BRACKET => 'T_OPEN_BRACKET',
52
-                  self::T_CLOSE_BRACKET => 'T_CLOSE_BRACKET', self::T_COMMA => 'T_COMMA', self::T_NONE => 'T_NONE'),
52
+                    self::T_CLOSE_BRACKET => 'T_CLOSE_BRACKET', self::T_COMMA => 'T_COMMA', self::T_NONE => 'T_NONE'),
53 53
             function($value) {
54 54
                 switch ($value[0]) {
55 55
                     case '"':
Please login to merge, or discard this patch.
src/JMS/Serializer/YamlSerializationVisitor.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -168,8 +168,8 @@
 block discarded – undo
168 168
 
169 169
         if ( ! $metadata->inline) {
170 170
             $this->writer
171
-                 ->writeln(Inline::dump($name).':')
172
-                 ->indent();
171
+                    ->writeln(Inline::dump($name).':')
172
+                    ->indent();
173 173
         }
174 174
 
175 175
         $this->setCurrentMetadata($metadata);
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlDeserializationVisitor.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@
 block discarded – undo
226 226
             throw new RuntimeException(sprintf('You must define a type for %s::$%s.', $metadata->reflection->class, $metadata->name));
227 227
         }
228 228
 
229
-       if ($metadata->xmlAttribute) {
229
+        if ($metadata->xmlAttribute) {
230 230
 
231 231
             $attributes = $data->attributes($metadata->xmlNamespace);
232 232
             if (isset($attributes[$name])) {
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,6 +85,9 @@  discard block
 block discarded – undo
85 85
         return $doc;
86 86
     }
87 87
 
88
+    /**
89
+     * @return string
90
+     */
88 91
     private function emptyStringToSpaceCharacter($data)
89 92
     {
90 93
         return $data === '' ? ' ' : $data;
@@ -359,7 +362,6 @@  discard block
 block discarded – undo
359 362
     /**
360 363
      * Retrieves internalSubset even in bugfixed php versions
361 364
      *
362
-     * @param \DOMDocumentType $child
363 365
      * @param string $data
364 366
      * @return string
365 367
      */
Please login to merge, or discard this patch.
src/JMS/Serializer/Serializer.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      * @param \PhpCollection\MapInterface $deserializationVisitors of VisitorInterface
73 73
      * @param EventDispatcher\EventDispatcherInterface $dispatcher
74 74
      * @param TypeParser $typeParser
75
-     * @param ExpressionEvaluatorInterface $expressionLanguage
75
+     * @param ExpressionEvaluatorInterface $expressionEvaluator
76 76
      */
77 77
     public function __construct(
78 78
         MetadataFactoryInterface $factory,
@@ -179,6 +179,9 @@  discard block
 block discarded – undo
179 179
         ;
180 180
     }
181 181
 
182
+    /**
183
+     * @param string $format
184
+     */
182 185
     private function visit(VisitorInterface $visitor, Context $context, $data, $format, array $type = null)
183 186
     {
184 187
         $context->initialize(
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlSerializationVisitor.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
     /** @var boolean */
48 48
     private $formatOutput;
49 49
 
50
+    /**
51
+     * @param Naming\PropertyNamingStrategyInterface $namingStrategy
52
+     */
50 53
     public function __construct($namingStrategy)
51 54
     {
52 55
         parent::__construct($namingStrategy);
@@ -130,6 +133,9 @@  discard block
 block discarded – undo
130 133
         return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string) $data);
131 134
     }
132 135
 
136
+    /**
137
+     * @param string $data
138
+     */
133 139
     public function visitSimpleString($data, array $type, Context $context)
134 140
     {
135 141
         if (null === $this->document) {
@@ -476,6 +482,9 @@  discard block
 block discarded – undo
476 482
         return $this->document->createElementNS($namespace, $prefix . ':' . $tagName);
477 483
     }
478 484
 
485
+    /**
486
+     * @param string $value
487
+     */
479 488
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
480 489
     {
481 490
         if (null !== $namespace) {
Please login to merge, or discard this patch.