Completed
Pull Request — master (#1155)
by Ruud
10:44
created
src/XmlSerializationVisitor.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 
105 105
     public function createRoot(?ClassMetadata $metadata = null, ?string $rootName = null, ?string $rootNamespace = null, ?string $rootPrefix = null): \DOMElement
106 106
     {
107
-        if (null !== $metadata && !empty($metadata->xmlRootName)) {
107
+        if (null !== $metadata && ! empty($metadata->xmlRootName)) {
108 108
             $rootPrefix = $metadata->xmlRootPrefix;
109 109
             $rootName = $metadata->xmlRootName;
110 110
             $rootNamespace = $metadata->xmlRootNamespace ?: $this->getClassDefaultNamespace($metadata);
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 
117 117
         $document = $this->getDocument();
118 118
         if ($rootNamespace) {
119
-            $rootNode = $document->createElementNS($rootNamespace, (null !== $rootPrefix ? ($rootPrefix . ':') : '') . $rootName);
119
+            $rootNode = $document->createElementNS($rootNamespace, (null !== $rootPrefix ? ($rootPrefix.':') : '').$rootName);
120 120
         } else {
121 121
             $rootNode = $document->createElement($rootName);
122 122
         }
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
             $node = $this->navigator->accept($v, $metadata->type);
243 243
             $this->revertCurrentMetadata();
244 244
 
245
-            if (!$node instanceof \DOMCharacterData) {
245
+            if ( ! $node instanceof \DOMCharacterData) {
246 246
                 throw new RuntimeException(sprintf('Unsupported value for XML attribute for %s. Expected character data, but got %s.', $metadata->name, json_encode($v)));
247 247
             }
248 248
 
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
         }
253 253
 
254 254
         if (($metadata->xmlValue && $this->currentNode->childNodes->length > 0)
255
-            || (!$metadata->xmlValue && $this->hasValue)
255
+            || ( ! $metadata->xmlValue && $this->hasValue)
256 256
         ) {
257 257
             throw new RuntimeException(sprintf('If you make use of @XmlValue, all other properties in the class must have the @XmlAttribute annotation. Invalid usage detected in class %s.', $metadata->class));
258 258
         }
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
             $node = $this->navigator->accept($v, $metadata->type);
265 265
             $this->revertCurrentMetadata();
266 266
 
267
-            if (!$node instanceof \DOMCharacterData) {
267
+            if ( ! $node instanceof \DOMCharacterData) {
268 268
                 throw new RuntimeException(sprintf('Unsupported value for property %s::$%s. Expected character data, but got %s.', $metadata->reflection->class, $metadata->reflection->name, \is_object($node) ? \get_class($node) : \gettype($node)));
269 269
             }
270 270
 
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
         }
275 275
 
276 276
         if ($metadata->xmlAttributeMap) {
277
-            if (!\is_array($v)) {
277
+            if ( ! \is_array($v)) {
278 278
                 throw new RuntimeException(sprintf('Unsupported value type for XML attribute map. Expected array but got %s.', \gettype($v)));
279 279
             }
280 280
 
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
                 $node = $this->navigator->accept($value, null);
284 284
                 $this->revertCurrentMetadata();
285 285
 
286
-                if (!$node instanceof \DOMCharacterData) {
286
+                if ( ! $node instanceof \DOMCharacterData) {
287 287
                     throw new RuntimeException(sprintf('Unsupported value for a XML attribute map value. Expected character data, but got %s.', json_encode($v)));
288 288
                 }
289 289
 
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
             return;
294 294
         }
295 295
 
296
-        if ($addEnclosingElement = !$this->isInLineCollection($metadata) && !$metadata->inline) {
296
+        if ($addEnclosingElement = ! $this->isInLineCollection($metadata) && ! $metadata->inline) {
297 297
             $namespace = null !== $metadata->xmlNamespace
298 298
                 ? $metadata->xmlNamespace
299 299
                 : $this->getClassDefaultNamespace($this->objectMetadataStack->top());
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
 
338 338
     private function isSkippableEmptyObject(?\DOMElement $node, PropertyMetadata $metadata): bool
339 339
     {
340
-        return null === $node && !$metadata->xmlCollection && $metadata->skipWhenEmpty;
340
+        return null === $node && ! $metadata->xmlCollection && $metadata->skipWhenEmpty;
341 341
     }
342 342
 
343 343
     private function isSkippableCollection(PropertyMetadata $metadata): bool
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
 
348 348
     private function isElementEmpty(\DOMElement $element): bool
349 349
     {
350
-        return !$element->hasChildNodes() && !$element->hasAttributes();
350
+        return ! $element->hasChildNodes() && ! $element->hasAttributes();
351 351
     }
352 352
 
353 353
     public function endVisitingObject(ClassMetadata $metadata, object $data, array $type): void
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
         foreach ($metadata->xmlNamespaces as $prefix => $uri) {
454 454
             $attribute = 'xmlns';
455 455
             if ('' !== $prefix) {
456
-                $attribute .= ':' . $prefix;
456
+                $attribute .= ':'.$prefix;
457 457
             } elseif ($element->namespaceURI === $uri) {
458 458
                 continue;
459 459
             }
@@ -478,19 +478,19 @@  discard block
 block discarded – undo
478 478
         if ($this->currentNode->isDefaultNamespace($namespace)) {
479 479
             return $this->document->createElementNS($namespace, $tagName);
480 480
         }
481
-        if (!($prefix = $this->currentNode->lookupPrefix($namespace)) && !($prefix = $this->document->lookupPrefix($namespace))) {
482
-            $prefix = 'ns-' . substr(sha1($namespace), 0, 8);
481
+        if ( ! ($prefix = $this->currentNode->lookupPrefix($namespace)) && ! ($prefix = $this->document->lookupPrefix($namespace))) {
482
+            $prefix = 'ns-'.substr(sha1($namespace), 0, 8);
483 483
         }
484
-        return $this->document->createElementNS($namespace, $prefix . ':' . $tagName);
484
+        return $this->document->createElementNS($namespace, $prefix.':'.$tagName);
485 485
     }
486 486
 
487 487
     private function setAttributeOnNode(\DOMElement $node, string $name, string $value, ?string $namespace = null): void
488 488
     {
489 489
         if (null !== $namespace) {
490
-            if (!$prefix = $node->lookupPrefix($namespace)) {
491
-                $prefix = 'ns-' . substr(sha1($namespace), 0, 8);
490
+            if ( ! $prefix = $node->lookupPrefix($namespace)) {
491
+                $prefix = 'ns-'.substr(sha1($namespace), 0, 8);
492 492
             }
493
-            $node->setAttributeNS($namespace, $prefix . ':' . $name, $value);
493
+            $node->setAttributeNS($namespace, $prefix.':'.$name, $value);
494 494
         } else {
495 495
             $node->setAttribute($name, $value);
496 496
         }
Please login to merge, or discard this patch.
src/EventDispatcher/Subscriber/DoctrineProxySubscriber.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -39,13 +39,13 @@  discard block
 block discarded – undo
39 39
         // If the set type name is not an actual class, but a faked type for which a custom handler exists, we do not
40 40
         // modify it with this subscriber. Also, we forgo autoloading here as an instance of this type is already created,
41 41
         // so it must be loaded if its a real class.
42
-        $virtualType = !class_exists($type['name'], false);
42
+        $virtualType = ! class_exists($type['name'], false);
43 43
 
44 44
         if ($object instanceof PersistentCollection
45 45
             || $object instanceof MongoDBPersistentCollection
46 46
             || $object instanceof PHPCRPersistentCollection
47 47
         ) {
48
-            if (!$virtualType) {
48
+            if ( ! $virtualType) {
49 49
                 $event->setType('ArrayCollection');
50 50
             }
51 51
 
@@ -53,13 +53,13 @@  discard block
 block discarded – undo
53 53
         }
54 54
 
55 55
         if (($this->skipVirtualTypeInit && $virtualType) ||
56
-            (!$object instanceof Proxy && !$object instanceof LazyLoadingInterface)
56
+            ( ! $object instanceof Proxy && ! $object instanceof LazyLoadingInterface)
57 57
         ) {
58 58
             return;
59 59
         }
60 60
 
61 61
         // do not initialize the proxy if is going to be excluded by-class by some exclusion strategy
62
-        if (false === $this->initializeExcluded && !$virtualType) {
62
+        if (false === $this->initializeExcluded && ! $virtualType) {
63 63
             $context = $event->getContext();
64 64
             $exclusionStrategy = $context->getExclusionStrategy();
65 65
             $metadata = $context->getMetadataFactory()->getMetadataForClass(get_parent_class($object));
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
             $object->__load();
75 75
         }
76 76
 
77
-        if (!$virtualType) {
77
+        if ( ! $virtualType) {
78 78
             $event->setType(get_parent_class($object), $type['params']);
79 79
         }
80 80
     }
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     {
84 84
         $type = $event->getType();
85 85
         // is a virtual type? then there is no need to change the event name
86
-        if (!class_exists($type['name'], false)) {
86
+        if ( ! class_exists($type['name'], false)) {
87 87
             return;
88 88
         }
89 89
 
Please login to merge, or discard this patch.
src/Handler/FormErrorHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 
50 50
     public function __construct(?object $translator = null, string $translationDomain = 'validators')
51 51
     {
52
-        if (null!== $translator && (!$translator instanceof TranslatorInterface && !$translator instanceof TranslatorContract)) {
52
+        if (null !== $translator && ( ! $translator instanceof TranslatorInterface && ! $translator instanceof TranslatorContract)) {
53 53
             throw new \InvalidArgumentException(sprintf(
54 54
                 'The first argument passed to %s must be instance of %s or %s, %s given',
55 55
                 self::class,
Please login to merge, or discard this patch.