schmittjoh / serializer

src/JMS/Serializer/SerializationContext.php

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 
 namespace JMS\Serializer;
 
-use JMS\Serializer\Exception\LogicException;
 use JMS\Serializer\Exception\RuntimeException;
 use Metadata\MetadataFactoryInterface;
 

src/JMS/Serializer/Metadata/PropertyMetadata.php

Spacing +2 added lines, -2 removed lines

@@ -166,10 +166,10 @@
             $parentStr
         ) = $unserialized;
 
-        if (isset($unserialized['xmlEntryNamespace'])){
+        if (isset($unserialized['xmlEntryNamespace'])) {
             $this->xmlEntryNamespace = $unserialized['xmlEntryNamespace'];
         }
-        if (isset($unserialized['xmlCollectionSkipWhenEmpty'])){
+        if (isset($unserialized['xmlCollectionSkipWhenEmpty'])) {
             $this->xmlCollectionSkipWhenEmpty = $unserialized['xmlCollectionSkipWhenEmpty'];
         }
         

Braces +2 added lines, -2 removed lines

@@ -166,10 +166,10 @@
             $parentStr
         ) = $unserialized;
 
-        if (isset($unserialized['xmlEntryNamespace'])){
+        if (isset($unserialized['xmlEntryNamespace'])) {
             $this->xmlEntryNamespace = $unserialized['xmlEntryNamespace'];
         }
-        if (isset($unserialized['xmlCollectionSkipWhenEmpty'])){
+        if (isset($unserialized['xmlCollectionSkipWhenEmpty'])) {
             $this->xmlCollectionSkipWhenEmpty = $unserialized['xmlCollectionSkipWhenEmpty'];
         }
         

src/JMS/Serializer/XmlSerializationVisitor.php

Spacing +9 added lines, -9 removed lines

@@ -197,7 +197,7 @@ 
             $this->document = $this->createDocument(null, null, false);
             if ($metadata->xmlRootName) {
                 $rootName = $metadata->xmlRootName;
-                $rootNamespace = $metadata->xmlRootNamespace?:$this->getClassDefaultNamespace($metadata);
+                $rootNamespace = $metadata->xmlRootNamespace ?: $this->getClassDefaultNamespace($metadata);
             } else {
                 $rootName = $this->defaultRootName;
                 $rootNamespace = $this->defaultRootNamespace;
@@ -303,7 +303,7 @@ 
         if ($addEnclosingElement) {
             $this->revertCurrentNode();
 
-            if ($this->nodeNotEmpty($element) || ((!$metadata->xmlCollection || !$metadata->xmlCollectionSkipWhenEmpty) && $node === null && $v !== null && !$context->isVisiting($v))) {
+            if ($this->nodeNotEmpty($element) || (( ! $metadata->xmlCollection || ! $metadata->xmlCollectionSkipWhenEmpty) && $node === null && $v !== null && ! $context->isVisiting($v))) {
                 $this->currentNode->appendChild($element);
             }
         }
@@ -449,18 +449,18 @@ 
         if ($this->currentNode->isDefaultNamespace($namespace)) {
             return $this->document->createElementNS($namespace, $tagName);
         }
-        if (!($prefix = $this->currentNode->lookupPrefix($namespace)) && !($prefix = $this->document->lookupPrefix($namespace))) {
-            $prefix = 'ns-'.  substr(sha1($namespace), 0, 8);
-            return $this->document->createElementNS($namespace, $prefix . ':' . $tagName);
+        if ( ! ($prefix = $this->currentNode->lookupPrefix($namespace)) && ! ($prefix = $this->document->lookupPrefix($namespace))) {
+            $prefix = 'ns-'.substr(sha1($namespace), 0, 8);
+            return $this->document->createElementNS($namespace, $prefix.':'.$tagName);
         }
-        return $this->document->createElement($prefix . ':' . $tagName);
+        return $this->document->createElement($prefix.':'.$tagName);
     }
 
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
     {
         if (null !== $namespace) {
-            if (!$prefix = $node->lookupPrefix($namespace)) {
-                $prefix = 'ns-'.  substr(sha1($namespace), 0, 8);
+            if ( ! $prefix = $node->lookupPrefix($namespace)) {
+                $prefix = 'ns-'.substr(sha1($namespace), 0, 8);
             }
             $node->setAttributeNS($namespace, $prefix.':'.$name, $value);
         } else {
@@ -470,7 +470,7 @@ 
 
     private function getClassDefaultNamespace(ClassMetadata $metadata)
     {
-        return (isset($metadata->xmlNamespaces[''])?$metadata->xmlNamespaces['']:null);
+        return (isset($metadata->xmlNamespaces['']) ? $metadata->xmlNamespaces[''] : null);
     }
 
 }

Doc Comments +15 added lines

@@ -48,12 +48,18 @@ 
     private $nullWasVisited;
     private $objectMetadataStack;
 
+    /**
+     * @param Naming\PropertyNamingStrategyInterface $namingStrategy
+     */
     public function __construct($namingStrategy)
     {
         parent::__construct($namingStrategy);
         $this->objectMetadataStack = new \SplStack;
     }
 
+    /**
+     * @param Naming\PropertyNamingStrategyInterface $namingStrategy
+     */
     public function __construct($namingStrategy)
     {
         parent::__construct($namingStrategy);
@@ -151,6 +157,9 @@ 
         return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string) $data);
     }
 
+    /**
+     * @param string $data
+     */
     public function visitSimpleString($data, array $type, Context $context)
     {
         if (null === $this->document) {
@@ -468,6 +477,9 @@ 
         }
     }
 
+    /**
+     * @return \DOMNode
+     */
     private function createElement($tagName, $namespace = null)
     {
         if (null === $namespace) {
@@ -483,6 +495,9 @@ 
         return $this->document->createElement($prefix . ':' . $tagName);
     }
 
+    /**
+     * @param string $value
+     */
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
     {
         if (null !== $namespace) {