Completed
Pull Request — master (#754)
by Dmitriy
15:21
created
src/JMS/Serializer/SerializationContext.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,6 @@
 block discarded – undo
18 18
 
19 19
 namespace JMS\Serializer;
20 20
 
21
-use JMS\Serializer\Exception\LogicException;
22 21
 use JMS\Serializer\Exception\RuntimeException;
23 22
 use Metadata\MetadataFactoryInterface;
24 23
 
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlDeserializationVisitor.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,6 +85,9 @@  discard block
 block discarded – undo
85 85
         return $doc;
86 86
     }
87 87
 
88
+    /**
89
+     * @return string
90
+     */
88 91
     private function emptyStringToSpaceCharacter($data)
89 92
     {
90 93
         return $data === '' ? ' ' : $data;
@@ -359,7 +362,6 @@  discard block
 block discarded – undo
359 362
     /**
360 363
      * Retrieves internalSubset even in bugfixed php versions
361 364
      *
362
-     * @param \DOMDocumentType $child
363 365
      * @param string $data
364 366
      * @return string
365 367
      */
Please login to merge, or discard this patch.
src/JMS/Serializer/Metadata/Driver/AnnotationDriver.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,6 @@
 block discarded – undo
19 19
 namespace JMS\Serializer\Metadata\Driver;
20 20
 
21 21
 use JMS\Serializer\Annotation\Discriminator;
22
-use JMS\Serializer\Annotation\ExcludeIf;
23 22
 use JMS\Serializer\Annotation\XmlDiscriminator;
24 23
 use JMS\Serializer\GraphNavigator;
25 24
 use JMS\Serializer\Annotation\HandlerCallback;
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlSerializationVisitor.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -132,6 +132,9 @@  discard block
 block discarded – undo
132 132
         return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string) $data);
133 133
     }
134 134
 
135
+    /**
136
+     * @param string $data
137
+     */
135 138
     public function visitSimpleString($data, array $type, Context $context)
136 139
     {
137 140
         if (null === $this->document) {
@@ -478,6 +481,9 @@  discard block
 block discarded – undo
478 481
         return $this->document->createElementNS($namespace, $prefix . ':' . $tagName);
479 482
     }
480 483
 
484
+    /**
485
+     * @param string $value
486
+     */
481 487
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
482 488
     {
483 489
         if (null !== $namespace) {
Please login to merge, or discard this patch.