Lexer::getCatchablePatterns() - Code Metrics - Inspection of "Remove hoa compiler" - schmittjoh/serializer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1186)

by Alessandro

created 2020-04-14 09:20 UTC

Lexer::getCatchablePatterns() A

↳ Parent: Lexer

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	7
c	2
b	0
f	0
nc	1
nop	0
dl	0
loc	9
rs	10

<?php

namespace JMS\Serializer\Type;

use Doctrine\Common\Lexer\AbstractLexer;
use Hoa\Exception\Exception;
use JMS\Serializer\Type\Exception\SyntaxError;

class Lexer extends AbstractLexer implements ParserInterface
{
    public function parse(string $type): array
    {
        try {
            return $this->getType($type);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        } catch (Exception $e) {
            throw new SyntaxError($e->getMessage(), 0, $e);
        }
    }

    protected function getCatchablePatterns(): array
    {
        return [
            '(?:[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*\\)*[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*', // name
            '(\+|\-)?(0|[1-9]\d*)(\.\d+)?', // number
            'null',
            '""|\'\'', // empty string
            '"[^"]+"', // quoted string
            "'[^']+'", // apostrophed string
        ];
    }

    protected function getNonCatchablePatterns(): array
    {
        return [
            // TODO: Implement getNonCatchablePatterns() method.
        ];
    }

    protected function getType(&$value)
    {
        // TODO: Implement getType() method.
    }
}


1			<?php
2
3			namespace JMS\Serializer\Type;
4
5			use Doctrine\Common\Lexer\AbstractLexer;
6			use Hoa\Exception\Exception;
7			use JMS\Serializer\Type\Exception\SyntaxError;
8
9			class Lexer extends AbstractLexer implements ParserInterface
10			{
11			public function parse(string $type): array
12			{
13			try {
14			return $this->getType($type);
			0 ignored issues – show Bug Best Practice introduced 2020-04-14 09:32 UTC by Report Bug Copy Issue Report The expression `return $this->getType($type)` returns the type `null` which is incompatible with the type-hinted return `array`. Loading history... Bug introduced 2020-04-14 09:32 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->getType($type)` targeting `JMS\Serializer\Type\Lexer::getType()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
15			} catch (Exception $e) {
16			throw new SyntaxError($e->getMessage(), 0, $e);
17			}
18			}
19
20			protected function getCatchablePatterns(): array
21			{
22			return [
23			'(?:[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]\\)[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*', // name
24			'(\+\|\-)?(0\|[1-9]\d*)(\.\d+)?', // number
25			'null',
26			'""\|\'\'', // empty string
27			'"[^"]+"', // quoted string
28			"'[^']+'", // apostrophed string
29			];
30			}
31
32			protected function getNonCatchablePatterns(): array
33			{
34			return [
35			// TODO: Implement getNonCatchablePatterns() method.
36			];
37			}
38
39			protected function getType(&$value)
40			{
41			// TODO: Implement getType() method.
42			}
43			}
44

schmittjoh / serializer

Pull Request — master (#1186)

Lexer::getCatchablePatterns() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like