Metadata\Cache\FileCache

Complexity

Total Complexity

11

Size/Duplication

Total Lines	75
Duplicated Lines	21.33 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	6
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
A	loadClassMetadataFromCache()	9	9	2
A	evictClassMetadataFromCache()	7	7	2
A	getFileName()	0	4	1
A	putClassMetadataInCache()	0	16	4

<?php

namespace Metadata\Cache;

use Metadata\ClassMetadata;

Copyright notice missing

class FileCache implements CacheInterface

Missing class doc comment

{
    /**

Missing short description in doc comment

Tabs must be used to indent lines; spaces are not allowed

     * @var string

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    private $dir;

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * FileCache constructor.

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @param string $dir

Missing parameter comment

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function __construct($dir)

Tabs must be used to indent lines; spaces are not allowed

    {

Tabs must be used to indent lines; spaces are not allowed

        if (!is_dir($dir)) {

Tabs must be used to indent lines; spaces are not allowed

            throw new \InvalidArgumentException(sprintf('The directory "%s" does not exist.', $dir));

Tabs must be used to indent lines; spaces are not allowed

        }

Tabs must be used to indent lines; spaces are not allowed

        $this->dir = rtrim($dir, '\\/');

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Doc comment for parameter "$class" missing

Tabs must be used to indent lines; spaces are not allowed

     * {@inheritDoc}

Tabs must be used to indent lines; spaces are not allowed

     */

Missing @return tag in function comment

Tabs must be used to indent lines; spaces are not allowed

    public function loadClassMetadataFromCache(\ReflectionClass $class)

This method seems to be duplicated in your project.

Tabs must be used to indent lines; spaces are not allowed

    {

Tabs must be used to indent lines; spaces are not allowed

        $path = $this->dir.'/'.strtr($class->name, '\\', '-').'.cache.php';

Concat operator must be surrounded by spaces.

Tabs must be used to indent lines; spaces are not allowed

        if (!file_exists($path)) {

Tabs must be used to indent lines; spaces are not allowed

            return null;

Tabs must be used to indent lines; spaces are not allowed

        }

Tabs must be used to indent lines; spaces are not allowed

        return include $path;

Including files with "include" is not allowed; use "require_once" instead

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Doc comment for parameter "$metadata" missing

Tabs must be used to indent lines; spaces are not allowed

     * {@inheritDoc}

Tabs must be used to indent lines; spaces are not allowed

     */

Missing @return tag in function comment

Tabs must be used to indent lines; spaces are not allowed

    public function putClassMetadataInCache(ClassMetadata $metadata)

Tabs must be used to indent lines; spaces are not allowed

    {

Tabs must be used to indent lines; spaces are not allowed

        $path = $this->getFileName($metadata);

Tabs must be used to indent lines; spaces are not allowed

        if (file_exists($path) && !is_writable($path)) {

Tabs must be used to indent lines; spaces are not allowed

            throw new \RuntimeException("Cache file {$path} is not writable.");

Tabs must be used to indent lines; spaces are not allowed

        }

Tabs must be used to indent lines; spaces are not allowed

        if (false === (@file_put_contents($path,

Tabs must be used to indent lines; spaces are not allowed

                '<?php return unserialize(' . var_export(serialize($metadata), true) . ');')

Tabs must be used to indent lines; spaces are not allowed

        )) {

Tabs must be used to indent lines; spaces are not allowed

            throw new \RuntimeException("Can't not write new cache file to {$path}");

Tabs must be used to indent lines; spaces are not allowed

        };

Tabs must be used to indent lines; spaces are not allowed

        // Let's not break filesystems which do not support chmod.

Tabs must be used to indent lines; spaces are not allowed

        @chmod($path, 0666 & ~umask());

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Doc comment for parameter "$class" missing

Tabs must be used to indent lines; spaces are not allowed

     * {@inheritDoc}

Tabs must be used to indent lines; spaces are not allowed

     */

Missing @return tag in function comment

Tabs must be used to indent lines; spaces are not allowed

    public function evictClassMetadataFromCache(\ReflectionClass $class)

This method seems to be duplicated in your project.

Tabs must be used to indent lines; spaces are not allowed

    {

Tabs must be used to indent lines; spaces are not allowed

        $path = $this->dir.'/'.strtr($class->name, '\\', '-').'.cache.php';

Concat operator must be surrounded by spaces.

Tabs must be used to indent lines; spaces are not allowed

        if (file_exists($path)) {

Tabs must be used to indent lines; spaces are not allowed

            unlink($path);

Tabs must be used to indent lines; spaces are not allowed

        }

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Missing short description in doc comment

Tabs must be used to indent lines; spaces are not allowed

     * @param ClassMetadata $metadata

Missing parameter comment

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return string

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    private function getFileName(ClassMetadata $metadata)

Tabs must be used to indent lines; spaces are not allowed

    {

Tabs must be used to indent lines; spaces are not allowed

        return $this->dir . '/' . strtr($metadata->name, '\\', '-') . '.cache.php';

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

}