schmiddim / mvg-live-php

examples/led-matrix.php

<?php

/*
-s '' -e '' -n

*/
use  Mvg\Parser\Html\Departures;

There must be a single space after the USE keyword

use  Mvg\Parser\Html\Stations;

There must be a single space after the USE keyword

use Mvg\TextOutput\Departures as TextOutputDepartures;
use Mvg\TextOutput\Stations as TextOutputStations;
use Mvg\Factories\Departures as DeparturesFactory;
use Mvg\RequestHandler\Html\HttpGetDepartures;
use Mvg\LedMatrixOutput\Departures as LedMatrixOutPutDepartues;

require_once dirname(__FILE__) . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'vendor/autoload.php';

$searchForStations = array(
	'Bonner Platz',
	'Karl-Theodor-Straße',
	'Hohenzollernplatz'
);
$filterForStations = array(
	'Fürstenried West',
	'Sendlinger Tor',
	'Einsteinstraße',
	'Messestadt Ost',
);
#$filterForStations = [];

58% of this comment could be valid code. Did you maybe forget this after debugging?

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

$outputArrays = array();

Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space

$outputArrays['lines'] = array();
foreach ($searchForStations as $searchForStation) {
	$searchForStation = trim($searchForStation);
	$http = new HttpGetDepartures('http', 'www.mvg-live.de', 'ims/dfiStaticAuswahl.svc');

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

	$result = $http->getDeparturesForStation($searchForStation);

Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space

	$parser = new Departures($result);

Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space

	$departures = $parser->getDepartures();

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

	$factory = new DeparturesFactory($parser);

	$lineArray = (new LedMatrixOutPutDepartues($factory, $filterForStations))->getOutput();
	if (null !== $lineArray) {
		$outputArrays['lines'][] = $lineArray;
	}

}
$outputArrays['lineCount'] = count($outputArrays['lines']);

//ArduinoJson Library has trouble with unicode
ob_start();
echo iconv("UTF-8", "CP437",trim(json_encode($outputArrays)) );

The string literal UTF-8 does not require double quotes, as per coding-style, please use single quotes.

The string literal CP437 does not require double quotes, as per coding-style, please use single quotes.

$content = ob_get_contents();
$length = strlen($content);

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

header('Content-Length: '.$length);

As per coding style, files should not end with a newline character.