Mvg\Factories\Departures

Complexity

Total Complexity

15

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes	5
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getCurrentTime()	0	3	1
A	getStation()	0	3	1
A	getParserDepartures()	0	3	1
A	setParserDepartures()	0	3	1
A	__construct()	0	6	1
A	cmpObjects()	0	7	3
C	getItems()	0	25	7

<?php
/**
 * User: ms
 * Date: 29.08.15
 * Time: 21:15
 */
namespace Mvg\Factories;


use  Mvg\Parser\Html\Departures as ParserDepartures;

There must be a single space after the USE keyword

class Departures implements FactoryInterface {
	/**
	 * @var ParserDepartures null
	 */
	protected $parserDepartures = null;

	/**
	 * @var array
	 */
	protected $departures = array();

	public function __construct(ParserDepartures $parserDepartures) {
		$this->setParserDepartures($parserDepartures);
		$this->departures = $parserDepartures->getDepartures();
		usort($this->departures, array("Mvg\Factories\Departures", "cmpObjects"));

The string literal Mvg\Factories\Departures does not require double quotes, as per coding-style, please use single quotes.

The string literal cmpObjects does not require double quotes, as per coding-style, please use single quotes.

	}

	protected static function cmpObjects($a, $b) {

Avoid variables with short names like $a. Configured minimum length is 3.

Avoid variables with short names like $b. Configured minimum length is 3.

		if ($a->time === $b->time) {
			return 0;
		}
		return ($a->time > $b->time) ? +1 : -1;
	}

	/**
	 * Filter By Destination
	 * @param mixed $filter
	 * @return array
	 */
	public function getItems($filter = '') {
		if ('' === $filter) {
			return $this->departures;
		}
		if (null === $filter) {
			return $this->departures;
		}

		if( true === empty($filter)) {
			return $this->departures;
		}

		if (false === is_array($filter)) {
			$filter = [$filter];
		}

		$departures = array();

		foreach ($this->departures as $departure) {
			if (true === in_array($departure->destination, $filter)) {
				$departures[] = $departure;
			}
		}
		return $departures;
	}

	/**
	 * @return string
	 */
	public function getCurrentTime() {
		return $this->parserDepartures->getCurrentTime();
	}

	/**
	 * @return string
	 */
	public function getStation() {
		return $this->parserDepartures->getStation();
	}

	/**
	 * @return array

Should the return type not be ParserDepartures?

	 */
	protected function getParserDepartures() {
		return $this->parserDepartures;
	}

	/**
	 * @param ParserDepartures $parserDepartures
	 */
	protected function setParserDepartures(ParserDepartures $parserDepartures) {
		$this->parserDepartures = $parserDepartures;
	}


}