Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 14 | class User extends Authenticatable |
||
| 15 | { |
||
| 16 | use Notifiable; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string |
||
| 20 | */ |
||
| 21 | protected $table = 'users'; |
||
| 22 | /** |
||
| 23 | * @var bool |
||
| 24 | */ |
||
| 25 | public $timestamps = true; |
||
| 26 | /** |
||
| 27 | * @var array |
||
| 28 | */ |
||
| 29 | protected $fillable = ['username', 'emp_num', 'first_name', 'nickname', 'last_name', |
||
| 30 | 'email', 'phone', 'status', 'clearance', 'elig_date', 'inv', 'inv_close', 'destroyed_date', |
||
| 31 | 'supervisor_id', 'access_level', 'password', ]; |
||
| 32 | /** |
||
| 33 | * @var array |
||
| 34 | */ |
||
| 35 | protected $hidden = ['username', 'password', 'remember_token']; |
||
| 36 | |||
| 37 | |||
| 38 | /** |
||
| 39 | * @var array $logAttributes defines will log the changed attributes |
||
| 40 | */ |
||
| 41 | use LogsActivity; |
||
| 42 | protected static $logAttributes = ['username', 'emp_num', 'first_name', 'nickname', |
||
| 43 | 'last_name', 'email', 'phone', 'jpas_name', 'status', 'clearance', |
||
| 44 | 'elig_date', 'inv', 'inv_close', 'destroyed_date', 'role', 'supervisor_id', 'access_level', |
||
| 45 | 'last_logon', 'ip',]; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * make destroyed_date a Carbon instance. |
||
| 49 | */ |
||
| 50 | protected $dates = ['destroyed_date']; |
||
| 51 | |||
| 52 | public function supervisor() |
||
| 56 | |||
| 57 | public function subordinates() |
||
| 61 | |||
| 62 | public function attachments() |
||
| 66 | |||
| 67 | public function notes() |
||
| 71 | |||
| 72 | public function travels() |
||
| 76 | |||
| 77 | public function visits() |
||
| 81 | |||
| 82 | public function assignedTrainings() |
||
| 86 | |||
| 87 | public function trainingUsers() |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany |
||
| 94 | */ |
||
| 95 | public function trainings() |
||
| 99 | |||
| 100 | /** |
||
| 101 | * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany |
||
| 102 | */ |
||
| 103 | public function groups() |
||
| 107 | |||
| 108 | /** |
||
| 109 | * @return \Illuminate\Database\Eloquent\Relations\MorphMany |
||
| 110 | */ |
||
| 111 | public function duties() |
||
| 115 | |||
| 116 | public function dutySwap() |
||
| 120 | |||
| 121 | public function news() |
||
| 125 | |||
| 126 | /** |
||
| 127 | * If we have a nickname, return 'lastname, nickname' otherwise return 'lastname, firstname'. |
||
| 128 | * |
||
| 129 | * @return string |
||
| 130 | */ |
||
| 131 | public function getUserFullNameAttribute() |
||
| 145 | |||
| 146 | /** |
||
| 147 | * @param $query |
||
| 148 | * @param $input |
||
| 149 | */ |
||
| 150 | public function scopeSearchUsers($query, $input) |
||
| 156 | |||
| 157 | /** |
||
| 158 | * @param $query |
||
| 159 | * |
||
| 160 | * @return mixed |
||
| 161 | */ |
||
| 162 | public function scopeActive($query) |
||
| 166 | |||
| 167 | public function scopeSkipSystem($query) |
||
| 171 | |||
| 172 | /** |
||
| 173 | * @param string $key |
||
| 174 | * @param mixed $value |
||
| 175 | * |
||
| 176 | * @return $this |
||
| 177 | */ |
||
| 178 | View Code Duplication | public function setAttribute($key, $value) |
|
| 186 | |||
| 187 | /** |
||
| 188 | * @param $user |
||
| 189 | * Obtain the Activitylog for the designated user or for all users. |
||
| 190 | * Populate log array values ["comment", "updated_at", "user_fullname"] |
||
| 191 | * |
||
| 192 | * @return Log collection |
||
| 193 | */ |
||
| 194 | public function getUserLog($user=NULL) { |
||
| 221 | |||
| 222 | /** |
||
| 223 | * @param Array1 Array2 |
||
| 224 | * As array_diff function only checks one dimension of a n-dimensional array. |
||
| 225 | * arrayRecursiveDiff will compare n-dimensional. |
||
| 226 | * Will insure compared objects are arrays. |
||
| 227 | * @return DiffsArray |
||
| 228 | */ |
||
| 229 | private function arrayRecursiveDiff($aArray1, $aArray2) { |
||
| 249 | } |
||
| 250 |