Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | class User extends Authenticatable |
||
14 | { |
||
15 | use Notifiable; |
||
16 | |||
17 | /** |
||
18 | * @var string |
||
19 | */ |
||
20 | protected $table = 'users'; |
||
21 | /** |
||
22 | * @var bool |
||
23 | */ |
||
24 | public $timestamps = true; |
||
25 | /** |
||
26 | * @var array |
||
27 | */ |
||
28 | protected $fillable = ['username', 'emp_num', 'first_name', 'nickname', 'last_name', |
||
29 | 'email', 'phone', 'status', 'clearance', 'elig_date', 'inv', 'inv_close', 'destroyed_date', |
||
30 | 'supervisor_id', 'access_level', 'password', ]; |
||
31 | /** |
||
32 | * @var array |
||
33 | */ |
||
34 | protected $hidden = ['username', 'password', 'remember_token']; |
||
35 | |||
36 | /* |
||
37 | * @var array $logAttributes defines will log the changed attributes |
||
38 | */ |
||
39 | use LogsActivity; |
||
40 | protected static $logAttributes = ['username', 'emp_num', 'first_name', 'nickname', |
||
41 | 'last_name', 'email', 'phone', 'jpas_name', 'status', 'clearance', |
||
42 | 'elig_date', 'inv', 'inv_close', 'destroyed_date', 'role', 'supervisor_id', 'access_level', |
||
43 | 'last_logon', 'ip', ]; |
||
44 | |||
45 | /** |
||
46 | * make destroyed_date a Carbon instance. |
||
47 | */ |
||
48 | protected $dates = ['destroyed_date']; |
||
49 | |||
50 | public function supervisor() |
||
54 | |||
55 | public function subordinates() |
||
59 | |||
60 | public function attachments() |
||
64 | |||
65 | public function notes() |
||
69 | |||
70 | public function travels() |
||
74 | |||
75 | public function visits() |
||
79 | |||
80 | public function assignedTrainings() |
||
84 | |||
85 | public function trainingUsers() |
||
89 | |||
90 | /** |
||
91 | * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany |
||
92 | */ |
||
93 | public function trainings() |
||
97 | |||
98 | /** |
||
99 | * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany |
||
100 | */ |
||
101 | public function groups() |
||
105 | |||
106 | /** |
||
107 | * @return \Illuminate\Database\Eloquent\Relations\MorphMany |
||
108 | */ |
||
109 | public function duties() |
||
113 | |||
114 | public function dutySwap() |
||
118 | |||
119 | public function news() |
||
123 | |||
124 | /** |
||
125 | * If we have a nickname, return 'lastname, nickname' otherwise return 'lastname, firstname'. |
||
126 | * |
||
127 | * @return string |
||
128 | */ |
||
129 | public function getUserFullNameAttribute() |
||
143 | |||
144 | /** |
||
145 | * @param $query |
||
146 | * @param $input |
||
147 | */ |
||
148 | public function scopeSearchUsers($query, $input) |
||
154 | |||
155 | /** |
||
156 | * @param $query |
||
157 | * |
||
158 | * @return mixed |
||
159 | */ |
||
160 | public function scopeActive($query) |
||
164 | |||
165 | public function scopeSkipSystem($query) |
||
169 | |||
170 | /** |
||
171 | * @param string $key |
||
172 | * @param mixed $value |
||
173 | * |
||
174 | * @return $this |
||
175 | */ |
||
176 | View Code Duplication | public function setAttribute($key, $value) |
|
184 | |||
185 | /** |
||
186 | * @param $user |
||
187 | * Obtain the Activitylog for the designated user or for all users. |
||
188 | * Populate log array values ["comment", "updated_at", "user_fullname"] |
||
189 | * |
||
190 | * @return Log collection |
||
191 | */ |
||
192 | public function getUserLog($user = null) |
||
225 | |||
226 | /** |
||
227 | * @param Array1 Array2 |
||
228 | * As array_diff function only checks one dimension of a n-dimensional array. |
||
229 | * arrayRecursiveDiff will compare n-dimensional. |
||
230 | * Will insure compared objects are arrays. |
||
231 | * |
||
232 | * @return DiffsArray |
||
233 | */ |
||
234 | private function arrayRecursiveDiff($aArray1, $aArray2) |
||
259 | } |
||
260 |