Completed
Push — master ( 30a987...803025 )
by Sheela
09:36
created

StoreUserRequest   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 42
Duplicated Lines 23.81 %

Coupling/Cohesion

Components 0
Dependencies 1

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 3
lcom 0
cbo 1
dl 10
loc 42
ccs 0
cts 12
cp 0
rs 10
c 0
b 0
f 0

3 Methods

Rating   Name   Duplication   Size   Complexity  
A authorize() 0 4 1
A rules() 0 13 1
A messages() 10 10 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace SET\Http\Requests;
4
5
use Illuminate\Support\Facades\Gate;
6
7
class StoreUserRequest extends Request
8
{
9
    /**
10
     * Determine if the user is authorized to make this request.
11
     *
12
     * @return bool
13
     */
14
    public function authorize()
15
    {
16
        return Gate::allows('edit');
17
    }
18
19
    /**
20
     * Get the validation rules that apply to the request.
21
     *
22
     * @return array
23
     */
24
    public function rules()
25
    {
26
        return [
27
            'first_name' => 'required',
28
            'last_name'  => 'required',
29
            'email'      => 'required|email|unique:users,email',
30
            'accessTokens.cac_issue_date' => 'required_if:accessTokens.cac_issued,1',
31
            'accessTokens.cac_expiration_date' => 'required_if:accessTokens.cac_issued,1',
32
            'accessTokens.sipr_issue_date' => 'required_if:accessTokens.sipr_issued,1',
33
            'accessTokens.sipr_expiration_date' => 'required_if:accessTokens.sipr_issued,1',
34
            'cont_eval_date' => 'required_if:cont_eval,1',
35
        ];
36
    }
37
38 View Code Duplication
    public function messages()
39
    {
40
        return [
41
            'cont_eval_date.required_if'  => 'You must select a Continuous Evaluation date if Continuous Evaluation is set to Yes',
42
            'accessTokens.cac_issue_date.required_if'  => 'You must select a CAC Issued Date if CAC Issued is set to Yes',
43
            'accessTokens.cac_expiration_date.required_if'  => 'You must select a CAC Expiration Date if CAC Issued is set to Yes',
44
            'accessTokens.sipr_issue_date.required_if'  => 'You must select a SIPR TOKEN Issued Date if SIPR TOKEN Issued is set to Yes',
45
            'accessTokens.sipr_expiration_date.required_if'  => 'You must select a SIPR TOKEN Expiration Date if SIPR TOKEN Issued is set to Yes',
46
        ];
47
    }
48
}
49