DutyUpcoming::generateICS() - Code Metrics - Inspection of "Tests and refactors for commands" - scci/security-employee-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

by Shawn

created 2016-11-16 21:51 UTC

DutyUpcoming::generateICS() A

↳ Parent: DutyUpcoming

Complexity

Conditions	3
Paths	3

Size

Total Lines	53
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	53
rs	9.5797
c	0
b	0
f	0
cc	3
eloc	43
nc	3
nop	0

How to fix Long Method

<?php

namespace SET\Mail;

use Carbon\Carbon;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;
use SET\Duty;
use SET\Setting;
use SET\User;

class DutyUpcoming extends Mailable implements ShouldQueue
{
    use Queueable, SerializesModels;

    public $user;
    public $date;
    public $duty;

    /**
     * DutyUpcoming constructor.
     *
     * @param Duty $duty
     * @param User $user
     * @param $date
     */
    public function __construct(Duty $duty, User $user, $date)
    {
        $this->duty = $duty;
        $this->user = $user;
        $this->date = $date;
    }

    /**
     * Build the message.
     *
     * @return $this
     */
    public function build()
    {
        $filename = $this->generateICS();

        if ($this->duty->cycle = 'daily') {
            $subject = 'You have '.$this->duty->name." security check on $this->date.";
        } else {
            $subject = 'You have '.$this->duty->name." security check starting $this->date.";
        }

        return $this->view('emails.duty_future')
            ->subject($subject)
            ->attach($filename, ['mime' => 'text/calendar']);
    }

    /**
     * Make our ICS file.
     *
     * @return string
     */
    private function generateICS()
    {
        $date = Carbon::createFromFormat('Y-m-d', $this->date);

        $reportAddress = Setting::where('name', 'report_address')->first();

        $rrule = '';
        if ($this->duty->cycle == 'weekly') {
            $rrule = 'RRULE:FREQ=DAILY;COUNT=5;INTERVAL=1;';
        } elseif ($this->duty->cycle == 'daily') {
            $rrule = 'RRULE:FREQ=DAILY;COUNT=1;INTERVAL=1;';
        }

        $filename = 'schedule.ics';
        $meetingDuration = (1800); // 30 minutes
        $time = 'T15:30:00.00';
        $meetingstamp = strtotime($date->toFormattedDateString().$time);
        $dtstart = gmdate('Ymd\THis\Z', $meetingstamp);
        $dtend = gmdate('Ymd\THis\Z', $meetingstamp + $meetingDuration);
        $todaystamp = gmdate('Ymd\THis\Z');
        $title = "You have $this->duty->name security check";
        $organizer = 'MAILTO:'.$reportAddress->secondary;

        // ICS
        $mail = [];
        $mail[0] = 'BEGIN:VCALENDAR';
        $mail[1] = 'PRODID:-//Microsoft Corporation//Outlook 11.0 MIMEDIR//EN';
        $mail[2] = 'VERSION:2.0';
        $mail[3] = 'CALSCALE:GREGORIAN';
        $mail[4] = 'METHOD:REQUEST';
        $mail[5] = 'BEGIN:VEVENT';
        $mail[6] = 'DTSTART;TZID=America/Chicago:'.$dtstart;
        $mail[7] = 'DTEND;TZID=America/Chicago:'.$dtend;
        $mail[8] = 'DTSTAMP;TZID=America/Chicago:'.$todaystamp;
        $mail[9] = 'UID:'.date('Ymd').'T'.date('His').'-'.rand().'@teamscci.com';
        $mail[10] = 'ORGANIZER;'.$organizer;
        $mail[11] = 'CREATED:'.$todaystamp;
        $mail[12] = 'LAST-MODIFIED:'.$todaystamp;
        $mail[14] = 'SEQUENCE:0';
        $mail[15] = 'STATUS:CONFIRMED';
        $mail[16] = 'SUMMARY:'.$title;
        $mail[17] = 'TRANSP:OPAQUE';
        $mail[18] = 'X-MICROSOFT-CDO-IMPORTANTCE:1';
        $mail[19] = $rrule;
        $mail[20] = 'END:VEVENT';
        $mail[21] = 'END:VCALENDAR';

        $mail = implode("\r\n", $mail);
        header('text/calendar');
        file_put_contents($filename, $mail);

        return $filename;
    }
}


1			<?php
2
3			namespace SET\Mail;
4
5			use Carbon\Carbon;
6			use Illuminate\Bus\Queueable;
7			use Illuminate\Contracts\Queue\ShouldQueue;
8			use Illuminate\Mail\Mailable;
9			use Illuminate\Queue\SerializesModels;
10			use SET\Duty;
11			use SET\Setting;
12			use SET\User;
13
14			class DutyUpcoming extends Mailable implements ShouldQueue
15			{
16			use Queueable, SerializesModels;
17
18			public $user;
19			public $date;
20			public $duty;
21
22			/**
23			* DutyUpcoming constructor.
24			*
25			* @param Duty $duty
26			* @param User $user
27			* @param $date
28			*/
29			public function __construct(Duty $duty, User $user, $date)
30			{
31			$this->duty = $duty;
32			$this->user = $user;
33			$this->date = $date;
34			}
35
36			/**
37			* Build the message.
38			*
39			* @return $this
40			*/
41			public function build()
42			{
43			$filename = $this->generateICS();
44
45			if ($this->duty->cycle = 'daily') {
46			$subject = 'You have '.$this->duty->name." security check on $this->date.";
47			} else {
48			$subject = 'You have '.$this->duty->name." security check starting $this->date.";
49			}
50
51			return $this->view('emails.duty_future')
52			->subject($subject)
53			->attach($filename, ['mime' => 'text/calendar']);
54			}
55
56			/**
57			* Make our ICS file.
58			*
59			* @return string
60			*/
61			private function generateICS()
62			{
63			$date = Carbon::createFromFormat('Y-m-d', $this->date);
64
65			$reportAddress = Setting::where('name', 'report_address')->first();
66
67			$rrule = '';
68			if ($this->duty->cycle == 'weekly') {
69			$rrule = 'RRULE:FREQ=DAILY;COUNT=5;INTERVAL=1;';
70			} elseif ($this->duty->cycle == 'daily') {
71			$rrule = 'RRULE:FREQ=DAILY;COUNT=1;INTERVAL=1;';
72			}
73
74			$filename = 'schedule.ics';
75			$meetingDuration = (1800); // 30 minutes
76			$time = 'T15:30:00.00';
77			$meetingstamp = strtotime($date->toFormattedDateString().$time);
78			$dtstart = gmdate('Ymd\THis\Z', $meetingstamp);
79			$dtend = gmdate('Ymd\THis\Z', $meetingstamp + $meetingDuration);
80			$todaystamp = gmdate('Ymd\THis\Z');
81			$title = "You have $this->duty->name security check";
82			$organizer = 'MAILTO:'.$reportAddress->secondary;
83
84			// ICS
85			$mail = [];
86			$mail[0] = 'BEGIN:VCALENDAR';
87			$mail[1] = 'PRODID:-//Microsoft Corporation//Outlook 11.0 MIMEDIR//EN';
88			$mail[2] = 'VERSION:2.0';
89			$mail[3] = 'CALSCALE:GREGORIAN';
90			$mail[4] = 'METHOD:REQUEST';
91			$mail[5] = 'BEGIN:VEVENT';
92			$mail[6] = 'DTSTART;TZID=America/Chicago:'.$dtstart;
93			$mail[7] = 'DTEND;TZID=America/Chicago:'.$dtend;
94			$mail[8] = 'DTSTAMP;TZID=America/Chicago:'.$todaystamp;
95			$mail[9] = 'UID:'.date('Ymd').'T'.date('His').'-'.rand().'@teamscci.com';
96			$mail[10] = 'ORGANIZER;'.$organizer;
97			$mail[11] = 'CREATED:'.$todaystamp;
98			$mail[12] = 'LAST-MODIFIED:'.$todaystamp;
99			$mail[14] = 'SEQUENCE:0';
100			$mail[15] = 'STATUS:CONFIRMED';
101			$mail[16] = 'SUMMARY:'.$title;
102			$mail[17] = 'TRANSP:OPAQUE';
103			$mail[18] = 'X-MICROSOFT-CDO-IMPORTANTCE:1';
104			$mail[19] = $rrule;
105			$mail[20] = 'END:VEVENT';
106			$mail[21] = 'END:VCALENDAR';
107
108			$mail = implode("\r\n", $mail);
109			header('text/calendar');
110			file_put_contents($filename, $mail);
111
112			return $filename;
113			}
114			}
115

scci / security-employee-tracker

Pull Request — master (#21)

DutyUpcoming::generateICS() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like