SET\Http\Controllers\Installation\EnvironmentController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	7	1
A	store()	0	9	1
A	breakApartEnv()	0	6	1

<?php

namespace SET\Http\Controllers\Installation;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Artisan;
use RachidLaasri\LaravelInstaller\Helpers\EnvironmentManager;
use SET\Http\Controllers\Controller;

class EnvironmentController extends Controller
{

    /**
     * @var EnvironmentManager
     */
    protected $EnvironmentManager;

    /**
     * @param EnvironmentManager $environmentManager
     */
    public function __construct(EnvironmentManager $environmentManager)
    {
        $this->EnvironmentManager = $environmentManager;
    }

    /**
     * Display the Environment page.
     *
     * @return \Illuminate\View\View
     */
    public function index()
    {
        $envConfig = $this->EnvironmentManager->getEnvContent();
        $fields = $this->breakApartEnv($envConfig);

        return view('vendor.installer.environment', compact('fields'));

The expression view('vendor.installer.environment', compact('fields')); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 36 which is incompatible with the return type documented by SET\Http\Controllers\Installation\EnvironmentController::index of type Illuminate\View\View.

    }


    /**
     * Processes the newly saved environment configuration and redirects back.
     *
     * @param Request $input
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Request $input)
    {
        $message = $this->EnvironmentManager->saveFile($input);

        Artisan::call('generate:key');

        return $this->route('LaravelInstaller::requirements')

The method route does not exist on object<SET\Http\Controllers\Installation\EnvironmentController>? Since you implemented __call, maybe consider adding a @method annotation.

            ->with(['message' => $message]);
    }

    /**
     * Key should be before the first = symbol and value should be after.
     * Each new line (\r\n) should be a new array entry.
     * @param $string
     * @return array
     */
    private function breakApartEnv($string)
    {
        preg_match_all('/([^=]*?)=([^\r\n]*?)[\r\n]+/', $string, $matches);

        return array_combine($matches[1], $matches[2]);
    }

}