InstallController - Code Metrics - Inspection of "Web installer" - scci/security-employee-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Shawn

created 2016-10-29 01:34 UTC

InstallController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	5
dl	0
loc	32
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	createUser()	0	7	1
A	storeUser()	0	11	1

<?php

namespace SET\Http\Controllers;

use Illuminate\Support\Facades\Hash;
use RachidLaasri\LaravelInstaller\Helpers\InstalledFileManager;
use RachidLaasri\LaravelInstaller\Helpers\DatabaseManager;
use SET\Http\Requests\InstallationRequest;
use SET\User;

class InstallController extends Controller
{

    public function createUser()
    {
        $response = (new DatabaseManager)->migrateAndSeed();

        return view('vendor.installer.user')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with(['message' => $response]);
    }

    /**
     * Replaces RachidLaasri\LaravelInstaller\Controllers\FinalController
     * so that we can also create the admin user.
     *
     * @param InstallationRequest $request
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     *
     */

    public function storeUser(InstallationRequest $request)
    {
        $user = User::create($request->all());
        $user->password = Hash::make($request->password);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->role = 'edit';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->save();

        (new InstalledFileManager)->update();

        return view('vendor.installer.finished');
    }
}


1			<?php
2
3			namespace SET\Http\Controllers;
4
5			use Illuminate\Support\Facades\Hash;
6			use RachidLaasri\LaravelInstaller\Helpers\InstalledFileManager;
7			use RachidLaasri\LaravelInstaller\Helpers\DatabaseManager;
8			use SET\Http\Requests\InstallationRequest;
9			use SET\User;
10
11			class InstallController extends Controller
12			{
13
14			public function createUser()
15			{
16			$response = (new DatabaseManager)->migrateAndSeed();
17
18			return view('vendor.installer.user')
			1 ignored issue – show Bug introduced 2016-10-29 01:40 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
19			->with(['message' => $response]);
20			}
21
22			/**
23			* Replaces RachidLaasri\LaravelInstaller\Controllers\FinalController
24			* so that we can also create the admin user.
25			*
26			* @param InstallationRequest $request
27			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
28			*
29			*/
30
31			public function storeUser(InstallationRequest $request)
32			{
33			$user = User::create($request->all());
34			$user->password = Hash::make($request->password);
			2 ignored issues – show Documentation introduced 2016-10-29 01:40 UTC by Report Bug Copy Issue Report The property `password` does not exist on `object<SET\User>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-10-29 01:40 UTC by Report Bug Copy Issue Report The property `password` does not exist on `object<SET\Http\Requests\InstallationRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
35			$user->role = 'edit';
			1 ignored issue – show Documentation introduced 2016-10-29 01:40 UTC by Report Bug Copy Issue Report The property `role` does not exist on `object<SET\User>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
36			$user->save();
37
38			(new InstalledFileManager)->update();
39
40			return view('vendor.installer.finished');
41			}
42			}
43

scci / security-employee-tracker

Pull Request — master (#3)

InstallController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like