Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | class User extends Authenticatable |
||
| 13 | { |
||
| 14 | use Notifiable; |
||
| 15 | |||
| 16 | /** |
||
| 17 | * @var string |
||
| 18 | */ |
||
| 19 | protected $table = 'users'; |
||
| 20 | /** |
||
| 21 | * @var bool |
||
| 22 | */ |
||
| 23 | public $timestamps = true; |
||
| 24 | /** |
||
| 25 | * @var array |
||
| 26 | */ |
||
| 27 | protected $fillable = ['username', 'emp_num', 'first_name', 'nickname', 'last_name', |
||
| 28 | 'email', 'phone', 'status', 'clearance', 'elig_date', 'inv', 'inv_close', 'destroyed_date', |
||
| 29 | 'supervisor_id', 'access_level', 'password', ]; |
||
| 30 | /** |
||
| 31 | * @var array |
||
| 32 | */ |
||
| 33 | protected $hidden = ['username', 'password', 'remember_token']; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * make destroyed_date a Carbon instance. |
||
| 37 | */ |
||
| 38 | protected $dates = ['destroyed_date']; |
||
| 39 | |||
| 40 | 5 | public function supervisor() |
|
| 44 | |||
| 45 | 2 | public function subordinates() |
|
| 49 | |||
| 50 | 2 | public function attachments() |
|
| 54 | |||
| 55 | 3 | public function notes() |
|
| 59 | |||
| 60 | 3 | public function travels() |
|
| 64 | |||
| 65 | 44 | public function visits() |
|
| 69 | |||
| 70 | 3 | public function assignedTrainings() |
|
| 74 | |||
| 75 | public function trainingUsers() |
||
| 79 | |||
| 80 | 1 | public function logs() |
|
| 84 | |||
| 85 | /** |
||
| 86 | * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany |
||
| 87 | */ |
||
| 88 | 4 | public function trainings() |
|
| 92 | |||
| 93 | /** |
||
| 94 | * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany |
||
| 95 | */ |
||
| 96 | 5 | public function groups() |
|
| 100 | |||
| 101 | /** |
||
| 102 | * @return \Illuminate\Database\Eloquent\Relations\MorphMany |
||
| 103 | */ |
||
| 104 | 2 | public function duties() |
|
| 108 | |||
| 109 | /** |
||
| 110 | * If we have a nickname, return 'lastname, nickname' otherwise return 'lastname, firstname'. |
||
| 111 | * |
||
| 112 | * @return string |
||
| 113 | */ |
||
| 114 | 54 | public function getUserFullNameAttribute() |
|
| 132 | |||
| 133 | /** |
||
| 134 | * @param $query |
||
| 135 | * @param $input |
||
| 136 | */ |
||
| 137 | 3 | public function scopeSearchUsers($query, $input) |
|
| 143 | |||
| 144 | /** |
||
| 145 | * @param $query |
||
| 146 | * |
||
| 147 | * @return mixed |
||
| 148 | */ |
||
| 149 | 60 | public function scopeActive($query) |
|
| 153 | |||
| 154 | 16 | public function scopeSkipSystem($query) |
|
| 158 | |||
| 159 | /** |
||
| 160 | * Store empty values as null in the DB. |
||
| 161 | * |
||
| 162 | * @param string $key |
||
| 163 | * @param mixed $value |
||
| 164 | * |
||
| 165 | * @return $this |
||
| 166 | */ |
||
| 167 | 126 | View Code Duplication | public function setAttribute($key, $value) |
| 175 | |||
| 176 | 4 | public function getDestroyDate($status) |
|
| 188 | } |
||
| 189 |