ProcessMonday::handle() - Code Metrics - Inspection of "Tests and refactors for commands" - scci/security-employee-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

by Shawn

created 2016-11-16 21:48 UTC

ProcessMonday::handle() A

↳ Parent: ProcessMonday

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0

<?php

namespace SET\Console\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\Mail;
use SET\Duty;
use SET\Handlers\Duty\DutyList;
use SET\Mail\EmailAdminSummary;
use SET\Setting;

class ProcessMonday extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'emails:monday';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Process all commands for monday & send single email to Reporter';

    protected $classesToProcess = [
        'notes'     => SendReminders::class,
        'visits'    => ExpiringVisits::class,
        'records'   => RenewTraining::class,
        'destroyed' => DeleteUsers::class,
    ];

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        foreach ($this->classesToProcess as $key => $class) {
            $mailArray[$key] = (new $class())->handle()->getList();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        $mailArray['dutyLists'] = $this->getDutyList();
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        //Send FSO a summary email with all the lists we retrieved.
        $this->sendReporterEmail($mailArray);
    }

    private function sendReporterEmail($array)
    {
        $reportAddress = Setting::where('name', 'report_address')->first();

        Mail::to($reportAddress->secondary, $reportAddress->primary)->send(new EmailAdminSummary($array));
    }

    /**
     * @return mixed
     */
    private function getDutyList()
    {
        $duties = Duty::all();

        return $duties->map(function ($item) {
            $userDateArray = (new DutyList($item))->emailOutput();
            $userDateArray->put('duty', $item);

            return $userDateArray;
        });
    }
}


1			<?php
2
3			namespace SET\Console\Commands;
4
5			use Illuminate\Console\Command;
6			use Illuminate\Support\Facades\Mail;
7			use SET\Duty;
8			use SET\Handlers\Duty\DutyList;
9			use SET\Mail\EmailAdminSummary;
10			use SET\Setting;
11
12			class ProcessMonday extends Command
13			{
14			/**
15			* The name and signature of the console command.
16			*
17			* @var string
18			*/
19			protected $signature = 'emails:monday';
20
21			/**
22			* The console command description.
23			*
24			* @var string
25			*/
26			protected $description = 'Process all commands for monday & send single email to Reporter';
27
28			protected $classesToProcess = [
29			'notes' => SendReminders::class,
30			'visits' => ExpiringVisits::class,
31			'records' => RenewTraining::class,
32			'destroyed' => DeleteUsers::class,
33			];
34
35			/**
36			* Execute the console command.
37			*
38			* @return mixed
39			*/
40			public function handle()
41			{
42			foreach ($this->classesToProcess as $key => $class) {
43			$mailArray[$key] = (new $class())->handle()->getList();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-16 21:46 UTC by Report Bug Copy Issue Report `$mailArray` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$mailArray = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
44			}
45
46			$mailArray['dutyLists'] = $this->getDutyList();
			0 ignored issues – show Bug introduced 2016-11-16 21:46 UTC by Report Bug Copy Issue Report The variable `$mailArray` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
47
48			//Send FSO a summary email with all the lists we retrieved.
49			$this->sendReporterEmail($mailArray);
50			}
51
52			private function sendReporterEmail($array)
53			{
54			$reportAddress = Setting::where('name', 'report_address')->first();
55
56			Mail::to($reportAddress->secondary, $reportAddress->primary)->send(new EmailAdminSummary($array));
57			}
58
59			/**
60			* @return mixed
61			*/
62			private function getDutyList()
63			{
64			$duties = Duty::all();
65
66			return $duties->map(function ($item) {
67			$userDateArray = (new DutyList($item))->emailOutput();
68			$userDateArray->put('duty', $item);
69
70			return $userDateArray;
71			});
72			}
73			}
74

scci / security-employee-tracker

Pull Request — master (#21)

ProcessMonday::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like