SET\Http\Controllers\TrainingTypeController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	105
Duplicated Lines	7.62 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	7	1
A	create()	0	6	1
A	store()	0	7	1
A	show()	0	8	1
A	edit()	0	6	1
A	update()	8	9	1
A	destroy()	0	7	1

<?php

namespace SET\Http\Controllers;

use Krucas\Notification\Facades\Notification;
use SET\Http\Requests\StoreTrainingTypeRequest;
use SET\TrainingType;

class TrainingTypeController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $this->authorize('view');
        $trainingtypes = TrainingType::orderBy('name')->get();

        return view('trainingtype.index', compact('trainingtypes'));
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $this->authorize('edit');

        return view('trainingtype.create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param StoreTrainingTypeRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(StoreTrainingTypeRequest $request)
    {
        $trainingtype = TrainingType::create($request->all());

$trainingtype is not used, you could remove the assignment.

        Notification::container()->success('Training Type Created');

        return redirect()->action('TrainingTypeController@index');
    }

    /**
     * Show the individual training type record.
     *
     * @param $trainingtypeId
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function show($trainingtypeId)
    {
        $this->authorize('view');
        $trainingtype = TrainingType::find($trainingtypeId);
        $trainings = $trainingtype->trainings;

        return view('trainingtype.show', compact('trainingtype', 'trainings'));
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param int $id

There is no parameter named $id. Was it maybe removed?

     *
     * @return \Illuminate\Http\Response
     */
    public function edit(TrainingType $trainingtype)
    {
        $this->authorize('edit');

        return view('trainingtype.edit', compact('trainingtype'));
    }

    /**
     * Update the specified resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param int                      $id

There is no parameter named $id. Was it maybe removed?

     *
     * @return \Illuminate\Http\Response
     */
    public function update(StoreTrainingTypeRequest $request, TrainingType $trainingtype)
    {
        $this->authorize('edit');
        $data = $request->all();
        $trainingtype->update($data);
        Notification::container()->success('Training Type Updated');

        return redirect()->action('TrainingTypeController@show', $trainingtype->id);

The property id does not exist on object<SET\TrainingType>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $this->authorize('edit');
        $trainingtype = TrainingType::findOrFail($id);
        $trainingtype->trainings()->update(['training_type_id'=>null]);
        $trainingtype->delete();
    }
}