SendNewsEmail   A
last analyzed

Complexity

Total Complexity 3

Size/Duplication

Total Lines 35
Duplicated Lines 11.43 %

Coupling/Cohesion

Components 1
Dependencies 3

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 3
lcom 1
cbo 3
dl 4
loc 35
ccs 0
cts 14
cp 0
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
A build() 4 13 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace SET\Mail;
4
5
use Illuminate\Bus\Queueable;
6
use Illuminate\Contracts\Queue\ShouldQueue;
7
use Illuminate\Mail\Mailable;
8
use Illuminate\Queue\SerializesModels;
9
use SET\News;
10
11
class SendNewsEmail extends Mailable implements ShouldQueue
12
{
13
    use Queueable, SerializesModels;
14
15
    public $news;
16
17
    /**
18
     * SendNewsEmail constructor.
19
     *
20
     * @param News $news
21
     */
22
    public function __construct(News $news)
23
    {
24
        $this->news = $news;
25
    }
26
27
    /**
28
     * Build the message.
29
     *
30
     * @return SendNewsEmail
31
     */
32
    public function build()
33
    {
34
        $mailer = $this->view('emails.published_news')
35
                ->subject($this->news->title);
36
37
        //ATTACH FILES
38 View Code Duplication
        foreach ($this->news->attachments as $file) {
39
            $path = 'app/news_'.$file->imageable_id.'/'.$file->filename;
40
            $mailer->attach(storage_path($path), ['as' => $file->filename, 'mime' => $file->mime]);
41
        }
42
43
        return $mailer;
44
    }
45
}
46