Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class DutyController extends Controller |
||
| 12 | { |
||
| 13 | public function index() |
||
| 19 | |||
| 20 | View Code Duplication | public function create() |
|
| 29 | |||
| 30 | public function store(DutyRequest $request) |
||
| 31 | { |
||
| 32 | $data = $request->all(); |
||
| 33 | $duty = Duty::create($data); |
||
| 34 | |||
| 35 | isset($data['groups']) |
||
| 36 | ? $duty->groups()->attach($data['groups']) |
||
| 37 | : $duty->users()->attach($data['users']); |
||
| 38 | |||
| 39 | return redirect()->action('DutyController@index'); |
||
| 40 | } |
||
| 41 | |||
| 42 | public function show($dutyID) |
||
| 49 | |||
| 50 | public function edit($dutyID) |
||
| 60 | |||
| 61 | public function update(DutyRequest $request, $dutyID) |
||
| 75 | |||
| 76 | public function destroy(Duty $duty) |
||
| 86 | } |
||
| 87 |